mbox series

[v3,0/9] vhost: improve logging

Message ID 20220126095510.389566-1-maxime.coquelin@redhat.com (mailing list archive)
Headers
Series vhost: improve logging |

Message

Maxime Coquelin Jan. 26, 2022, 9:55 a.m. UTC 
  This series aims at easing Vhost logs analysis, by
prepending the Vhost-user socket path to all logs and to
remove multi-line comments. Doing so, filtering Vhost-user
ports logs is much easier.

Changes in v3:
==============
- Fix various typos reported (Chenbo)
- Revert one multi-line comment removal (Chenbo)

Changes in v2:
==============
- Add missing socket paths (David)
- avoid identical logs in iotlb code (David)
- Use data log type when used in datapath (David)

Maxime Coquelin (9):
  vhost: improve IOTLB logs
  vhost: improve vDPA registration failure log
  vhost: improve Vhost layer logs
  vhost: improve Vhost-user layer logs
  vhost: improve socket layer logs
  vhost: improve Virtio-net layer logs
  vhost: remove multi-line logs
  vhost: differentiate IOTLB logs
  vhost: use proper logging type for data path

 lib/vhost/iotlb.c      |  30 +-
 lib/vhost/iotlb.h      |  10 +-
 lib/vhost/socket.c     | 148 ++++-----
 lib/vhost/vdpa.c       |   4 +-
 lib/vhost/vhost.c      | 108 ++++---
 lib/vhost/vhost_user.c | 678 ++++++++++++++++++++---------------------
 lib/vhost/vhost_user.h |   4 +-
 lib/vhost/virtio_net.c | 165 +++++-----
 8 files changed, 548 insertions(+), 599 deletions(-)

Comments

Chenbo Xia Jan. 27, 2022, 5:37 a.m. UTC | #1 
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, January 26, 2022 5:55 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v3 0/9] vhost: improve logging
> 
> This series aims at easing Vhost logs analysis, by
> prepending the Vhost-user socket path to all logs and to
> remove multi-line comments. Doing so, filtering Vhost-user
> ports logs is much easier.
> 
> Changes in v3:
> ==============
> - Fix various typos reported (Chenbo)
> - Revert one multi-line comment removal (Chenbo)
> 
> Changes in v2:
> ==============
> - Add missing socket paths (David)
> - avoid identical logs in iotlb code (David)
> - Use data log type when used in datapath (David)
> 
> Maxime Coquelin (9):
>   vhost: improve IOTLB logs
>   vhost: improve vDPA registration failure log
>   vhost: improve Vhost layer logs
>   vhost: improve Vhost-user layer logs
>   vhost: improve socket layer logs
>   vhost: improve Virtio-net layer logs
>   vhost: remove multi-line logs
>   vhost: differentiate IOTLB logs
>   vhost: use proper logging type for data path
> 
>  lib/vhost/iotlb.c      |  30 +-
>  lib/vhost/iotlb.h      |  10 +-
>  lib/vhost/socket.c     | 148 ++++-----
>  lib/vhost/vdpa.c       |   4 +-
>  lib/vhost/vhost.c      | 108 ++++---
>  lib/vhost/vhost_user.c | 678 ++++++++++++++++++++---------------------
>  lib/vhost/vhost_user.h |   4 +-
>  lib/vhost/virtio_net.c | 165 +++++-----
>  8 files changed, 548 insertions(+), 599 deletions(-)
> 
> --
> 2.34.1

Series applied to next-virtio/main, thanks
David Marchand Jan. 27, 2022, 8:09 a.m. UTC | #2 
On Thu, Jan 27, 2022 at 6:37 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > This series aims at easing Vhost logs analysis, by
> > prepending the Vhost-user socket path to all logs and to
> > remove multi-line comments. Doing so, filtering Vhost-user
> > ports logs is much easier.
> >
> > Changes in v3:
> > ==============
> > - Fix various typos reported (Chenbo)
> > - Revert one multi-line comment removal (Chenbo)
> >
> > Changes in v2:
> > ==============
> > - Add missing socket paths (David)
> > - avoid identical logs in iotlb code (David)
> > - Use data log type when used in datapath (David)
> >
> > Maxime Coquelin (9):
> >   vhost: improve IOTLB logs
> >   vhost: improve vDPA registration failure log
> >   vhost: improve Vhost layer logs
> >   vhost: improve Vhost-user layer logs
> >   vhost: improve socket layer logs
> >   vhost: improve Virtio-net layer logs
> >   vhost: remove multi-line logs
> >   vhost: differentiate IOTLB logs
> >   vhost: use proper logging type for data path
> >
> >  lib/vhost/iotlb.c      |  30 +-
> >  lib/vhost/iotlb.h      |  10 +-
> >  lib/vhost/socket.c     | 148 ++++-----
> >  lib/vhost/vdpa.c       |   4 +-
> >  lib/vhost/vhost.c      | 108 ++++---
> >  lib/vhost/vhost_user.c | 678 ++++++++++++++++++++---------------------
> >  lib/vhost/vhost_user.h |   4 +-
> >  lib/vhost/virtio_net.c | 165 +++++-----
> >  8 files changed, 548 insertions(+), 599 deletions(-)
> >
> > --
> > 2.34.1
>
> Series applied to next-virtio/main, thanks

For the series:
Reviewed-by: David Marchand <david.marchand@redhat.com>