mbox series

[v10,0/9] drivers/qat: QAT symmetric crypto datapatch rework

Message ID 20220222170226.90002-1-kai.ji@intel.com (mailing list archive)
Headers
Series drivers/qat: QAT symmetric crypto datapatch rework |

Message

Ji, Kai Feb. 22, 2022, 5:02 p.m. UTC
  This patch reworks QAT symmetric crypto datapatch implementation where each
generation request building separated and the crypto operation under the
raw datapath api implementation are unified.

In addtion this patchset also enables QAT OOP support in raw datapath api
implementation.

v10:
- rebase to the lastest for-main
- fix of build rerror when RTE_LOG_DEBUG enabled

v9:
- commit messages reword
- fix of unused function error

v8:
- rebase to 22.03-rc1

v7:
- fix of pointer cast compile error in x86

v6:
- fix of pointer cast error in x86
- rebase to the lastest for-main

v5:
- rebase to the latest for-main
- patchset reconstruct

v4:
- patchset break down and reconstruct

v3:
- sperate a single patch 6 to two different patches

v2:
- review comments addressed

Kai Ji (9):
  common/qat: define build request and dequeue ops
  crypto/qat: support symmetric build op request
  crypto/qat: rework session functions
  crypto/qat: rework asymmetric op build operation
  crypto/qat: unify symmetric functions
  crypto/qat: unify asymmetric functions
  crypto/qat: rework burst data path
  crypto/qat: unify raw data path functions
  crypto/qat: support out of place SG list

 drivers/common/qat/meson.build               |   6 +-
 drivers/common/qat/qat_device.c              |   4 +-
 drivers/common/qat/qat_qp.c                  |  42 +-
 drivers/common/qat/qat_qp.h                  |  54 +-
 drivers/compress/qat/qat_comp_pmd.c          |  14 +-
 drivers/crypto/qat/dev/qat_asym_pmd_gen1.c   |   9 +-
 drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c |  93 +-
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 490 ++++++++-
 drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 257 ++++-
 drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 913 ++++++++++++++++-
 drivers/crypto/qat/dev/qat_sym_pmd_gen1.c    | 942 +++++++++++++++++-
 drivers/crypto/qat/qat_asym.c                | 303 +++++-
 drivers/crypto/qat/qat_asym.h                |  79 +-
 drivers/crypto/qat/qat_asym_pmd.c            | 231 -----
 drivers/crypto/qat/qat_asym_pmd.h            |  54 -
 drivers/crypto/qat/qat_crypto.h              |  16 +-
 drivers/crypto/qat/qat_sym.c                 | 979 ++++++------------
 drivers/crypto/qat/qat_sym.h                 | 148 ++-
 drivers/crypto/qat/qat_sym_hw_dp.c           | 995 -------------------
 drivers/crypto/qat/qat_sym_pmd.c             | 251 -----
 drivers/crypto/qat/qat_sym_pmd.h             |  95 --
 drivers/crypto/qat/qat_sym_session.c         | 115 +--
 drivers/crypto/qat/qat_sym_session.h         |  15 +-
 23 files changed, 3582 insertions(+), 2523 deletions(-)
 delete mode 100644 drivers/crypto/qat/qat_asym_pmd.c
 delete mode 100644 drivers/crypto/qat/qat_asym_pmd.h
 delete mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c
 delete mode 100644 drivers/crypto/qat/qat_sym_pmd.c
 delete mode 100644 drivers/crypto/qat/qat_sym_pmd.h

--
2.17.1
  

Comments

Akhil Goyal Feb. 22, 2022, 6:23 p.m. UTC | #1
Hi Kai,

This is again not compiling. It has been v10 and most of the version are fixing one or the other compilation error.
You should fix your build system before sending out the next version.

/usr/bin/ld: drivers/a715181@@tmp_rte_common_qat@sta/crypto_qat_qat_sym.c.o:/home/gakhil/up/dpdk-next-crypto/build-clang-static/../drivers/crypto/qat/qat_sym.c:16: multiple definition of `qat_sym_driver_id'; drivers/a715181@@tmp_rte_common_qat@sta/crypto_qat_qat_sym_pmd.c.o:/home/gakhil/up/dpdk-next-crypto/build-clang-static/../drivers/crypto/qat/qat_sym_pmd.c:23: first defined here
/usr/bin/ld: drivers/a715181@@tmp_rte_common_qat@sta/crypto_qat_qat_sym.c.o:/home/gakhil/up/dpdk-next-crypto/build-clang-static/../drivers/crypto/qat/qat_sym.c:18: multiple definition of `qat_sym_gen_dev_ops'; drivers/a715181@@tmp_rte_common_qat@sta/crypto_qat_qat_sym_pmd.c.o:/home/gakhil/up/dpdk-next-crypto/build-clang-static/../drivers/crypto/qat/qat_sym_pmd.c:25: first defined here
clang: error: linker command failed with exit code 1 (use -v to see invocation)


> This patch reworks QAT symmetric crypto datapatch implementation where
> each
> generation request building separated and the crypto operation under the
> raw datapath api implementation are unified.
> 
> In addtion this patchset also enables QAT OOP support in raw datapath api
> implementation.
> 
> v10:
> - rebase to the lastest for-main
> - fix of build rerror when RTE_LOG_DEBUG enabled
> 
> v9:
> - commit messages reword
> - fix of unused function error
> 
> v8:
> - rebase to 22.03-rc1
> 
> v7:
> - fix of pointer cast compile error in x86
> 
> v6:
> - fix of pointer cast error in x86
> - rebase to the lastest for-main
> 
> v5:
> - rebase to the latest for-main
> - patchset reconstruct
> 
> v4:
> - patchset break down and reconstruct
> 
> v3:
> - sperate a single patch 6 to two different patches
> 
> v2:
> - review comments addressed
> 
> Kai Ji (9):
>   common/qat: define build request and dequeue ops
>   crypto/qat: support symmetric build op request
>   crypto/qat: rework session functions
>   crypto/qat: rework asymmetric op build operation
>   crypto/qat: unify symmetric functions
>   crypto/qat: unify asymmetric functions
>   crypto/qat: rework burst data path
>   crypto/qat: unify raw data path functions
>   crypto/qat: support out of place SG list
> 
>  drivers/common/qat/meson.build               |   6 +-
>  drivers/common/qat/qat_device.c              |   4 +-
>  drivers/common/qat/qat_qp.c                  |  42 +-
>  drivers/common/qat/qat_qp.h                  |  54 +-
>  drivers/compress/qat/qat_comp_pmd.c          |  14 +-
>  drivers/crypto/qat/dev/qat_asym_pmd_gen1.c   |   9 +-
>  drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c |  93 +-
>  drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 490 ++++++++-
>  drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 257 ++++-
>  drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 913 ++++++++++++++++-
>  drivers/crypto/qat/dev/qat_sym_pmd_gen1.c    | 942 +++++++++++++++++-
>  drivers/crypto/qat/qat_asym.c                | 303 +++++-
>  drivers/crypto/qat/qat_asym.h                |  79 +-
>  drivers/crypto/qat/qat_asym_pmd.c            | 231 -----
>  drivers/crypto/qat/qat_asym_pmd.h            |  54 -
>  drivers/crypto/qat/qat_crypto.h              |  16 +-
>  drivers/crypto/qat/qat_sym.c                 | 979 ++++++------------
>  drivers/crypto/qat/qat_sym.h                 | 148 ++-
>  drivers/crypto/qat/qat_sym_hw_dp.c           | 995 -------------------
>  drivers/crypto/qat/qat_sym_pmd.c             | 251 -----
>  drivers/crypto/qat/qat_sym_pmd.h             |  95 --
>  drivers/crypto/qat/qat_sym_session.c         | 115 +--
>  drivers/crypto/qat/qat_sym_session.h         |  15 +-
>  23 files changed, 3582 insertions(+), 2523 deletions(-)
>  delete mode 100644 drivers/crypto/qat/qat_asym_pmd.c
>  delete mode 100644 drivers/crypto/qat/qat_asym_pmd.h
>  delete mode 100644 drivers/crypto/qat/qat_sym_hw_dp.c
>  delete mode 100644 drivers/crypto/qat/qat_sym_pmd.c
>  delete mode 100644 drivers/crypto/qat/qat_sym_pmd.h
> 
> --
> 2.17.1