From patchwork Wed Feb 23 16:43:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Kozlyuk X-Patchwork-Id: 108185 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D6A3A00C3; Wed, 23 Feb 2022 17:43:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAC5440E5A; Wed, 23 Feb 2022 17:43:43 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2058.outbound.protection.outlook.com [40.107.236.58]) by mails.dpdk.org (Postfix) with ESMTP id ACE3D40DF6 for ; Wed, 23 Feb 2022 17:43:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eQIzfzAD/uSt5LvTNNENgu+a7y8YKGc5nkRVncIz1sNCLtdeDVGMImoHKsatHkoIMvpcp0jho2g7YUkLemv/lBmP8wTb8fS+SnWOiGOIZen3FPWsz6jQU8m7Dcgm5DPBCoIaCAxzL3zskxBoxBGmQ4rZlOrBQMBpTS42xhf/B4vUWqi9rUjqhsSezw2DxL41BEeAvLTZIqXw0OuEAVQrTWVN05ceIE73RPxMAzNcUAN0agjecJQi/H0f2MI+fbfKN302XuyVwRf6PxocbT3UJYkhRuSlmBFFbNF8+0wyFhPYAVQnEl1znyVjdbosbwZY5jqmov5mUxif212djlR+Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4fbe1lo6WhrxM5N0Ttu6u6A257e7BUd/sfJu8AFMLXA=; b=X3gYs7oojZuLPdkwfxZ97dZo32+hdOTEmgDmSFg+HDwwC2ijXJGD1Lr64Z+SuFZa+aaOTSMgrYFbV4InpHCOp6RwEsx3RynQb9aGnzMnOPU3d0Phr/8G3Z+7f7mpCwFEkSNzy9Y1yxkqSkcznVkjILh3D0SjcRHeYKHpd20cXS9LBnp7VDKzGfagdV4HzMvZ2lEURLeYgTMcqY1IizKXYEVtaU1oGBgTPtF9GOQ6v3Wq/FLK/mHfJOBZPt+1rKRWH6z43t3It7vm3bv8GoHv/SPGIdylnq6HKSy4KwtLC23bf8rB3xzX/hVLTo0wb5W9Lv7gnMRu1sEGDSfbd93F5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4fbe1lo6WhrxM5N0Ttu6u6A257e7BUd/sfJu8AFMLXA=; b=VEP6MVNf7S61ZqGmS4fRN4QJMmm55yyrKV6i0T6frEBRiZRIld8KbpSSDh6l9ywFSqaoq4QLnkxa0Sc3IFqTN2wGZui6OTTaBYqAzY2gRO2IVxlyu0JaFLofDxx6XAzsuzBdHMC9v6layJY8DAJ7uqqGMi+NOf3NuoiJb5UvxDoBJNpHqNGktJJyDnVRzNdDn4wWUkPdw2oLo8mT0lj3zAoiyH1ZXSzOKVxXKhWjA0tQAZ1DD3/F+m5AcJAGZCxTpltl/BuRoi3ivPE+pOaSZ3IE9Eg5I+ivKwjeYqjRA+r5R3JDVnN+jc32q2eBaFhiH1bmjbIWEgp5VVuk8ie95g== Received: from BN9P223CA0030.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::35) by DM6PR12MB4202.namprd12.prod.outlook.com (2603:10b6:5:219::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Wed, 23 Feb 2022 16:43:39 +0000 Received: from BN8NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10b:cafe::fb) by BN9P223CA0030.outlook.office365.com (2603:10b6:408:10b::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 23 Feb 2022 16:43:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.238) by BN8NAM11FT065.mail.protection.outlook.com (10.13.177.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 23 Feb 2022 16:43:39 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 23 Feb 2022 16:43:38 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Wed, 23 Feb 2022 08:43:36 -0800 Received: from nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.9 via Frontend Transport; Wed, 23 Feb 2022 08:43:36 -0800 From: Dmitry Kozlyuk To: Subject: [PATCH 0/3] net/mlx5: fix link state detection Date: Wed, 23 Feb 2022 18:43:30 +0200 Message-ID: <20220223164333.3834590-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68bbe8d9-3c98-4879-c4b2-08d9f6eba4e9 X-MS-TrafficTypeDiagnostic: DM6PR12MB4202:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bY6ke4nVXwxqvqj+q20p4Si8GzQ/vu9k+NJoLUxREojVRXrunAu7Fc5ZMm8vAfAqoaONvD1mrqkEbm1V4Rha0XMhyDQDSalU+Gvtf/1DeZbNHfZ5Iybrx05ZZDwRofmjjyF7xb4JsjlPbC50aHJzmM83gPHuqMYOhZBeiOCj+eJXHB1uWgdlB/u8RZua8bmAjDmloLHDzqu/TN8Rlv/RYG8C99KJX90nfQvFjzfoTA01sTJcz4GbY8ZADCSYWlt1n23vM0AF7guBhOB/+0iMOo0BGN2u0Iv1Y6wuR0W0zejneyqZi9qxN7Tk6tWWLSZYsNLoY7QzCrnAHQ1fHJ9kggSlkNnppt4KWFAtFNRIOOJY9tNtAumM0kTIPI3kemtGSZ/mvn0u8Bxbg6FE9SMhmk4JyqW019MEkaG/wU6/pMhmHAkRVsRAnq9wlytAthqBp2j22qxdWfahlHlKKYl7l9yDZ/Bf6Mgdmrw+e0geiF5gVb6tH19kMvzwSA9t1B3RXhTHochVRBiIUTQdVUQ9JmUhT6x75xdieDk+sJwCQ2h55Cm5G0QHKkyz6aqJ9ZyxGqkf5WWD+vN10FV+QNsi7cUPpNSZAOUvWrP517NSLbDZmavmXUHe4EeHCQrraS9+0SWxHAe3OvMbLskq/qMDHLVzwHD6CMuz5lWXgW6teHajikeRX9B7DkkW8x9pVlbCaJBds6sq/GZdq9Na0umqKg== X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6916009)(55016003)(316002)(2906002)(8676002)(508600001)(82310400004)(40460700003)(6666004)(7696005)(70206006)(70586007)(4744005)(5660300002)(8936002)(83380400001)(36860700001)(36756003)(356005)(81166007)(186003)(6286002)(26005)(426003)(1076003)(86362001)(2616005)(336012)(47076005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 16:43:39.2135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68bbe8d9-3c98-4879-c4b2-08d9f6eba4e9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4202 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset fixes two related issues: * In rare occasions with any HW link state change to UP was missed. * If a port was DOWN before startup, its netdev would come UP, but appear DOWN in DPDK (especially probable with ConnectX-4). Dmitry Kozlyuk (3): common/mlx5: add Netlink event helpers net/mlx5: fix link status change detection net/mlx5: fix initial link status detection drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/common/mlx5/linux/mlx5_nl.c | 102 ++++++++++++++++++++- drivers/common/mlx5/linux/mlx5_nl.h | 8 +- drivers/common/mlx5/version.map | 2 + drivers/net/mlx5/linux/mlx5_ethdev_os.c | 63 ++++++++++--- drivers/net/mlx5/linux/mlx5_os.c | 72 +++++++++++++-- drivers/net/mlx5/linux/mlx5_vlan_os.c | 2 +- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 3 + drivers/net/mlx5/mlx5_trigger.c | 12 ++- 10 files changed, 239 insertions(+), 28 deletions(-)