mbox series

[v4,0/9] bugfix for ethdev telemetry

Message ID 20220513025357.52275-1-fengchengwen@huawei.com (mailing list archive)
Headers show
Series bugfix for ethdev telemetry | expand

Message

fengchengwen May 13, 2022, 2:53 a.m. UTC
This patch set contains nine bugfix for ethdev telemetry.

Chengwen Feng (9):
  ethdev: specify return value of xstats-get API
  ethdev: optimize xstats-get API's implementation
  net/hns3: adjust return value of xstats-get ops
  net/ipn3ke: adjust return value of xstats-get ops
  net/mvpp2: adjust return value of xstats-get ops
  net/axgbe: adjust return value of xstats-get ops
  ethdev: fix memory leak when telemetry xstats
  ethdev: fix possible null pointer access
  net/cnxk: fix telemetry possible null pointer access

---
v4:
* refine the return value definitions of rte_eth_xstats_get() and
  the implementation of related drivers is corrected.
* drop auto-filled flag patch.
v3:
* refine the descriptor of return value when xstats is null of
  rte_eth_xstats_get().
* add patch for optimize xstats-get API's implementation.
v2:
* define return value when xstats is null of get xstats.
* fix more bugs when deepin ethdev telemetry.

 drivers/net/axgbe/axgbe_ethdev.c         |  8 ++++----
 drivers/net/cnxk/cnxk_ethdev_telemetry.c |  2 ++
 drivers/net/hns3/hns3_stats.c            |  9 +++++----
 drivers/net/ipn3ke/ipn3ke_representor.c  |  3 ---
 drivers/net/mvpp2/mrvl_ethdev.c          | 11 ++++++-----
 lib/ethdev/rte_ethdev.c                  | 18 ++++++++----------
 lib/ethdev/rte_ethdev.h                  |  6 +++++-
 7 files changed, 30 insertions(+), 27 deletions(-)

Comments

Morten Brørup May 16, 2022, 8:43 a.m. UTC | #1
> From: Chengwen Feng [mailto:fengchengwen@huawei.com]
> Sent: Friday, 13 May 2022 04.54
> 
> This patch set contains nine bugfix for ethdev telemetry.
> 
> Chengwen Feng (9):
>   ethdev: specify return value of xstats-get API
>   ethdev: optimize xstats-get API's implementation
>   net/hns3: adjust return value of xstats-get ops
>   net/ipn3ke: adjust return value of xstats-get ops
>   net/mvpp2: adjust return value of xstats-get ops
>   net/axgbe: adjust return value of xstats-get ops
>   ethdev: fix memory leak when telemetry xstats
>   ethdev: fix possible null pointer access
>   net/cnxk: fix telemetry possible null pointer access
> 
> ---

Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
Andrew Rybchenko May 20, 2022, 2:50 p.m. UTC | #2
On 5/16/22 11:43, Morten Brørup wrote:
>> From: Chengwen Feng [mailto:fengchengwen@huawei.com]
>> Sent: Friday, 13 May 2022 04.54
>>
>> This patch set contains nine bugfix for ethdev telemetry.
>>
>> Chengwen Feng (9):
>>    ethdev: specify return value of xstats-get API
>>    ethdev: optimize xstats-get API's implementation
>>    net/hns3: adjust return value of xstats-get ops
>>    net/ipn3ke: adjust return value of xstats-get ops
>>    net/mvpp2: adjust return value of xstats-get ops
>>    net/axgbe: adjust return value of xstats-get ops
>>    ethdev: fix memory leak when telemetry xstats
>>    ethdev: fix possible null pointer access
>>    net/cnxk: fix telemetry possible null pointer access
>>
>> ---
> 
> Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
> 

Series-reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

I did some fixes in patches summary and description,
please, double-check in next-net.

Applied, thanks.