mbox series

[V3,0/2] ethdev: fix MAC addrs list

Message ID 20220514020049.57294-1-humin29@huawei.com (mailing list archive)
Headers
Series ethdev: fix MAC addrs list |

Message

humin (Q) May 14, 2022, 2 a.m. UTC 
  From: Huisong Li <lihuisong@huawei.com>

The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC  
index, and other indexes can't be the same as the address corresponding to
index 0. If we break it, may cause following problems:                     
1) waste of MAC address spaces.                                            
2) a fake MAC address in the MAC list, isn't in hardware MAC entries.      
3) a MAC address is assigned to diffent pool.

Huisong Li (2):
  ethdev: fix one address occupies two indexes in MAC addrs
  ethdev: document default and non-default MAC address

---                                                      
v3:                                                                        
  - first explicitly remove the non-default MAC, then set default one.     
  - document default and non-default MAC address                           
                                                                           
v2:                                                                        
  - fixed commit log.

 lib/ethdev/ethdev_driver.h |  7 ++++++-
 lib/ethdev/rte_ethdev.c    | 39 ++++++++++++++++++++++++++++++++++++--
 2 files changed, 43 insertions(+), 3 deletions(-)

Comments

Andrew Rybchenko May 31, 2022, 3:22 p.m. UTC | #1 
On 5/14/22 05:00, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC
> index, and other indexes can't be the same as the address corresponding to
> index 0. If we break it, may cause following problems:
> 1) waste of MAC address spaces.
> 2) a fake MAC address in the MAC list, isn't in hardware MAC entries.
> 3) a MAC address is assigned to diffent pool.

The series looks broken in the patchwork. As the result unit tests
are run in a strange way. Please, format patches once again and send v4.
humin (Q) June 1, 2022, 6:43 a.m. UTC | #2 
Hi, Andrew,
	v4 has been sent. Thanks.

在 2022/5/31 23:22, Andrew Rybchenko 写道:
> On 5/14/22 05:00, Min Hu (Connor) wrote:
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC
>> index, and other indexes can't be the same as the address 
>> corresponding to
>> index 0. If we break it, may cause following problems:
>> 1) waste of MAC address spaces.
>> 2) a fake MAC address in the MAC list, isn't in hardware MAC entries.
>> 3) a MAC address is assigned to diffent pool.
> 
> The series looks broken in the patchwork. As the result unit tests
> are run in a strange way. Please, format patches once again and send v4.
> 
> .