| Message ID | 20220518101657.1230416-1-david.marchand@redhat.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 252B2A0503; Wed, 18 May 2022 12:17:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C063C40156; Wed, 18 May 2022 12:17:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D34A400D6 for <dev@dpdk.org>; Wed, 18 May 2022 12:17:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652869032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NGCFM8ox0qAqwqaXrk7MN8S5eXWeLZgQdaEcnbT/KZo=; b=gFyOFwBWLXSXmmMTZAooFTL3i1qF/HHDmjNN2fkQjhtoAU4J7L3oIcMSfwTruNKlugXa94 eva8stpwSjowOTsx1MxStJ7qMXITEYki+Uy+TdKTfMDrjiwzcXRlAqwtMm3sjmlfGsTQmg 3PrJuZmwoaKhdd8cVI+5ron0TnvLxX0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-169-2sBNuoXKNgaJURpIcFA7yg-1; Wed, 18 May 2022 06:17:10 -0400 X-MC-Unique: 2sBNuoXKNgaJURpIcFA7yg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A456811E9B; Wed, 18 May 2022 10:17:10 +0000 (UTC) Received: from fchome.home (unknown [10.40.195.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB85D492C14; Wed, 18 May 2022 10:17:08 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com Subject: [PATCH 00/12] Fix compilation with gcc 12 Date: Wed, 18 May 2022 12:16:45 +0200 Message-Id: <20220518101657.1230416-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
Fix compilation with gcc 12
|
|
Message
David Marchand
May 18, 2022, 10:16 a.m. UTC
Fedora 36 is out since early may and comes with gcc 12. This series fixes compilation or waives some checks. There might be something fishy with rte_memcpy on x86 but, for now, the rte_memcpy related fixes are on the caller side. Some "base" drivers have issues, I chose the simple solution of waiving the checks for them. Compilation is the only thing checked. Please driver maintainers, check nothing got broken.
Comments
On Wed, 18 May 2022 12:16:45 +0200 David Marchand <david.marchand@redhat.com> wrote: > Fedora 36 is out since early may and comes with gcc 12. > This series fixes compilation or waives some checks. > > There might be something fishy with rte_memcpy on x86 but, for now, > the rte_memcpy related fixes are on the caller side. > > Some "base" drivers have issues, I chose the simple solution of waiving > the checks for them. > > Compilation is the only thing checked. > Please driver maintainers, check nothing got broken. > We need to purge all code still using array size of one instead of proper flex array member.
> From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, 20 May 2022 22.14 > > On Wed, 18 May 2022 12:16:45 +0200 > David Marchand <david.marchand@redhat.com> wrote: > > > Fedora 36 is out since early may and comes with gcc 12. > > This series fixes compilation or waives some checks. > > > > There might be something fishy with rte_memcpy on x86 but, for now, > > the rte_memcpy related fixes are on the caller side. > > > > Some "base" drivers have issues, I chose the simple solution of > waiving > > the checks for them. > > > > Compilation is the only thing checked. > > Please driver maintainers, check nothing got broken. > > > > > We need to purge all code still using array size of one > instead of proper flex array member. +1 to that!
On Wed, May 18, 2022 at 12:17 PM David Marchand <david.marchand@redhat.com> wrote: > > Fedora 36 is out since early may and comes with gcc 12. > This series fixes compilation or waives some checks. > > There might be something fishy with rte_memcpy on x86 but, for now, > the rte_memcpy related fixes are on the caller side. > > Some "base" drivers have issues, I chose the simple solution of waiving > the checks for them. > > Compilation is the only thing checked. > Please driver maintainers, check nothing got broken. I applied the patches that got acked and that had no objection or comment from maintainers (i.e. patch 3, 4, 5, 6, 9, 11). I also cleaned the mess in bugzilla where we had multiple reports of the same issues, or stale bugs that I can't reproduce with released gcc 12. I'll respin separately the patches for which I have clear comments, and drop my patches waiving the compiler checks. We still need to agree on the best approach to handle the new checks. We have two rfc series from Stephen, how do we move forward?
On Wed, 15 Jun 2022 10:49:17 +0200 David Marchand <david.marchand@redhat.com> wrote: > On Wed, May 18, 2022 at 12:17 PM David Marchand > <david.marchand@redhat.com> wrote: > > > > Fedora 36 is out since early may and comes with gcc 12. > > This series fixes compilation or waives some checks. > > > > There might be something fishy with rte_memcpy on x86 but, for now, > > the rte_memcpy related fixes are on the caller side. > > > > Some "base" drivers have issues, I chose the simple solution of waiving > > the checks for them. > > > > Compilation is the only thing checked. > > Please driver maintainers, check nothing got broken. > > I applied the patches that got acked and that had no objection or > comment from maintainers (i.e. patch 3, 4, 5, 6, 9, 11). > I also cleaned the mess in bugzilla where we had multiple reports of > the same issues, or stale bugs that I can't reproduce with released > gcc 12. > > I'll respin separately the patches for which I have clear comments, > and drop my patches waiving the compiler checks. > > We still need to agree on the best approach to handle the new checks. > We have two rfc series from Stephen, how do we move forward? Lets fix all the bugs and remove any workarounds using pragma's. Some of them may mean removing rte_memcpy where it is not needed.
15/06/2022 16:45, Stephen Hemminger: > On Wed, 15 Jun 2022 10:49:17 +0200 > David Marchand <david.marchand@redhat.com> wrote: > > > On Wed, May 18, 2022 at 12:17 PM David Marchand > > <david.marchand@redhat.com> wrote: > > > > > > Fedora 36 is out since early may and comes with gcc 12. > > > This series fixes compilation or waives some checks. > > > > > > There might be something fishy with rte_memcpy on x86 but, for now, > > > the rte_memcpy related fixes are on the caller side. > > > > > > Some "base" drivers have issues, I chose the simple solution of waiving > > > the checks for them. > > > > > > Compilation is the only thing checked. > > > Please driver maintainers, check nothing got broken. > > > > I applied the patches that got acked and that had no objection or > > comment from maintainers (i.e. patch 3, 4, 5, 6, 9, 11). > > I also cleaned the mess in bugzilla where we had multiple reports of > > the same issues, or stale bugs that I can't reproduce with released > > gcc 12. > > > > I'll respin separately the patches for which I have clear comments, > > and drop my patches waiving the compiler checks. > > > > We still need to agree on the best approach to handle the new checks. > > We have two rfc series from Stephen, how do we move forward? > > Lets fix all the bugs and remove any workarounds using pragma's. > > Some of them may mean removing rte_memcpy where it is not needed. What about your series Stephen? Please would you like to respin?
On Wed, 15 Jun 2022 16:59:51 +0200 Thomas Monjalon <thomas@monjalon.net> wrote: > 15/06/2022 16:45, Stephen Hemminger: > > On Wed, 15 Jun 2022 10:49:17 +0200 > > David Marchand <david.marchand@redhat.com> wrote: > > > > > On Wed, May 18, 2022 at 12:17 PM David Marchand > > > <david.marchand@redhat.com> wrote: > > > > > > > > Fedora 36 is out since early may and comes with gcc 12. > > > > This series fixes compilation or waives some checks. > > > > > > > > There might be something fishy with rte_memcpy on x86 but, for now, > > > > the rte_memcpy related fixes are on the caller side. > > > > > > > > Some "base" drivers have issues, I chose the simple solution of waiving > > > > the checks for them. > > > > > > > > Compilation is the only thing checked. > > > > Please driver maintainers, check nothing got broken. > > > > > > I applied the patches that got acked and that had no objection or > > > comment from maintainers (i.e. patch 3, 4, 5, 6, 9, 11). > > > I also cleaned the mess in bugzilla where we had multiple reports of > > > the same issues, or stale bugs that I can't reproduce with released > > > gcc 12. > > > > > > I'll respin separately the patches for which I have clear comments, > > > and drop my patches waiving the compiler checks. > > > > > > We still need to agree on the best approach to handle the new checks. > > > We have two rfc series from Stephen, how do we move forward? > > > > Lets fix all the bugs and remove any workarounds using pragma's. > > > > Some of them may mean removing rte_memcpy where it is not needed. > > What about your series Stephen? > Please would you like to respin? > > Yes will recollate based on current main branch.