mbox series

[v2,0/2] fix uncallable unit tests (Bugzilla 1002)

Message ID 20220520151240.139566-1-bruce.richardson@intel.com (mailing list archive)
Headers
Series fix uncallable unit tests (Bugzilla 1002) |

Message

Bruce Richardson May 20, 2022, 3:12 p.m. UTC
  The dump* unit tests are uncallable from our test framework because the command
validation in the unit test binary is incorrect. Rather than trying to fix this
directly in the binary, a better approach is to add command validation to the
cmdline library - which already has 99% of what we need already - and use that
from the test app.

V2:
* Fix checkpatch issues

Bruce Richardson (2):
  cmdline: add function to verify valid commands
  test: use cmdline library to validate args

 app/test/commands.c         | 11 -----------
 app/test/test.c             | 24 +++++++-----------------
 lib/cmdline/cmdline_parse.c | 20 +++++++++++++++++---
 lib/cmdline/cmdline_parse.h | 17 +++++++++++++++--
 lib/cmdline/version.map     |  3 +++
 5 files changed, 42 insertions(+), 33 deletions(-)

--
2.34.1