mbox series

[0/6] Split driver specific commands out of testpmd

Message ID 20220523071031.1868862-1-david.marchand@redhat.com (mailing list archive)
Headers
Series Split driver specific commands out of testpmd |

Message

David Marchand May 23, 2022, 7:10 a.m. UTC 
  Hello,

Following TB decision [1] and recent discussions on the driver specific
commands in testpmd, here is a proposal on how the split could be done.

For now, this series simply moves the testpmd code in the driver
directory. The driver specific testpmd code is still compiled as part of
testpmd compilation via a global meson testpmd_driver_sources list.

Notes:
- ixgbe bypass commands in testpmd were "dead" code since switch to meson,
  as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd.
  No one complained about issue for the last two years, so those commands
  are dropped.


1: https://mails.dpdk.org/archives/dev/2022-April/239191.html

Comments

Ferruh Yigit May 23, 2022, 6:09 p.m. UTC | #1 
On 5/23/2022 8:10 AM, David Marchand wrote:
> Hello,
> 
> Following TB decision [1] and recent discussions on the driver specific
> commands in testpmd, here is a proposal on how the split could be done.
> 
> For now, this series simply moves the testpmd code in the driver
> directory. The driver specific testpmd code is still compiled as part of
> testpmd compilation via a global meson testpmd_driver_sources list.
> 
> Notes:
> - ixgbe bypass commands in testpmd were "dead" code since switch to meson,
>    as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd.
>    No one complained about issue for the last two years, so those commands
>    are dropped.
> 
> 
> 1:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpdk.org%2Farchives%2Fdev%2F2022-April%2F239191.html&data=05%7C01%7Cferruh.yigit%40amd.com%7C14ffb5d174e04def3edd08da3c8b59be%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637888866467042882%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XH8MQEiCmLkL%2FtX9BIaogwoaYLqy7ZrGAGQa7M7KM7A%3D&reserved=0
> 
> --
> David Marchand
> 
> Changes since RFC v2:
> - extended cleanup patch 1,
> - fixed command registration (again..),
> - dropped ixgbe bypass commands,
> - fixed some indent,
> - updated documentation,
> 
> Changes since RFC v1:
> - added a cleanup as patch 1, to make all parser symbols static,
> - fixed registering issue in patch 1,
> - moved more i40e specific commands, fixed checkpatch warnings,
> 
> David Marchand (6):
>    app/testpmd: mark most cmdline symbols as static
>    app/testpmd: register driver specific commands
>    net/bonding: move testpmd commands
>    net/i40e: move testpmd commands
>    app/testpmd: drop ixgbe bypass commands
>    net/ixgbe: move testpmd commands

+1 to split the PMD specific commands, and set lgtm. Thanks for the work.