mbox series

[v6,0/9] net/vmxnet3: support versions 5 and 6

Message ID 20220525004028.24938-1-pagupta@vmware.com (mailing list archive)
Headers
Series net/vmxnet3: support versions 5 and 6 |

Message

Pankaj Gupta May 25, 2022, 12:40 a.m. UTC 
  v6 (Andrew Rybchenko):
    Minor style changes in patches description
    Split FW version get patch to have callbacks reorder seperately
    Minor fix in FW version get patch to put callback definition,
    assignment and implementation just after device info get

v5:
    Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c
    User RETA instead of reta in commit message
    Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c

v4:
    Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error
    in initialization for rxDataRing feature" to
    "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")"

v3:
    adding Reviewed-by info in all the patches

v2:
    address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru

Pankaj Gupta (9):
  net/vmxnet3: add version 5 support
  net/vmxnet3: implement RETA query and RETA update
  net/vmxnet3: add Rx queue usage count utility
  net/vmxnet3: fix ethdev callbacks init order
  net/vmxnet3: report HW version on FW version get
  net/vmxnet3: add version 6 support
  net/vmxnet3: advertise RETA size in device info
  net/vmxnet3: set packet type for fragmented packet
  net/vmxnet3: fix merge error in Rx data ring initialization

 doc/guides/rel_notes/release_21_08.rst  |  12 +
 drivers/net/vmxnet3/base/vmxnet3_defs.h |  73 ++++-
 drivers/net/vmxnet3/vmxnet3_ethdev.c    | 339 +++++++++++++++++++-----
 drivers/net/vmxnet3/vmxnet3_ethdev.h    |  15 +-
 drivers/net/vmxnet3/vmxnet3_rxtx.c      |  49 +++-
 5 files changed, 400 insertions(+), 88 deletions(-)

Comments

Andrew Rybchenko May 31, 2022, 1:40 p.m. UTC | #1 
On 5/25/22 03:40, Pankaj Gupta wrote:
> v6 (Andrew Rybchenko):
>      Minor style changes in patches description
>      Split FW version get patch to have callbacks reorder seperately
>      Minor fix in FW version get patch to put callback definition,
>      assignment and implementation just after device info get
> 
> v5:
>      Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c
>      User RETA instead of reta in commit message
>      Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c
> 
> v4:
>      Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error
>      in initialization for rxDataRing feature" to
>      "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")"
> 
> v3:
>      adding Reviewed-by info in all the patches
> 
> v2:
>      address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru
> 
> Pankaj Gupta (9):
>    net/vmxnet3: add version 5 support
>    net/vmxnet3: implement RETA query and RETA update
>    net/vmxnet3: add Rx queue usage count utility
>    net/vmxnet3: fix ethdev callbacks init order
>    net/vmxnet3: report HW version on FW version get
>    net/vmxnet3: add version 6 support
>    net/vmxnet3: advertise RETA size in device info
>    net/vmxnet3: set packet type for fragmented packet
>    net/vmxnet3: fix merge error in Rx data ring initialization
> 
>   doc/guides/rel_notes/release_21_08.rst  |  12 +
>   drivers/net/vmxnet3/base/vmxnet3_defs.h |  73 ++++-
>   drivers/net/vmxnet3/vmxnet3_ethdev.c    | 339 +++++++++++++++++++-----
>   drivers/net/vmxnet3/vmxnet3_ethdev.h    |  15 +-
>   drivers/net/vmxnet3/vmxnet3_rxtx.c      |  49 +++-
>   5 files changed, 400 insertions(+), 88 deletions(-)
> 

Applied, thanks.

Please, double-check patches descriptor and release notes.
Andrew Rybchenko May 31, 2022, 1:41 p.m. UTC | #2 
On 5/31/22 16:40, Andrew Rybchenko wrote:
> On 5/25/22 03:40, Pankaj Gupta wrote:
>> v6 (Andrew Rybchenko):
>>      Minor style changes in patches description
>>      Split FW version get patch to have callbacks reorder seperately
>>      Minor fix in FW version get patch to put callback definition,
>>      assignment and implementation just after device info get
>>
>> v5:
>>      Use RTE_MIN instead of defining MIN in 
>> drivers/net/vmxnet3/vmxnet3_ethdev.c
>>      User RETA instead of reta in commit message
>>      Fix the issue thrown by checkpatches.sh in file 
>> drivers/net/vmxnet3/vmxnet3_ethdev.c
>>
>> v4:
>>      Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge 
>> error
>>      in initialization for rxDataRing feature" to
>>      "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")"
>>
>> v3:
>>      adding Reviewed-by info in all the patches
>>
>> v2:
>>      address review comments from Andrew Rybchenko 
>> andrew.rybchenko@oktetlabs.ru
>>
>> Pankaj Gupta (9):
>>    net/vmxnet3: add version 5 support
>>    net/vmxnet3: implement RETA query and RETA update
>>    net/vmxnet3: add Rx queue usage count utility
>>    net/vmxnet3: fix ethdev callbacks init order
>>    net/vmxnet3: report HW version on FW version get
>>    net/vmxnet3: add version 6 support
>>    net/vmxnet3: advertise RETA size in device info
>>    net/vmxnet3: set packet type for fragmented packet
>>    net/vmxnet3: fix merge error in Rx data ring initialization
>>
>>   doc/guides/rel_notes/release_21_08.rst  |  12 +
>>   drivers/net/vmxnet3/base/vmxnet3_defs.h |  73 ++++-
>>   drivers/net/vmxnet3/vmxnet3_ethdev.c    | 339 +++++++++++++++++++-----
>>   drivers/net/vmxnet3/vmxnet3_ethdev.h    |  15 +-
>>   drivers/net/vmxnet3/vmxnet3_rxtx.c      |  49 +++-
>>   5 files changed, 400 insertions(+), 88 deletions(-)
>>
> 
> Applied, thanks.

To make it less ambiguous:
Applied to dpdk-next-net/main

> 
> Please, double-check patches descriptor and release notes.
>