mbox series

[00/14] Add support of NFP3800 chip and firmware with NFDk

Message ID 20220602015304.710197-1-jin.liu@corigine.com (mailing list archive)
Headers
Series Add support of NFP3800 chip and firmware with NFDk |

Message

Jin Liu June 2, 2022, 1:52 a.m. UTC 
  NFD is part of NFP firmware, and there only exist a NFD3 version before
this patch series.
This patch series mainly add the support of the new NFP3800 chip use 
firmware with NFD3/NFDk.

Chaoyong He (2):
  net/nfp: change the coding style
  net/nfp: remove unnecessary forward function declaration

Jin Liu (12):
  net/nfp: remove pessimistic limit
  net/nfp: rename set MAC function
  net/nfp: rename function and struct
  net/nfp: support NFP3800 card
  net/nfp: support NFDK firmware
  net/nfp: structure adjustment
  net/nfp: nfdk netdev option and queue function
  net/nfp: add queue stop and close helper function
  net/nfp: nfdk stop and close function
  net/nfp: move macro from C file to head file
  net/nfp: nfdk packet xmit function
  net/nfp: modify RSS logic

 drivers/net/nfp/nfp_common.c          |  89 ++++-
 drivers/net/nfp/nfp_common.h          |  53 ++-
 drivers/net/nfp/nfp_ctrl.h            |   3 +
 drivers/net/nfp/nfp_ethdev.c          | 423 +++++++++++++--------
 drivers/net/nfp/nfp_ethdev_vf.c       | 215 +++++++----
 drivers/net/nfp/nfp_rxtx.c            | 505 +++++++++++++++++++++++---
 drivers/net/nfp/nfp_rxtx.h            |  89 ++++-
 drivers/net/nfp/nfpcore/nfp_cpp.h     |   2 +-
 drivers/net/nfp/nfpcore/nfp_nsp_eth.c |  20 +-
 drivers/net/nfp/nfpcore/nfp_rtsym.c   |  19 -
 drivers/net/nfp/nfpcore/nfp_rtsym.h   |  19 +
 11 files changed, 1128 insertions(+), 309 deletions(-)

Comments

Ferruh Yigit June 2, 2022, 10:51 p.m. UTC | #1 
On 6/2/2022 2:52 AM, Jin Liu wrote:
> NFD is part of NFP firmware, and there only exist a NFD3 version before
> this patch series.
> This patch series mainly add the support of the new NFP3800 chip use
> firmware with NFD3/NFDk.
> 

Hi Jin,

This set requires some documentation update. Current driver doc mentions 
that driver supports 'Agilio Basic Firmware' FW, I think overall new FW 
support should be documented and relevant parts needs to be updated.

Also can you please update the release notes for the set? Please update 
release notes in the relevant patch, instead of a separate doc patch.

> Chaoyong He (2):
>    net/nfp: change the coding style
>    net/nfp: remove unnecessary forward function declaration
> 
> Jin Liu (12):
>    net/nfp: remove pessimistic limit
>    net/nfp: rename set MAC function
>    net/nfp: rename function and struct
>    net/nfp: support NFP3800 card
>    net/nfp: support NFDK firmware
>    net/nfp: structure adjustment
>    net/nfp: nfdk netdev option and queue function
>    net/nfp: add queue stop and close helper function
>    net/nfp: nfdk stop and close function
>    net/nfp: move macro from C file to head file
>    net/nfp: nfdk packet xmit function
>    net/nfp: modify RSS logic
> 
>   drivers/net/nfp/nfp_common.c          |  89 ++++-
>   drivers/net/nfp/nfp_common.h          |  53 ++-
>   drivers/net/nfp/nfp_ctrl.h            |   3 +
>   drivers/net/nfp/nfp_ethdev.c          | 423 +++++++++++++--------
>   drivers/net/nfp/nfp_ethdev_vf.c       | 215 +++++++----
>   drivers/net/nfp/nfp_rxtx.c            | 505 +++++++++++++++++++++++---
>   drivers/net/nfp/nfp_rxtx.h            |  89 ++++-
>   drivers/net/nfp/nfpcore/nfp_cpp.h     |   2 +-
>   drivers/net/nfp/nfpcore/nfp_nsp_eth.c |  20 +-
>   drivers/net/nfp/nfpcore/nfp_rtsym.c   |  19 -
>   drivers/net/nfp/nfpcore/nfp_rtsym.h   |  19 +
>   11 files changed, 1128 insertions(+), 309 deletions(-)
>
Jin Liu June 14, 2022, 8:48 a.m. UTC | #2 
Yes, I will update documentation and release notes, thanks

-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@xilinx.com> 
Sent: Friday, June 3, 2022 06:51
To: Kevin Liu <jin.liu@corigine.com>
Cc: Niklas Soderlund <niklas.soderlund@corigine.com>; dev@dpdk.org
Subject: Re: [PATCH 00/14] Add support of NFP3800 chip and firmware with NFDk

On 6/2/2022 2:52 AM, Jin Liu wrote:
> NFD is part of NFP firmware, and there only exist a NFD3 version 
> before this patch series.
> This patch series mainly add the support of the new NFP3800 chip use 
> firmware with NFD3/NFDk.
> 

Hi Jin,

This set requires some documentation update. Current driver doc mentions that driver supports 'Agilio Basic Firmware' FW, I think overall new FW support should be documented and relevant parts needs to be updated.

Also can you please update the release notes for the set? Please update release notes in the relevant patch, instead of a separate doc patch.

> Chaoyong He (2):
>    net/nfp: change the coding style
>    net/nfp: remove unnecessary forward function declaration
> 
> Jin Liu (12):
>    net/nfp: remove pessimistic limit
>    net/nfp: rename set MAC function
>    net/nfp: rename function and struct
>    net/nfp: support NFP3800 card
>    net/nfp: support NFDK firmware
>    net/nfp: structure adjustment
>    net/nfp: nfdk netdev option and queue function
>    net/nfp: add queue stop and close helper function
>    net/nfp: nfdk stop and close function
>    net/nfp: move macro from C file to head file
>    net/nfp: nfdk packet xmit function
>    net/nfp: modify RSS logic
> 
>   drivers/net/nfp/nfp_common.c          |  89 ++++-
>   drivers/net/nfp/nfp_common.h          |  53 ++-
>   drivers/net/nfp/nfp_ctrl.h            |   3 +
>   drivers/net/nfp/nfp_ethdev.c          | 423 +++++++++++++--------
>   drivers/net/nfp/nfp_ethdev_vf.c       | 215 +++++++----
>   drivers/net/nfp/nfp_rxtx.c            | 505 +++++++++++++++++++++++---
>   drivers/net/nfp/nfp_rxtx.h            |  89 ++++-
>   drivers/net/nfp/nfpcore/nfp_cpp.h     |   2 +-
>   drivers/net/nfp/nfpcore/nfp_nsp_eth.c |  20 +-
>   drivers/net/nfp/nfpcore/nfp_rtsym.c   |  19 -
>   drivers/net/nfp/nfpcore/nfp_rtsym.h   |  19 +
>   11 files changed, 1128 insertions(+), 309 deletions(-)
>