mbox series

[0/2] fix wireless algorithm IVs

Message ID 20220623144250.1259901-1-ciara.power@intel.com (mailing list archive)
Headers
Series fix wireless algorithm IVs |

Message

Power, Ciara June 23, 2022, 2:42 p.m. UTC 
  Some of the ZUC and Snow3G test vectors did not follow
the specification for the cipher and authentication IVs.

These are now updated to follow the spec documents:
ZUC 128 spec: https://www.gsma.com/security/wp-content/uploads/2019/05/EEA3_EIA3_specification_v1_8.pdf
Snow3G spec: https://www.gsma.com/aboutus/wp-content/uploads/2014/12/uea2uia2d1v21.pdf

Ciara Power (2):
  test/crypto: fix zuc test vector IV format
  test/crypto: fix snow3g test vector IV format

 app/test/test_cryptodev_snow3g_test_vectors.h | 142 +++++++++---------
 app/test/test_cryptodev_zuc_test_vectors.h    |  54 +++----
 2 files changed, 98 insertions(+), 98 deletions(-)

Comments

De Lara Guarch, Pablo June 24, 2022, 7:36 a.m. UTC | #1 
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Thursday, June 23, 2022 4:43 PM
> Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; ktejasree@marvell.com;
> gakhil@marvell.com; Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH 0/2] fix wireless algorithm IVs
> 
> Some of the ZUC and Snow3G test vectors did not follow the specification for
> the cipher and authentication IVs.
> 
> These are now updated to follow the spec documents:
> ZUC 128 spec: https://www.gsma.com/security/wp-
> content/uploads/2019/05/EEA3_EIA3_specification_v1_8.pdf
> Snow3G spec: https://www.gsma.com/aboutus/wp-
> content/uploads/2014/12/uea2uia2d1v21.pdf
> 
> Ciara Power (2):
>   test/crypto: fix zuc test vector IV format
>   test/crypto: fix snow3g test vector IV format
> 
>  app/test/test_cryptodev_snow3g_test_vectors.h | 142 +++++++++---------
>  app/test/test_cryptodev_zuc_test_vectors.h    |  54 +++----
>  2 files changed, 98 insertions(+), 98 deletions(-)
> 
> --
> 2.25.1

CC'ing maintainers of the PMDs that support these algorithms, to verify they work for them.

Apart from that:
Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Akhil Goyal June 28, 2022, 9:04 a.m. UTC | #2 
> Some of the ZUC and Snow3G test vectors did not follow
> the specification for the cipher and authentication IVs.
> 
> Ciara Power (2):
>   test/crypto: fix zuc test vector IV format
>   test/crypto: fix snow3g test vector IV format
> 
>  app/test/test_cryptodev_snow3g_test_vectors.h | 142 +++++++++---------
>  app/test/test_cryptodev_zuc_test_vectors.h    |  54 +++----
>  2 files changed, 98 insertions(+), 98 deletions(-)
> 
Series applied to dpdk-next-crypto

Thanks.