mbox series

[v2,0/2] DLB2: cq_weight fixes

Message ID 20220706214628.2375117-1-timothy.mcdaniel@intel.com (mailing list archive)
Headers
Series DLB2: cq_weight fixes |

Message

Timothy McDaniel July 6, 2022, 9:46 p.m. UTC 
  This patch series contains the following:
- fix coverity issue 379234
- improve error reporting for cq_weight feature

Changes since V1
- fixed a repeated word in the commit message of patch 1

Timothy McDaniel (2):
  event/dlb2: fix cq_weight array overflow
  event/dlb2: improve cq_weight error messages

 drivers/event/dlb2/dlb2.c                  | 8 ++++----
 drivers/event/dlb2/dlb2_priv.h             | 2 +-
 drivers/event/dlb2/pf/base/dlb2_resource.c | 3 +++
 3 files changed, 8 insertions(+), 5 deletions(-)

Comments

Thomas Monjalon July 8, 2022, 2:26 p.m. UTC | #1 
06/07/2022 23:46, Timothy McDaniel:
> This patch series contains the following:
> - fix coverity issue 379234
> - improve error reporting for cq_weight feature
> 
> Changes since V1
> - fixed a repeated word in the commit message of patch 1
> 
> Timothy McDaniel (2):
>   event/dlb2: fix cq_weight array overflow
>   event/dlb2: improve cq_weight error messages

Should we merge those patches in 22.07-rc4? No risk?
Timothy McDaniel July 8, 2022, 3:02 p.m. UTC | #2 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, July 8, 2022 9:26 AM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; jerinjacobk@gmail.com;
> stable@dpdk.org
> Subject: Re: [PATCH v2 0/2] DLB2: cq_weight fixes
> 
> 06/07/2022 23:46, Timothy McDaniel:
> > This patch series contains the following:
> > - fix coverity issue 379234
> > - improve error reporting for cq_weight feature
> >
> > Changes since V1
> > - fixed a repeated word in the commit message of patch 1
> >
> > Timothy McDaniel (2):
> >   event/dlb2: fix cq_weight array overflow
> >   event/dlb2: improve cq_weight error messages
> 
> Should we merge those patches in 22.07-rc4? No risk?

I see no risk in merging these changes. I retested with them, and one fixes a coverity issue.
Thomas Monjalon July 11, 2022, 8:30 p.m. UTC | #3 
08/07/2022 17:02, McDaniel, Timothy:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 06/07/2022 23:46, Timothy McDaniel:
> > > This patch series contains the following:
> > > - fix coverity issue 379234
> > > - improve error reporting for cq_weight feature
> > >
> > > Changes since V1
> > > - fixed a repeated word in the commit message of patch 1
> > >
> > > Timothy McDaniel (2):
> > >   event/dlb2: fix cq_weight array overflow
> > >   event/dlb2: improve cq_weight error messages
> > 
> > Should we merge those patches in 22.07-rc4? No risk?
> 
> I see no risk in merging these changes. I retested with them, and one fixes a coverity issue.

Applied, thanks.
Timothy McDaniel July 11, 2022, 8:33 p.m. UTC | #4 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, July 11, 2022 3:31 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: stable@dpdk.org; dev@dpdk.org; jerinj@marvell.com;
> jerinjacobk@gmail.com; stable@dpdk.org
> Subject: Re: [PATCH v2 0/2] DLB2: cq_weight fixes
> 
> 08/07/2022 17:02, McDaniel, Timothy:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 06/07/2022 23:46, Timothy McDaniel:
> > > > This patch series contains the following:
> > > > - fix coverity issue 379234
> > > > - improve error reporting for cq_weight feature
> > > >
> > > > Changes since V1
> > > > - fixed a repeated word in the commit message of patch 1
> > > >
> > > > Timothy McDaniel (2):
> > > >   event/dlb2: fix cq_weight array overflow
> > > >   event/dlb2: improve cq_weight error messages
> > >
> > > Should we merge those patches in 22.07-rc4? No risk?
> >
> > I see no risk in merging these changes. I retested with them, and one fixes a
> coverity issue.
> 
> Applied, thanks.
> 

Thank you, Thomas!

--Tim