From patchwork Wed Nov 9 09:54:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 119610 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AB2EA00C4; Wed, 9 Nov 2022 10:55:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DC10400EF; Wed, 9 Nov 2022 10:55:41 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2047.outbound.protection.outlook.com [40.107.93.47]) by mails.dpdk.org (Postfix) with ESMTP id 3C489400D7 for ; Wed, 9 Nov 2022 10:55:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BiaFsYZouwHCzcMP0qDlaa3wfkXtDZTL8RjyFnoqfw/wIbJzLjQHYv8zCVpvNhW3d2agbIJF54TDYDoHPItTZ1eyEUP75RpkbDvTym6WJbhxvakhnCkUFO37YEHlpLpoO2Fkb8bag6D30uhbp0AIV+hTPV1lkc0ZjBVR3BGf1Q1hiaQXOrBXDrSOwP7jAqmMPmDR3VLf0buONeawDcMnhfPs3nhfGizRg7aQxc2Ivgum8NR7azuG55hjyV2I8AGZ0VeHfluHCQkmmeQbg+tswaar92LKSCXJX40Ah/NUmnzwB54q+zIc5XDOtHinzhcSzBS2P+MtN/Sljqx0Uia64Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fTVEPaGY5VswjjVXcL9VqetKSpTuG6bEHcKAq3ex42w=; b=m/Eeq1Sk+A5Y7bUjOJFw621LEQ56k8aJ8gZ5XZMGQco8ObP9uMQbaDh+ZpxV4SlSTNoZsGXR3Pb8H73chlfQi4vkPJaX4KDqITRJan6bAY1CDny4uNW59A85L7keb5O73j222cPlXW7+Gz+bfSt8zSlG9ZaV6jd9i0joHIO8QlXbifvZWZHeJqLpGTFHzyDilfB6eCOPxmQ88wXRcVnnhqfbvm5G75Kbj28h48GV5lcDtEAQTuLbv4NgOyhN5mEeZpvvQzPiIs1NkCH6E2ENd2XueC0ubNcnY+aYGRZPEQMI/AMw1NTuK+iEnU1Pgu51QZrCFz6oYp6fWwYdoBPTaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fTVEPaGY5VswjjVXcL9VqetKSpTuG6bEHcKAq3ex42w=; b=OsGfCXe6pZKhpktoWp119sDHNbtlHngtWQm1AXKoB8gzm9OAli2sefTp8UYZbM1uLGY5/ZPYapzLgSR+aybqCEfcN7i5QOtb7QO36PYh9X+OdMHJJXiZTRd0oOoKmFsliO2Kx03cdOhuY0bCw4y3WNMSffaO3+ZRLy8uiZmBTy4MfmrUoq5wiV5xDgoUddhk7na68Lc0MGJoWS+2HRNBCHH89Hes8fmew/eFuv7yP312fPEW0y1TSwcDudWLesT1NXNOMzeoo1zQU8IKUKEntdvHTzDiusF8aQgEv65UUoCDMY3wzdiqUfFSn0RNNVuAfgTXHYEeM0SaHL3ZjSlOQg== Received: from DM6PR10CA0026.namprd10.prod.outlook.com (2603:10b6:5:60::39) by PH7PR12MB6882.namprd12.prod.outlook.com (2603:10b6:510:1b8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Wed, 9 Nov 2022 09:55:38 +0000 Received: from CY4PEPF0000B8EA.namprd05.prod.outlook.com (2603:10b6:5:60:cafe::14) by DM6PR10CA0026.outlook.office365.com (2603:10b6:5:60::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 09:55:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000B8EA.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Wed, 9 Nov 2022 09:55:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 9 Nov 2022 01:55:21 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 9 Nov 2022 01:55:19 -0800 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko , Alex Vesker , Erez Shitrit CC: , Raslan Darawsheh Subject: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables Date: Wed, 9 Nov 2022 09:54:29 +0000 Message-ID: <20221109095431.668926-1-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EA:EE_|PH7PR12MB6882:EE_ X-MS-Office365-Filtering-Correlation-Id: a8873fd7-14fe-46ca-448e-08dac2388d82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 91yr5tNMf5m2WWHBgZaiLfeKFvSIWCMMR5aYwBVfA9zwaMrbu8+K5zRsTmFbqBR6Lm4mBD/5KKnU7HhPVMBm8dt36G41t1Pa7XkGmBBdYIlbNYItKI30UyB0aRDQsFDSYB9FlkY9v5uLMGHvAvMSeYFhT7GGwW4teZ4T/YC+uOM/SeMB4RBOMGySDE+ueiHfGVNgHRCfppRKn69FCblFGE/aKIND+fcTVYi8Z8NoYD4YLAjt4ew2/mDprs/DggAOxHkDLCoLVY60WSDfRKXMWJEPSypkag8A/PK33PN0VB03ZgraihnTNeTuQybXz9VuyP82hu1NCchzvTLEFN4Qvuo1DUmWBbWC88Zmu3qWoPqQirNFLLEn91mZ9rjWRaUVPyZC2u7CvRGhIRIEDmn5jt/eC6xbU9MYFl+PKvCJsQDMDXOf6GcQ91Vn2S9mrTZJt2UHTv8b5YjtD2ppCiKPr4ApGz6ErQBhT1+ULjYXbVG+cVThMuwhYhgGPHtQ5jH18qb9hXB9gRskch6+akBZL6s0WdhMaiY//ROgRnegyiW2BoFheXECN6hIB9ymF9Vh3kcKwY8bnqyMJUu63X3AxbdtLJTmaQULiDWRumZI4sMyXx0B800lolB8QtO8uS/ru+RdlpfnBNRDkeBonvhZlitOL+QMn7VITvSb3cWSEBM+JOwt7NF8vP75Ww0/1nrHI9Q5WXezZfpn/OxK0iPUyiKv5qBYM2euHptC6a3FROAwVkOO5m73938ZW0jTZ8MFPfztsV/5wr11aa1xOKm+tA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(5660300002)(36756003)(8936002)(8676002)(7636003)(83380400001)(316002)(41300700001)(4326008)(356005)(2906002)(6636002)(478600001)(70206006)(54906003)(110136005)(70586007)(36860700001)(336012)(40460700003)(426003)(1076003)(186003)(26005)(2616005)(16526019)(82740400003)(7696005)(6666004)(107886003)(86362001)(47076005)(40480700001)(55016003)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:55:37.2709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8873fd7-14fe-46ca-448e-08dac2388d82 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000B8EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6882 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Before these patches, if an application was configured to run with HW Steering and E-Switch enabled, on EAL cleanup the assertion in mlx5_dev_hw_global_release() was triggered - PD release was unsuccessful. Root cause of this issue was linked to an inability to destroy RTC objects used internally in mlx5, in HW Steering implementation. PMD was unable to destroy RTC objects, because of dangling references to those objects. More specifically, if all matchers connected to a single flow table were created, this flow table was still referencing RTC objects when theye were being destroyed. This patch series fixes that behavior. Matcher uninitilization is updated to remove the references to RTC objects from flow table object if the last matcher related to the flow table was destroyed. Erez Shitrit (2): net/mlx5/hws: fix order of destroying default tables net/mlx5/hws: fix disconnecting matcher drivers/net/mlx5/hws/mlx5dr_matcher.c | 35 +++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_table.c | 2 +- 2 files changed, 36 insertions(+), 1 deletion(-)