From patchwork Tue Nov 29 14:48:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Pelletier X-Patchwork-Id: 120275 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11620A00C3; Tue, 29 Nov 2022 15:50:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF35F40691; Tue, 29 Nov 2022 15:50:26 +0100 (CET) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by mails.dpdk.org (Postfix) with ESMTP id E090F4067E for ; Tue, 29 Nov 2022 15:50:24 +0100 (CET) Received: by mail-qt1-f170.google.com with SMTP id w4so9053394qts.0 for ; Tue, 29 Nov 2022 06:50:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=88YBCdlHKwcu3jD7b3NZidmpsqzeUZ2/k+JbLUOAeBA=; b=XKY9UYkCgzPYE2mALCNa0+NBPjnp9TLCPvsp5mz5MMccSJKHhDLwpnMtStBrQ4Bf7/ hRZtfoyoe6ellK1Ep2Nj0aURikCJf9D44z32cg0UggEQYuvzmnhxjvaAv+iTRmG3X768 54S3nRTOdIQBZZrlnGDbV9YqydDVU3/F4R6DDejZrUn+zI+EyOyuO7++5y5DC8A3TDs2 Hh/gjVEYrUK2PY8dc470MFhAOmnOKL2ZCpQu8dcjEZ0ZS7QwBT9/BCdCSENW514FrbZe djnNzQg/aD4oPhRq2RMTcn+cbH0niV2WZaKW7Y1753guJk2i7RiBX/PKKpQGEdgo+mtZ MO5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=88YBCdlHKwcu3jD7b3NZidmpsqzeUZ2/k+JbLUOAeBA=; b=a0FMO3wHXaQahC1/oQl8M0QjdMJi2AKRS79M98JFUcVg7UqpCAdVDuTMWwqV91vin6 sDj+cM3UQekF3EjpQCaT2rOTqDMuH5hlktn8y1bGtTGho+iiFgM4Xfyn7Tl59TwJfVKE X4BB0m9a0BHx+jXZ1QAGHv+ZJVVfgkLRtJ0TfBgi07jQHEpAzu7UxsfouyX/MjhwY6la QsPbup3Eh3O6d2MS6Ei6LZP4zTmw04kwQL14xs7anuwchCuEXnBg66PVCfJ8JP5PGJ+Z UNoHPblMh63aBlb1MxGsgHdyImnBbbDmQZUENYFBP1iEVnsrrmJhRgOP48y1wLUdGdoJ drTw== X-Gm-Message-State: ANoB5pmLqoD7nhOvWBuDbcsPYnUkE0nI8m4UiY24UTpgLsrMtaQVqcB6 dlDYJ+03/K9TbWO71AKxuJBvlv2JuXs= X-Google-Smtp-Source: AA0mqf4QiLy2oMN26g/hxeCxDM7BaCpOp1M5um7wWpHSs/AKI2XygwOa0xeoslq7TzHRBixSZXqRFw== X-Received: by 2002:ac8:5e83:0:b0:39c:c7ba:4af4 with SMTP id r3-20020ac85e83000000b0039cc7ba4af4mr38971724qtx.99.1669733424286; Tue, 29 Nov 2022 06:50:24 -0800 (PST) Received: from ubuntu.home (bras-base-hullpq2034w-grc-26-74-12-221-152.dsl.bell.ca. [74.12.221.152]) by smtp.gmail.com with ESMTPSA id y14-20020a05620a44ce00b006fb7c42e73asm11068836qkp.21.2022.11.29.06.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 06:50:23 -0800 (PST) From: Luc Pelletier To: grive@u256.net Cc: dev@dpdk.org, stephen@networkplumber.org, konstantin.ananyev@huawei.com, Luc Pelletier Subject: [PATCH v3 0/5] Failsafe bug fixes and improvements Date: Tue, 29 Nov 2022 09:48:28 -0500 Message-Id: <20221129144832.2750-1-lucp.at.work@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221110163410.12734-1-lucp.at.work@gmail.com> References: <20221110163410.12734-1-lucp.at.work@gmail.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Following the comments on v1 and v2 of the patch, I've tried to address all issues that were mentioned. I've also fixed other issues discovered during testing. I've split the changes into several commits. Please note that only the bug fix commits have been marked for back-porting to stable. Luc Pelletier (5): failsafe: fix segfault on hotplug event failsafe: use public rx/tx burst API failsafe: fix double release of port failsafe: use public APIs in fs_link_update failsafe: make sub-device remove flag thread-safe drivers/net/failsafe/failsafe_ether.c | 12 ++-- drivers/net/failsafe/failsafe_ops.c | 38 +++++----- drivers/net/failsafe/failsafe_private.h | 12 +--- drivers/net/failsafe/failsafe_rxtx.c | 94 ++----------------------- 4 files changed, 28 insertions(+), 128 deletions(-)