From patchwork Wed Dec 7 16:21:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Jarry X-Patchwork-Id: 120528 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FAADA00C3; Wed, 7 Dec 2022 17:21:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C732410D7; Wed, 7 Dec 2022 17:21:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1F95940156 for ; Wed, 7 Dec 2022 17:21:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670430107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ghsl2ij2ZGmpBSVms/MofuKSDA/ZHf5X0N9trl/AVGo=; b=A35B2t7gEl2djHI1a4UbFCeVcwrvYaX4H+ha5YTBFB+IiGsd/D+ilklTf+hScVUqL//UNa YbFRwICeBVjbA5LJm/NWs8tpfftCBIS7Ug/o1sCs6sYVAW2UQi2UZGv73cKs1iv7lUhCyu FlP+FeW3XaGJS+06PwTaeQgA839oxcU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-104-DmsOiqHZPmi-s9qaa2KbVg-1; Wed, 07 Dec 2022 11:21:46 -0500 X-MC-Unique: DmsOiqHZPmi-s9qaa2KbVg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32B833813F2C for ; Wed, 7 Dec 2022 16:21:46 +0000 (UTC) Received: from ringo.home (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 879CE2166B2B; Wed, 7 Dec 2022 16:21:45 +0000 (UTC) From: Robin Jarry To: dev@dpdk.org Cc: Robin Jarry Subject: [PATCH 0/4] lcore telemetry improvements Date: Wed, 7 Dec 2022 17:21:20 +0100 Message-Id: <20221207162124.769994-1-rjarry@redhat.com> In-Reply-To: <20221123102612.1688865-1-rjarry@redhat.com> References: <20221123102612.1688865-1-rjarry@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which leaves the cpu cycles accounting completely up to the application. For reference, I have implemented a draft patch in OvS to use rte_lcore_register_usage_cb() and report the already available busy cycles information. https://github.com/rjarry/ovs/commit/327db12c751be0375fcfed5e44b6065bcfb75c82 Changes since v3: - Changed nomenclature from CPU cycles to TSC cycles in the docstring of rte_lcore_usage_cb. Changes since v2: - Fixed typos in docstrings. - Used if (xxx != NULL) instead of if (xxx) test convention. - Guarded against an unlikely race if rte_lcore_dump() is called by a thread while another one calls rte_lcore_register_usage_cb(NULL). - s/utilization/usage/ - Fixed build on Windows. Changes since v1: - The cpuset field in telemetry is now a JSON list of CPU ids. - Applications must now report their raw CPU cycles counts. The busyness ratio and rate of change is left to external monitoring tools. - Renamed show lcores -> dump_lcores in testpmd. Robin Jarry (4): eal: add lcore info in telemetry eal: allow applications to report their cpu usage testpmd: add dump_lcores command testpmd: report lcore usage app/test-pmd/5tswap.c | 5 +- app/test-pmd/cmdline.c | 3 + app/test-pmd/csumonly.c | 6 +- app/test-pmd/flowgen.c | 2 +- app/test-pmd/icmpecho.c | 6 +- app/test-pmd/iofwd.c | 5 +- app/test-pmd/macfwd.c | 5 +- app/test-pmd/macswap.c | 5 +- app/test-pmd/noisy_vnf.c | 4 + app/test-pmd/rxonly.c | 5 +- app/test-pmd/shared_rxq_fwd.c | 5 +- app/test-pmd/testpmd.c | 39 ++++++++- app/test-pmd/testpmd.h | 14 +++- app/test-pmd/txonly.c | 7 +- lib/eal/common/eal_common_lcore.c | 131 +++++++++++++++++++++++++++++- lib/eal/include/rte_lcore.h | 29 +++++++ lib/eal/version.map | 1 + 17 files changed, 242 insertions(+), 30 deletions(-)