mbox series

[v3,00/10] codeql fixes for various subsystems

Message ID 20230120044140.95975-1-okaya@kernel.org (mailing list archive)
Headers
Series codeql fixes for various subsystems |

Message

Sinan Kaya Jan. 20, 2023, 4:41 a.m. UTC 
  From: Sinan Kaya <okaya@kernel.org>

Following up the codeql reported problems first submitted
by Stephen Hemminger here:

https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/

Posting a series of fixes about potential null pointer accesses.

Changes from v3:
- Dropped net/tap: check if name is null
- Moved the comment to the appropriate position in ethdev: check return result of rte_eth_dev_info_get

Changes from v2:
- Remove braces around single line statements
- use NULL comparisons


Sinan Kaya (10):
  ethdev: check return result of rte_eth_dev_info_get
  memzone: check result of rte_fbarray_get
  memzone: check result of malloc_elem_from_data
  malloc: malloc_elem_join_adjacent_free can return null
  malloc: check result of rte_mem_virt2memseg_list
  malloc: check result of rte_fbarray_get
  malloc: check result of rte_mem_virt2memseg
  malloc: check result of malloc_elem_free
  malloc: check result of elem_start_pt
  bus/vdev: check result of rte_vdev_device_name

 lib/eal/common/eal_common_memalloc.c |  5 ++++-
 lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
 lib/eal/common/malloc_elem.c         | 14 +++++++++++---
 lib/eal/common/malloc_heap.c         |  9 ++++++++-
 lib/ethdev/ethdev_vdev.h             |  2 ++
 lib/ethdev/rte_class_eth.c           |  4 +++-
 6 files changed, 37 insertions(+), 7 deletions(-)

Comments

Sinan Kaya Feb. 6, 2023, 4 p.m. UTC | #1 
On Thu, 2023-01-19 at 23:41 -0500, okaya@kernel.org wrote:
> From: Sinan Kaya <okaya@kernel.org>
> 
> Following up the codeql reported problems first submitted
> by Stephen Hemminger here:
> 
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
> 
> Posting a series of fixes about potential null pointer accesses.
> 
> Changes from v3:
> - Dropped net/tap: check if name is null
> - Moved the comment to the appropriate position in ethdev: check
> return result of rte_eth_dev_info_get
> 
> Changes from v2:
> - Remove braces around single line statements
> - use NULL comparisons
> 
> 
> Sinan Kaya (10):
>   ethdev: check return result of rte_eth_dev_info_get
>   memzone: check result of rte_fbarray_get
>   memzone: check result of malloc_elem_from_data
>   malloc: malloc_elem_join_adjacent_free can return null
>   malloc: check result of rte_mem_virt2memseg_list
>   malloc: check result of rte_fbarray_get
>   malloc: check result of rte_mem_virt2memseg
>   malloc: check result of malloc_elem_free
>   malloc: check result of elem_start_pt
>   bus/vdev: check result of rte_vdev_device_name
> 
>  lib/eal/common/eal_common_memalloc.c |  5 ++++-
>  lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
>  lib/eal/common/malloc_elem.c         | 14 +++++++++++---
>  lib/eal/common/malloc_heap.c         |  9 ++++++++-
>  lib/ethdev/ethdev_vdev.h             |  2 ++
>  lib/ethdev/rte_class_eth.c           |  4 +++-
>  6 files changed, 37 insertions(+), 7 deletions(-)
> 

Anatoly, any feedback on the series? You seem to be a maintainer for
2-9 patches.
Stephen Hemminger July 6, 2023, 10:43 p.m. UTC | #2 
On Thu, 19 Jan 2023 23:41:30 -0500
okaya@kernel.org wrote:

> From: Sinan Kaya <okaya@kernel.org>
> 
> Following up the codeql reported problems first submitted
> by Stephen Hemminger here:
> 
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
> 
> Posting a series of fixes about potential null pointer accesses.
> 
> Changes from v3:
> - Dropped net/tap: check if name is null
> - Moved the comment to the appropriate position in ethdev: check return result of rte_eth_dev_info_get
> 
> Changes from v2:
> - Remove braces around single line statements
> - use NULL comparisons
> 
> 
> Sinan Kaya (10):
>   ethdev: check return result of rte_eth_dev_info_get
>   memzone: check result of rte_fbarray_get
>   memzone: check result of malloc_elem_from_data
>   malloc: malloc_elem_join_adjacent_free can return null
>   malloc: check result of rte_mem_virt2memseg_list
>   malloc: check result of rte_fbarray_get
>   malloc: check result of rte_mem_virt2memseg
>   malloc: check result of malloc_elem_free
>   malloc: check result of elem_start_pt
>   bus/vdev: check result of rte_vdev_device_name
> 
>  lib/eal/common/eal_common_memalloc.c |  5 ++++-
>  lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
>  lib/eal/common/malloc_elem.c         | 14 +++++++++++---
>  lib/eal/common/malloc_heap.c         |  9 ++++++++-
>  lib/ethdev/ethdev_vdev.h             |  2 ++
>  lib/ethdev/rte_class_eth.c           |  4 +++-
>  6 files changed, 37 insertions(+), 7 deletions(-)

The patches are fine, only warning was from the requirement that all
submitters be in .mailmap now.  Do you mind if I rebase these, add a mailmap
and combine the like ones together?

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Sinan Kaya July 10, 2023, 3:18 p.m. UTC | #3 
On Thu, 2023-07-06 at 15:43 -0700, Stephen Hemminger wrote:
> >   lib/eal/common/eal_common_memalloc.c |  5 ++++-
> >   lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
> >   lib/eal/common/malloc_elem.c         | 14 +++++++++++---
> >   lib/eal/common/malloc_heap.c         |  9 ++++++++-
> >   lib/ethdev/ethdev_vdev.h             |  2 ++
> >   lib/ethdev/rte_class_eth.c           |  4 +++-
> >   6 files changed, 37 insertions(+), 7 deletions(-)
> 
> 
> The patches are fine, only warning was from the requirement that all
> 
> submitters be in .mailmap now.  Do you mind if I rebase these, add a
> mailmap
> 
> and combine the like ones together?
> 

Please go ahead.

> 
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>