[v6,00/19] net/idpf: introduce idpf common modle

  From: Beilei Xing <beilei.xing@intel.com>

Refactor idpf pmd by introducing idpf common module, which will be also
consumed by a new PMD - CPFL (Control Plane Function Library) PMD.

v2 changes:
 - Refine irq map/unmap functions.
 - Fix cross compile issue.
v3 changes:
 - Embed vport_info field into the vport structure.
 - Refine APIs' name and order in version.map.
 - Refine commit log.
v4 changes:
 - Refine commit log.
v5 changes:
 - Refine version.map.
 - Fix typo.
 - Return error log.
v6 changes:
 - Refine API name in common module.

Beilei Xing (19):
  common/idpf: add adapter structure
  common/idpf: add vport structure
  common/idpf: add virtual channel functions
  common/idpf: introduce adapter init and deinit
  common/idpf: add vport init/deinit
  common/idpf: add config RSS
  common/idpf: add irq map/unmap
  common/idpf: support get packet type
  common/idpf: add vport info initialization
  common/idpf: add vector flags in vport
  common/idpf: add rxq and txq struct
  common/idpf: add help functions for queue setup and release
  common/idpf: add Rx and Tx data path
  common/idpf: add vec queue setup
  common/idpf: add avx512 for single queue model
  common/idpf: refine API name for vport functions
  common/idpf: refine API name for queue config module
  common/idpf: refine API name for data path module
  common/idpf: refine API name for virtual channel functions

 drivers/common/idpf/base/idpf_controlq_api.h  |    6 -
 drivers/common/idpf/base/meson.build          |    2 +-
 drivers/common/idpf/idpf_common_device.c      |  655 +++++
 drivers/common/idpf/idpf_common_device.h      |  195 ++
 drivers/common/idpf/idpf_common_logs.h        |   47 +
 drivers/common/idpf/idpf_common_rxtx.c        | 1458 ++++++++++++
 drivers/common/idpf/idpf_common_rxtx.h        |  278 +++
 .../idpf/idpf_common_rxtx_avx512.c}           |   24 +-
 .../idpf/idpf_common_virtchnl.c}              |  945 ++------
 drivers/common/idpf/idpf_common_virtchnl.h    |   52 +
 drivers/common/idpf/meson.build               |   38 +
 drivers/common/idpf/version.map               |   61 +-
 drivers/net/idpf/idpf_ethdev.c                |  552 +----
 drivers/net/idpf/idpf_ethdev.h                |  194 +-
 drivers/net/idpf/idpf_logs.h                  |   24 -
 drivers/net/idpf/idpf_rxtx.c                  | 2107 +++--------------
 drivers/net/idpf/idpf_rxtx.h                  |  253 +-
 drivers/net/idpf/meson.build                  |   18 -
 18 files changed, 3442 insertions(+), 3467 deletions(-)
 create mode 100644 drivers/common/idpf/idpf_common_device.c
 create mode 100644 drivers/common/idpf/idpf_common_device.h
 create mode 100644 drivers/common/idpf/idpf_common_logs.h
 create mode 100644 drivers/common/idpf/idpf_common_rxtx.c
 create mode 100644 drivers/common/idpf/idpf_common_rxtx.h
 rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c => common/idpf/idpf_common_rxtx_avx512.c} (97%)
 rename drivers/{net/idpf/idpf_vchnl.c => common/idpf/idpf_common_virtchnl.c} (52%)
 create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h
  

> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, February 3, 2023 5:43 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle
> 
> From: Beilei Xing <beilei.xing@intel.com>
> 
> Refactor idpf pmd by introducing idpf common module, which will be also
> consumed by a new PMD - CPFL (Control Plane Function Library) PMD.
> 
> v2 changes:
>  - Refine irq map/unmap functions.
>  - Fix cross compile issue.
> v3 changes:
>  - Embed vport_info field into the vport structure.
>  - Refine APIs' name and order in version.map.
>  - Refine commit log.
> v4 changes:
>  - Refine commit log.
> v5 changes:
>  - Refine version.map.
>  - Fix typo.
>  - Return error log.
> v6 changes:
>  - Refine API name in common module.
> 
> Beilei Xing (19):
>   common/idpf: add adapter structure
>   common/idpf: add vport structure
>   common/idpf: add virtual channel functions
>   common/idpf: introduce adapter init and deinit
>   common/idpf: add vport init/deinit
>   common/idpf: add config RSS
>   common/idpf: add irq map/unmap
>   common/idpf: support get packet type
>   common/idpf: add vport info initialization
>   common/idpf: add vector flags in vport
>   common/idpf: add rxq and txq struct
>   common/idpf: add help functions for queue setup and release
>   common/idpf: add Rx and Tx data path
>   common/idpf: add vec queue setup
>   common/idpf: add avx512 for single queue model
>   common/idpf: refine API name for vport functions
>   common/idpf: refine API name for queue config module
>   common/idpf: refine API name for data path module
>   common/idpf: refine API name for virtual channel functions
> 
>  drivers/common/idpf/base/idpf_controlq_api.h  |    6 -
>  drivers/common/idpf/base/meson.build          |    2 +-
>  drivers/common/idpf/idpf_common_device.c      |  655 +++++
>  drivers/common/idpf/idpf_common_device.h      |  195 ++
>  drivers/common/idpf/idpf_common_logs.h        |   47 +
>  drivers/common/idpf/idpf_common_rxtx.c        | 1458 ++++++++++++
>  drivers/common/idpf/idpf_common_rxtx.h        |  278 +++
>  .../idpf/idpf_common_rxtx_avx512.c}           |   24 +-
>  .../idpf/idpf_common_virtchnl.c}              |  945 ++------
>  drivers/common/idpf/idpf_common_virtchnl.h    |   52 +
>  drivers/common/idpf/meson.build               |   38 +
>  drivers/common/idpf/version.map               |   61 +-
>  drivers/net/idpf/idpf_ethdev.c                |  552 +----
>  drivers/net/idpf/idpf_ethdev.h                |  194 +-
>  drivers/net/idpf/idpf_logs.h                  |   24 -
>  drivers/net/idpf/idpf_rxtx.c                  | 2107 +++--------------
>  drivers/net/idpf/idpf_rxtx.h                  |  253 +-
>  drivers/net/idpf/meson.build                  |   18 -
>  18 files changed, 3442 insertions(+), 3467 deletions(-)  create mode 100644
> drivers/common/idpf/idpf_common_device.c
>  create mode 100644 drivers/common/idpf/idpf_common_device.h
>  create mode 100644 drivers/common/idpf/idpf_common_logs.h
>  create mode 100644 drivers/common/idpf/idpf_common_rxtx.c
>  create mode 100644 drivers/common/idpf/idpf_common_rxtx.h
>  rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c =>
> common/idpf/idpf_common_rxtx_avx512.c} (97%)  rename
> drivers/{net/idpf/idpf_vchnl.c => common/idpf/idpf_common_virtchnl.c}
> (52%)  create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h
> 
> --
> 2.26.2	

Overall looks good to me, just couple thing need to fix

1. fix copy right date to 2023
2. fix some meson build , you can use devtools/check-meson.py to check the warning.
  

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, February 6, 2023 10:59 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle
> 
> 
> 
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Friday, February 3, 2023 5:43 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>
> > Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle
> >
> > From: Beilei Xing <beilei.xing@intel.com>
> >
> > Refactor idpf pmd by introducing idpf common module, which will be
> > also consumed by a new PMD - CPFL (Control Plane Function Library) PMD.
> >
> > v2 changes:
> >  - Refine irq map/unmap functions.
> >  - Fix cross compile issue.
> > v3 changes:
> >  - Embed vport_info field into the vport structure.
> >  - Refine APIs' name and order in version.map.
> >  - Refine commit log.
> > v4 changes:
> >  - Refine commit log.
> > v5 changes:
> >  - Refine version.map.
> >  - Fix typo.
> >  - Return error log.
> > v6 changes:
> >  - Refine API name in common module.
> >
> > Beilei Xing (19):
> >   common/idpf: add adapter structure
> >   common/idpf: add vport structure
> >   common/idpf: add virtual channel functions
> >   common/idpf: introduce adapter init and deinit
> >   common/idpf: add vport init/deinit
> >   common/idpf: add config RSS
> >   common/idpf: add irq map/unmap
> >   common/idpf: support get packet type
> >   common/idpf: add vport info initialization
> >   common/idpf: add vector flags in vport
> >   common/idpf: add rxq and txq struct
> >   common/idpf: add help functions for queue setup and release
> >   common/idpf: add Rx and Tx data path
> >   common/idpf: add vec queue setup
> >   common/idpf: add avx512 for single queue model
> >   common/idpf: refine API name for vport functions
> >   common/idpf: refine API name for queue config module
> >   common/idpf: refine API name for data path module
> >   common/idpf: refine API name for virtual channel functions
> >
> >  drivers/common/idpf/base/idpf_controlq_api.h  |    6 -
> >  drivers/common/idpf/base/meson.build          |    2 +-
> >  drivers/common/idpf/idpf_common_device.c      |  655 +++++
> >  drivers/common/idpf/idpf_common_device.h      |  195 ++
> >  drivers/common/idpf/idpf_common_logs.h        |   47 +
> >  drivers/common/idpf/idpf_common_rxtx.c        | 1458 ++++++++++++
> >  drivers/common/idpf/idpf_common_rxtx.h        |  278 +++
> >  .../idpf/idpf_common_rxtx_avx512.c}           |   24 +-
> >  .../idpf/idpf_common_virtchnl.c}              |  945 ++------
> >  drivers/common/idpf/idpf_common_virtchnl.h    |   52 +
> >  drivers/common/idpf/meson.build               |   38 +
> >  drivers/common/idpf/version.map               |   61 +-
> >  drivers/net/idpf/idpf_ethdev.c                |  552 +----
> >  drivers/net/idpf/idpf_ethdev.h                |  194 +-
> >  drivers/net/idpf/idpf_logs.h                  |   24 -
> >  drivers/net/idpf/idpf_rxtx.c                  | 2107 +++--------------
> >  drivers/net/idpf/idpf_rxtx.h                  |  253 +-
> >  drivers/net/idpf/meson.build                  |   18 -
> >  18 files changed, 3442 insertions(+), 3467 deletions(-)  create mode
> > 100644 drivers/common/idpf/idpf_common_device.c
> >  create mode 100644 drivers/common/idpf/idpf_common_device.h
> >  create mode 100644 drivers/common/idpf/idpf_common_logs.h
> >  create mode 100644 drivers/common/idpf/idpf_common_rxtx.c
> >  create mode 100644 drivers/common/idpf/idpf_common_rxtx.h
> >  rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c =>
> > common/idpf/idpf_common_rxtx_avx512.c} (97%)  rename
> > drivers/{net/idpf/idpf_vchnl.c => common/idpf/idpf_common_virtchnl.c}
> > (52%)  create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h
> >
> > --
> > 2.26.2
> 
> Overall looks good to me, just couple thing need to fix
> 
> 1. fix copy right date to 2023
> 2. fix some meson build , you can use devtools/check-meson.py to check the
> warning.

Yes, updated in v7.

> 
> 
>