mbox series

[v2,0/5] test/crypto: add ZUC256 chained tests

Message ID 20230303093821.2367309-1-ciara.power@intel.com (mailing list archive)
Headers
Series test/crypto: add ZUC256 chained tests |

Message

Power, Ciara March 3, 2023, 9:38 a.m. UTC
  This patchset adds chained testcases for each ZUC256 digest size:
 - cipher-auth
 - auth-cipher
 - auth-cipher-verify

 To add these tests, some improvements were made to the existing code,
 allowing for the user to easily differentiate ZUC256 and ZUC128 tests.

 Some fixes are also included, that were highlighted when these new tests
 were added. 

 v2: changed bit lengths to byte length representation.

Ciara Power (5):
  test/crypto: improve readability of ZUC256 tests
  test/crypto: fix ZUC digest length in comparison
  test/crypto: fix auth op parameter for ZUC256 tests
  test/crypto: fix capability check for ZUC cipher auth
  test/crypto: add chained ZUC256 testcases

 app/test/test_cryptodev.c                  | 280 +++++---
 app/test/test_cryptodev_zuc_test_vectors.h | 714 +++++++++++++++++++++
 2 files changed, 913 insertions(+), 81 deletions(-)
  

Comments

Tejasree Kondoj March 3, 2023, 4:37 p.m. UTC | #1
Acked-by: Tejasree Kondoj <ktejasree@marvell.com>

> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Friday, March 3, 2023 3:08 PM
> Cc: dev@dpdk.org; kai.ji@intel.com; pablo.de.lara.guarch@intel.com; Ciara
> Power <ciara.power@intel.com>
> Subject: [EXT] [PATCH v2 0/5] test/crypto: add ZUC256 chained tests
> 
> External Email
> 
> ----------------------------------------------------------------------
> This patchset adds chained testcases for each ZUC256 digest size:
>  - cipher-auth
>  - auth-cipher
>  - auth-cipher-verify
> 
>  To add these tests, some improvements were made to the existing code,
> allowing for the user to easily differentiate ZUC256 and ZUC128 tests.
> 
>  Some fixes are also included, that were highlighted when these new tests
> were added.
> 
>  v2: changed bit lengths to byte length representation.
> 
> Ciara Power (5):
>   test/crypto: improve readability of ZUC256 tests
>   test/crypto: fix ZUC digest length in comparison
>   test/crypto: fix auth op parameter for ZUC256 tests
>   test/crypto: fix capability check for ZUC cipher auth
>   test/crypto: add chained ZUC256 testcases
> 
>  app/test/test_cryptodev.c                  | 280 +++++---
>  app/test/test_cryptodev_zuc_test_vectors.h | 714 +++++++++++++++++++++
>  2 files changed, 913 insertions(+), 81 deletions(-)
> 
> --
> 2.25.1
  
De Lara Guarch, Pablo March 6, 2023, 9:32 a.m. UTC | #2
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Friday, March 3, 2023 10:38 AM
> Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH v2 0/5] test/crypto: add ZUC256 chained tests
> 
> This patchset adds chained testcases for each ZUC256 digest size:
>  - cipher-auth
>  - auth-cipher
>  - auth-cipher-verify
> 
>  To add these tests, some improvements were made to the existing code,
> allowing for the user to easily differentiate ZUC256 and ZUC128 tests.
> 
>  Some fixes are also included, that were highlighted when these new tests
> were added.
> 
>  v2: changed bit lengths to byte length representation.
> 
> Ciara Power (5):
>   test/crypto: improve readability of ZUC256 tests
>   test/crypto: fix ZUC digest length in comparison
>   test/crypto: fix auth op parameter for ZUC256 tests
>   test/crypto: fix capability check for ZUC cipher auth
>   test/crypto: add chained ZUC256 testcases
> 
>  app/test/test_cryptodev.c                  | 280 +++++---
>  app/test/test_cryptodev_zuc_test_vectors.h | 714 +++++++++++++++++++++
>  2 files changed, 913 insertions(+), 81 deletions(-)
> 
> --
> 2.25.1

Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
  
Akhil Goyal March 14, 2023, 10:27 a.m. UTC | #3
> > Subject: [PATCH v2 0/5] test/crypto: add ZUC256 chained tests
> >
> > This patchset adds chained testcases for each ZUC256 digest size:
> >  - cipher-auth
> >  - auth-cipher
> >  - auth-cipher-verify
> >
> >  To add these tests, some improvements were made to the existing code,
> > allowing for the user to easily differentiate ZUC256 and ZUC128 tests.
> >
> >  Some fixes are also included, that were highlighted when these new tests
> > were added.
> >
> >  v2: changed bit lengths to byte length representation.
> >
> > Ciara Power (5):
> >   test/crypto: improve readability of ZUC256 tests
> >   test/crypto: fix ZUC digest length in comparison
> >   test/crypto: fix auth op parameter for ZUC256 tests
> >   test/crypto: fix capability check for ZUC cipher auth
> >   test/crypto: add chained ZUC256 testcases
> >
> >  app/test/test_cryptodev.c                  | 280 +++++---
> >  app/test/test_cryptodev_zuc_test_vectors.h | 714 +++++++++++++++++++++
> >  2 files changed, 913 insertions(+), 81 deletions(-)
> >
> > --
> > 2.25.1
> 
> Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto

Thanks.