mbox series

[00/10] support telemetry query ethdev info

Message ID 20230530090510.56812-1-haijie1@huawei.com (mailing list archive)
Headers
Series support telemetry query ethdev info |

Message

Jie Hai May 30, 2023, 9:05 a.m. UTC 
  This patchset supports querying information about ethdev.
The information includes MAC addresses, RxTx offload, flow ctrl,
Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.


Dengdui Huang (1):
  ethdev: support telemetry query MAC addresses

Jie Hai (9):
  ethdev: support RxTx offload display
  ethdev: support telemetry query flow ctrl info
  ethdev: support telemetry query Rx queue info
  ethdev: support telemetry query Tx queue info
  ethdev: add firmware version in telemetry info command
  ethdev: support telemetry query DCB info
  ethdev: support telemetry query RSS info
  ethdev: support telemetry query FEC info
  ethdev: support telemetry query VLAN info

 lib/ethdev/rte_ethdev.c | 775 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 765 insertions(+), 10 deletions(-)

Comments

Ferruh Yigit June 1, 2023, 12:05 p.m. UTC | #1 
On 5/30/2023 10:05 AM, Jie Hai wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> This patchset supports querying information about ethdev.
> The information includes MAC addresses, RxTx offload, flow ctrl,
> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
> 
> 
> Dengdui Huang (1):
>   ethdev: support telemetry query MAC addresses
> 
> Jie Hai (9):
>   ethdev: support RxTx offload display
>   ethdev: support telemetry query flow ctrl info
>   ethdev: support telemetry query Rx queue info
>   ethdev: support telemetry query Tx queue info
>   ethdev: add firmware version in telemetry info command
>   ethdev: support telemetry query DCB info
>   ethdev: support telemetry query RSS info
>   ethdev: support telemetry query FEC info
>   ethdev: support telemetry query VLAN info
> 

Hi Jie,

There are build errors, reported by CI, and %l usage related checkpatch
warnings, can you please fix them in next version?
Jie Hai June 1, 2023, 12:23 p.m. UTC | #2 
On 2023/6/1 20:05, Ferruh Yigit wrote:
> On 5/30/2023 10:05 AM, Jie Hai wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> This patchset supports querying information about ethdev.
>> The information includes MAC addresses, RxTx offload, flow ctrl,
>> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
>>
>>
>> Dengdui Huang (1):
>>    ethdev: support telemetry query MAC addresses
>>
>> Jie Hai (9):
>>    ethdev: support RxTx offload display
>>    ethdev: support telemetry query flow ctrl info
>>    ethdev: support telemetry query Rx queue info
>>    ethdev: support telemetry query Tx queue info
>>    ethdev: add firmware version in telemetry info command
>>    ethdev: support telemetry query DCB info
>>    ethdev: support telemetry query RSS info
>>    ethdev: support telemetry query FEC info
>>    ethdev: support telemetry query VLAN info
>>

> Hi Jie,
> 
> There are build errors, reported by CI, and %l usage related checkpatch
> warnings, can you please fix them in next version?
> 
> 
Hi Ferruh,

Thanks for your reply, I will fix them in V2.

Jie Hai.
Ferruh Yigit June 1, 2023, 2:36 p.m. UTC | #3 
On 5/30/2023 10:05 AM, Jie Hai wrote:
> This patchset supports querying information about ethdev.
> The information includes MAC addresses, RxTx offload, flow ctrl,
> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
> 
> 
> Dengdui Huang (1):
>   ethdev: support telemetry query MAC addresses
> 
> Jie Hai (9):
>   ethdev: support RxTx offload display
>   ethdev: support telemetry query flow ctrl info
>   ethdev: support telemetry query Rx queue info
>   ethdev: support telemetry query Tx queue info
>   ethdev: add firmware version in telemetry info command
>   ethdev: support telemetry query DCB info
>   ethdev: support telemetry query RSS info
>   ethdev: support telemetry query FEC info
>   ethdev: support telemetry query VLAN info
>

Hi Jie,

Overall it is good to add more telemetry support, but it is making
'rte_ethdev.c' bigger, specially naming of the static functions that
telemetry handlers use making file confusing.
Can you please create a specific file for telemetry functions?

First you can move the existing ones and later add your patches.

Also there is a common part that reads and verifies port_id, I think
that part can be extracted to a common function, I will comment on it in
one of the patches.

Thanks,
ferruh
Jie Hai June 5, 2023, 6:19 a.m. UTC | #4 
On 2023/6/1 22:36, Ferruh Yigit wrote:
> On 5/30/2023 10:05 AM, Jie Hai wrote:
>> This patchset supports querying information about ethdev.
>> The information includes MAC addresses, RxTx offload, flow ctrl,
>> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
>>
>>
>> Dengdui Huang (1):
>>    ethdev: support telemetry query MAC addresses
>>
>> Jie Hai (9):
>>    ethdev: support RxTx offload display
>>    ethdev: support telemetry query flow ctrl info
>>    ethdev: support telemetry query Rx queue info
>>    ethdev: support telemetry query Tx queue info
>>    ethdev: add firmware version in telemetry info command
>>    ethdev: support telemetry query DCB info
>>    ethdev: support telemetry query RSS info
>>    ethdev: support telemetry query FEC info
>>    ethdev: support telemetry query VLAN info
>>
> 
> Hi Jie,
> 
> Overall it is good to add more telemetry support, but it is making
> 'rte_ethdev.c' bigger, specially naming of the static functions that
> telemetry handlers use making file confusing.
> Can you please create a specific file for telemetry functions?
> 
> First you can move the existing ones and later add your patches.
> 
> Also there is a common part that reads and verifies port_id, I think
> that part can be extracted to a common function, I will comment on it in
> one of the patches.
> 
> Thanks,
> ferruh
> .
Hi ferruh,

Thanks for your review, I will fix them in the next version.

Thanks,
Jie Hai