From patchwork Wed May 31 22:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127809 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87BE142BF9; Thu, 1 Jun 2023 00:05:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1766140EF0; Thu, 1 Jun 2023 00:05:46 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 5C302406B3 for ; Thu, 1 Jun 2023 00:05:45 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b011cffe7fso809845ad.1 for ; Wed, 31 May 2023 15:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685570744; x=1688162744; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rXPpXgJmTUsRGmeyg53ESR6dboXVtHKWc+bVRtsualY=; b=duFO42XynlF8kiz/5pQogZMX1ia8Gm+yFrGNU4nSIMLWZ1VUcWSSsxa3NusWv4vsqh ssEC+ZUFCPZR7r/gzc48cOYrGtFLhCPIGhOwJpbgzxl7uR5GNXSRxugBcqBZcXaZkv78 T+WH56aWdneeji7VKTQ0paFpZ9TrNLe8oYXLqxxHeC0hQeUPuqVB9DPiqvq7IDDngvof iD0HPPaWoe9/pzn1icGu/LvZzS5hj3kBIZ2wgt1yV5DbRpwQnHyI0m1XHcT3BnxfGRpN cCjWFFKe1aS8n9dYZO/vPKL1OWaV0+UhExJWjnrdZfY/1fqpdmVqVvim1VxKXSf3norh Vspg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685570744; x=1688162744; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rXPpXgJmTUsRGmeyg53ESR6dboXVtHKWc+bVRtsualY=; b=bgScgwxM7lSazaNkGctAgq2pZv6V8TQ/vH+crStn+kC7MmJgc7OGilF7Z+0ZQs+hNW 8gOnfmTErLge1xGj8JTlyxgeEY/uCEEiulShg9jG375Yjr4j6l8Piqco3W/inMBAIMNw p0hLPW+V8KXkESSriXUR0ZFhXUW4qnYwc1cwmldimgyhO/Dt9J1lCtdj46WoNtqRUQcM Ak0xiaUmqlP49pEzrfCBz/oTNoBWQSa6qQfbaMaaSRsAvqJC2zXHkEm0xR0KyBfrv9T6 ztsyxIU16HthVkQZRKtf9nlFMA+C5El98lhfFh1NPIBFVTcxg85IHpI+2NdMwkiI+FfI 0rSQ== X-Gm-Message-State: AC+VfDwGkFtqqZs0uEpXbxbYcyNc2M0gP8LSmhEsXp7OH7nFuo8SouND WVa+kLfOJrmG6yBr+il2x38DGy5j2CFOJekA7SrG+w== X-Google-Smtp-Source: ACHHUZ5w4HWS0N4n8ow4XmjQlUwQ7+Dqj8xceB0ajrNfWr70gY1lVNw5/VtI1wRf7rUjG0dy3cZUnA== X-Received: by 2002:a17:903:11c6:b0:1ac:b363:83a6 with SMTP id q6-20020a17090311c600b001acb36383a6mr5079047plh.17.1685570744153; Wed, 31 May 2023 15:05:44 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g23-20020a1709029f9700b001b077301b15sm1888623plq.156.2023.05.31.15.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 15:05:43 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 0/2] cleanup use of rte_strlcpy Date: Wed, 31 May 2023 15:05:31 -0700 Message-Id: <20230531220533.29910-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In DPDK API's rte_strlcpy() is not intended to be used directly. It was introduced as a replacement for when operating system libraries were missing strlcpy(). Over time it appears several drivers and subsystems started using it directly, which is inefficient since the wrapper uses snprintf(). This series makes sure that the only usage of rte_strlcpy() is in rte_string_fns.h where it is needed. Perhaps checkpatch should warn about other uses? Stephen Hemminger (2): lib: replace rte_strlcpy() with strlcpy() drivers: don't use rte_strlcpy drivers/common/cnxk/roc_platform.h | 2 +- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 2 +- drivers/net/cnxk/cnxk_ethdev_ops.c | 4 +- drivers/net/mlx5/mlx5_testpmd.c | 2 +- lib/eal/common/eal_common_memzone.c | 2 +- lib/fib/rte_fib.c | 2 +- lib/fib/rte_fib6.c | 2 +- lib/hash/rte_thash.c | 4 +- lib/mempool/rte_mempool.c | 2 +- lib/mldev/mldev_utils.c | 40 +++++++++---------- lib/rib/rte_rib.c | 2 +- lib/rib/rte_rib6.c | 2 +- 12 files changed, 33 insertions(+), 33 deletions(-) Acked-by: Bruce Richardson Acked-by: Tyler Retzlaff