| Message ID | 20240326125554.138840-1-sivaprasad.tummala@amd.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A988743D51; Tue, 26 Mar 2024 13:56:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DB9B40265; Tue, 26 Mar 2024 13:56:25 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54]) by mails.dpdk.org (Postfix) with ESMTP id E130540261 for <dev@dpdk.org>; Tue, 26 Mar 2024 13:56:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kB+7s17VOM1cotyiNMSAutwQsNEcWC1IsFlRtJQnox7TmvIwRsfLbaDDc25+HwBkdFl7gJuT5mSETc+GtlkEVQOuJrKo1fp90PaddyW5r3ZD01ioIIEvYCO9/BsHD1p8nn3uJ5cGlFI6fKJqnwNNM6ukL63Ed9LEV/4V1ah4iiVqflPUaepzlMlbIrJFjangLbU6wlzr5domqool8QKZkRIneB0vQKdscrDsSLkCfOOeiLwNq9OFf1IouCChWtmDq8iOSLhUZTq7uU1xHYjbpHwvLLJE9gcLt/zIH9lShS6ytqtfspI/N4nk6BfVPJm5j4NIRKGHc/bHAeVOOWerIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DEszTUzEjiTK8laA3Nq+3ekInC5qA/kxDH6oedcQuMk=; b=oVTIvgkm4X2Ct5+HaSrfR09gosg4rKZFuleyeVrc2W45igmctrmjNdLAqZ5A//Gpjq1f604KoDLcKc2Hq1hpSqHJGoB8ZLzcyAoaCL2qKEzraR/TnO/BB/shmqUMX8kpNJJ0Bp3QZwzwQAnqflWJ74U0cpjT1ScR5CtuLL8o2GvYCvysgHr5WeIrv50Mq498oava852bX25PS87iqZdnCuYxwOvwZtUaRGNbi+rGSn0wVRjLgmHuQrVpVrwu0eKsGBfJjK8DpcD2BprprpVxKfjny/IrqlAVu86rbn52coKK+lwmQt2zTCtezbKyrnNA7NkCb05U8v0HVq5GLE999w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEszTUzEjiTK8laA3Nq+3ekInC5qA/kxDH6oedcQuMk=; b=JDGIxaPSvZkvbwHQCuXCGU+TAV7xaL1HsGO/v15QNatcDc0XCTQSgUS6cIMNwRrx1+mzEXKExLCDDcqbNoiE2ziD+qHZ0PdN/3VLCYGYOcSO+xLbiOcUxsi8ZjAyDi0QwywQhXkfzm+qrQUbBruGGOmTS0hvQWOhkcd8OVwUyi0= Received: from BN0PR08CA0003.namprd08.prod.outlook.com (2603:10b6:408:142::19) by PH7PR12MB6609.namprd12.prod.outlook.com (2603:10b6:510:213::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 12:56:19 +0000 Received: from BN1PEPF00004689.namprd05.prod.outlook.com (2603:10b6:408:142:cafe::90) by BN0PR08CA0003.outlook.office365.com (2603:10b6:408:142::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20 via Frontend Transport; Tue, 26 Mar 2024 12:56:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN1PEPF00004689.mail.protection.outlook.com (10.167.243.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Tue, 26 Mar 2024 12:56:18 +0000 Received: from ubuntu2004.linuxvmimages.local (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 26 Mar 2024 07:56:13 -0500 From: Sivaprasad Tummala <sivaprasad.tummala@amd.com> To: <david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>, <radu.nicolau@intel.com>, <gakhil@marvell.com>, <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>, <konstantin.ananyev@huawei.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com> CC: <dev@dpdk.org> Subject: [PATCH v7 00/14] fix lcore ID restriction Date: Tue, 26 Mar 2024 13:55:39 +0100 Message-ID: <20240326125554.138840-1-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240321184721.69040-1-sivaprasad.tummala@amd.com> References: <20240321184721.69040-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004689:EE_|PH7PR12MB6609:EE_ X-MS-Office365-Filtering-Correlation-Id: 733b59e9-d052-4551-4895-08dc4d942100 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RgSmlL1uHoMOef857mjS57TRYptLg4arB65HVl0OPJ2proIvi2DQI4nzrP5+m39lwVlHw0FQVdohWnVnT/NWiMfJ8K7EvQlw+A4YUFCVr54fe9MfjjtKc0iBHgdosg0z9eM6DsZz9gykR7rRlCAUdkEm2QCRrWJGfADQqxsW/XcvGfCv23mbi3ll9tbHfZ1xwKIekzN5KRQ2/E/caWkBMOiNLsLdbjYw+p1TciQLUoOJu8hoHdxEaVOHZV46gwKllGHDtA1PVMz0e3/wV342JD6B1N/z5d/gykyyx7vld52yFvl6QWXKGcErT72NAtFgNptXuZGYWUvPJpSKXZAvGDw9v/pEsWYskab+EuxtBxet8K8tAQHpaXepiEAXFVBUxHOBzbvqNXqbjBjoJuS65hmhbWiJfjmjyOMXNgyb/vWfPdwXLfs4At2Lqucvo7hxn66sk4flgr3CdY5plsBagb7rlxxRRKLRqIG5lMIoHPO8Hszl63XV3cHHj/CAtOB5oYjV5SfRir1048qNJjJz9dOisd0Zboj65RYgRFMx7Cu9OfOSqowCx4KiTY/TjnFVLRmI72U0no9oMq/Z0QA1uOCdIihKJafpsdm1y9CsEZg4zo+RuaPYi78ySS7my1DGgOp1A8/TMHH5ftFLgIlCW1RjkZytiyev/tq8O3tXBCboNTdy07fWyN8M3BNrmyxnwGyHrp/bJhhDSGy5AZ1bWNzGlCn82zDyPVrOcS0Au4W1nu4jzkSOUpU7NuFp7bcyPNTS7ZrznttsPmtVNfsM0w== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(82310400014)(36860700004)(7416005)(1800799015)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 12:56:18.3464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 733b59e9-d052-4551-4895-08dc4d942100 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004689.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6609 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
fix lcore ID restriction
|
|
Message
Sivaprasad Tummala
March 26, 2024, 12:55 p.m. UTC
With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In DPDK sample applications, the current config lcore options are hard limited to 255. The patchset fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the rx queue IDs are increased to support up to 65535. The port ID constraints were also fixed to support up to RTE_MAX_ETHPORTS. v7: - updated commit log with rx queue IDs - changed format specifier to %PRIu16 - removed patch unrelated changes v6: - split queue_id, lcore_id and port_id changes as separate patches. - updated git commit description on individual patches v5: - updated lcore_id type to uint32_t v4: - fixed build errors with queue_id type in ipsec-secgw v3: - updated queue_id type to uint16_t v2: - fixed typo with lcore_id type in l3fwd Sivaprasad Tummala (14): examples/l3fwd: fix queue ID restriction examples/l3fwd-power: fix queue ID restriction examples/l3fwd-graph: fix queue ID restriction examples/ipsec-secgw: fix queue ID restriction examples/l3fwd: fix lcore ID restriction examples/l3fwd-power: fix lcore ID restriction examples/l3fwd-graph: fix lcore ID restriction examples/ipsec-secgw: fix lcore ID restriction examples/qos_sched: fix lcore ID restriction examples/vm_power_manager: fix lcore ID restriction examples/l3fwd: fix port ID restriction examples/l3fwd-power: fix port ID restriction examples/l3fwd-graph: fix port ID restriction examples/ipsec-secgw: fix port ID restriction examples/ipsec-secgw/event_helper.h | 2 +- examples/ipsec-secgw/ipsec-secgw.c | 40 +++++++----- examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 6 +- examples/ipsec-secgw/ipsec_worker.c | 10 ++- examples/l3fwd-graph/main.c | 33 +++++----- examples/l3fwd-power/main.c | 65 ++++++++++--------- examples/l3fwd-power/main.h | 4 +- examples/l3fwd-power/perf_core.c | 19 ++++-- examples/l3fwd/l3fwd.h | 2 +- examples/l3fwd/l3fwd_acl.c | 4 +- examples/l3fwd/l3fwd_em.c | 4 +- examples/l3fwd/l3fwd_event.h | 2 +- examples/l3fwd/l3fwd_fib.c | 4 +- examples/l3fwd/l3fwd_lpm.c | 5 +- examples/l3fwd/main.c | 42 +++++++----- examples/qos_sched/args.c | 6 +- .../guest_cli/vm_power_cli_guest.c | 4 +- 18 files changed, 135 insertions(+), 119 deletions(-)
Comments
With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In DPDK sample applications, the current config lcore options are hard limited to 255. The patchset fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the rx queue IDs are increased to support up to 65535. The port ID constraints were also fixed to support up to RTE_MAX_ETHPORTS. v7: - updated commit log with rx queue IDs - changed format specifier to %PRIu16 - removed patch unrelated changes v6: - split queue_id, lcore_id and port_id changes as separate patches. - updated git commit description on individual patches v5: - updated lcore_id type to uint32_t v4: - fixed build errors with queue_id type in ipsec-secgw v3: - updated queue_id type to uint16_t v2: - fixed typo with lcore_id type in l3fwd Sivaprasad Tummala (14): examples/l3fwd: fix queue ID restriction examples/l3fwd-power: fix queue ID restriction examples/l3fwd-graph: fix queue ID restriction examples/ipsec-secgw: fix queue ID restriction examples/l3fwd: fix lcore ID restriction examples/l3fwd-power: fix lcore ID restriction examples/l3fwd-graph: fix lcore ID restriction examples/ipsec-secgw: fix lcore ID restriction examples/qos_sched: fix lcore ID restriction examples/vm_power_manager: fix lcore ID restriction examples/l3fwd: fix port ID restriction examples/l3fwd-power: fix port ID restriction examples/l3fwd-graph: fix port ID restriction examples/ipsec-secgw: fix port ID restriction examples/ipsec-secgw/event_helper.h | 2 +- examples/ipsec-secgw/ipsec-secgw.c | 40 +++++++----- examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h | 6 +- examples/ipsec-secgw/ipsec_worker.c | 10 ++- examples/l3fwd-graph/main.c | 33 +++++----- examples/l3fwd-power/main.c | 65 ++++++++++--------- examples/l3fwd-power/main.h | 4 +- examples/l3fwd-power/perf_core.c | 19 ++++-- examples/l3fwd/l3fwd.h | 2 +- examples/l3fwd/l3fwd_acl.c | 4 +- examples/l3fwd/l3fwd_em.c | 4 +- examples/l3fwd/l3fwd_event.h | 2 +- examples/l3fwd/l3fwd_fib.c | 4 +- examples/l3fwd/l3fwd_lpm.c | 5 +- examples/l3fwd/main.c | 42 +++++++----- examples/qos_sched/args.c | 6 +- .../guest_cli/vm_power_cli_guest.c | 4 +- 18 files changed, 135 insertions(+), 119 deletions(-)
On 3/26/2024 12:55 PM, Sivaprasad Tummala wrote: > With modern CPUs, it is possible to have higher > CPU count thus we can have higher RTE_MAX_LCORES. > In DPDK sample applications, the current config > lcore options are hard limited to 255. > > The patchset fixes these constraints by allowing > all lcore IDs up to RTE_MAX_LCORES. Also the rx > queue IDs are increased to support up to 65535. > The port ID constraints were also fixed to support > up to RTE_MAX_ETHPORTS. > > v7: > - updated commit log with rx queue IDs > - changed format specifier to %PRIu16 > - removed patch unrelated changes > > v6: > - split queue_id, lcore_id and port_id changes as > separate patches. > - updated git commit description on individual > patches > > v5: > - updated lcore_id type to uint32_t > > v4: > - fixed build errors with queue_id type > in ipsec-secgw > > v3: > - updated queue_id type to uint16_t > > v2: > - fixed typo with lcore_id type in l3fwd > > Sivaprasad Tummala (14): > examples/l3fwd: fix queue ID restriction > examples/l3fwd-power: fix queue ID restriction > examples/l3fwd-graph: fix queue ID restriction > examples/ipsec-secgw: fix queue ID restriction > examples/l3fwd: fix lcore ID restriction > examples/l3fwd-power: fix lcore ID restriction > examples/l3fwd-graph: fix lcore ID restriction > examples/ipsec-secgw: fix lcore ID restriction > examples/qos_sched: fix lcore ID restriction > examples/vm_power_manager: fix lcore ID restriction > examples/l3fwd: fix port ID restriction > examples/l3fwd-power: fix port ID restriction > examples/l3fwd-graph: fix port ID restriction > examples/ipsec-secgw: fix port ID restriction > Recheck-request: iol-unit-amd64-testing
On 4/25/2024 1:31 PM, Ferruh Yigit wrote: > On 3/26/2024 12:55 PM, Sivaprasad Tummala wrote: >> With modern CPUs, it is possible to have higher >> CPU count thus we can have higher RTE_MAX_LCORES. >> In DPDK sample applications, the current config >> lcore options are hard limited to 255. >> >> The patchset fixes these constraints by allowing >> all lcore IDs up to RTE_MAX_LCORES. Also the rx >> queue IDs are increased to support up to 65535. >> The port ID constraints were also fixed to support >> up to RTE_MAX_ETHPORTS. >> >> v7: >> - updated commit log with rx queue IDs >> - changed format specifier to %PRIu16 >> - removed patch unrelated changes >> >> v6: >> - split queue_id, lcore_id and port_id changes as >> separate patches. >> - updated git commit description on individual >> patches >> >> v5: >> - updated lcore_id type to uint32_t >> >> v4: >> - fixed build errors with queue_id type >> in ipsec-secgw >> >> v3: >> - updated queue_id type to uint16_t >> >> v2: >> - fixed typo with lcore_id type in l3fwd >> >> Sivaprasad Tummala (14): >> examples/l3fwd: fix queue ID restriction >> examples/l3fwd-power: fix queue ID restriction >> examples/l3fwd-graph: fix queue ID restriction >> examples/ipsec-secgw: fix queue ID restriction >> examples/l3fwd: fix lcore ID restriction >> examples/l3fwd-power: fix lcore ID restriction >> examples/l3fwd-graph: fix lcore ID restriction >> examples/ipsec-secgw: fix lcore ID restriction >> examples/qos_sched: fix lcore ID restriction >> examples/vm_power_manager: fix lcore ID restriction >> examples/l3fwd: fix port ID restriction >> examples/l3fwd-power: fix port ID restriction >> examples/l3fwd-graph: fix port ID restriction >> examples/ipsec-secgw: fix port ID restriction >> > > Recheck-request: iol-unit-amd64-testing > Recheck-request: iol-sample-apps-testing
On 3/26/2024 12:55 PM, Sivaprasad Tummala wrote: > With modern CPUs, it is possible to have higher > CPU count thus we can have higher RTE_MAX_LCORES. > In DPDK sample applications, the current config > lcore options are hard limited to 255. > > The patchset fixes these constraints by allowing > all lcore IDs up to RTE_MAX_LCORES. Also the rx > queue IDs are increased to support up to 65535. > The port ID constraints were also fixed to support > up to RTE_MAX_ETHPORTS. > > v7: > - updated commit log with rx queue IDs > - changed format specifier to %PRIu16 > - removed patch unrelated changes > > v6: > - split queue_id, lcore_id and port_id changes as > separate patches. > - updated git commit description on individual > patches > > v5: > - updated lcore_id type to uint32_t > > v4: > - fixed build errors with queue_id type > in ipsec-secgw > > v3: > - updated queue_id type to uint16_t > > v2: > - fixed typo with lcore_id type in l3fwd > > Sivaprasad Tummala (14): > examples/l3fwd: fix queue ID restriction > examples/l3fwd-power: fix queue ID restriction > examples/l3fwd-graph: fix queue ID restriction > examples/ipsec-secgw: fix queue ID restriction > examples/l3fwd: fix lcore ID restriction > examples/l3fwd-power: fix lcore ID restriction > examples/l3fwd-graph: fix lcore ID restriction > examples/ipsec-secgw: fix lcore ID restriction > examples/qos_sched: fix lcore ID restriction > examples/vm_power_manager: fix lcore ID restriction > examples/l3fwd: fix port ID restriction > examples/l3fwd-power: fix port ID restriction > examples/l3fwd-graph: fix port ID restriction > examples/ipsec-secgw: fix port ID restriction > Hi Thomas, I am aware we are very close to -rc3, but this patch series is from the previous release, can it be possible to include it to -rc3? Thanks, ferruh
23/07/2024 17:19, Ferruh Yigit: > > Sivaprasad Tummala (14): > > examples/l3fwd: fix queue ID restriction > > examples/l3fwd-power: fix queue ID restriction > > examples/l3fwd-graph: fix queue ID restriction > > examples/ipsec-secgw: fix queue ID restriction > > examples/l3fwd: fix lcore ID restriction > > examples/l3fwd-power: fix lcore ID restriction > > examples/l3fwd-graph: fix lcore ID restriction > > examples/ipsec-secgw: fix lcore ID restriction > > examples/qos_sched: fix lcore ID restriction > > examples/vm_power_manager: fix lcore ID restriction > > examples/l3fwd: fix port ID restriction > > examples/l3fwd-power: fix port ID restriction > > examples/l3fwd-graph: fix port ID restriction > > examples/ipsec-secgw: fix port ID restriction > > > > Hi Thomas, > > I am aware we are very close to -rc3, but this patch series is from the > previous release, can it be possible to include it to -rc3? Yes applied, thanks. Note: squashed in 3 patches.