[v9,00/10] Add JSON vector set support to fips validation

  Adds a very basic introduction to JSON vector sets in
the fips validation example application. This patch set
will only introduce the AES-GCM test using a JSON request
file because the other algorithms need more information
than what is given in the new JSON format.

v9:
* doc update.

v8:
* Fixed overlapped places for FIPS 140-2 test vectors.

v7:
* Fixed individual patches to build correctly.

v6:
* CI centos platform fix.

v5:
* AES_CBC support appended in series.

Brandon Lo (8):
  examples/fips_validation: add jansson dependency
  examples/fips_validation: add json info to header
  examples/fips_validation: add json parsing
  examples/fips_validation: allow json file as input
  examples/fips_validation: add json to gcm test
  examples/fips_validation: add json to hmac
  examples/fips_validation: implement json cmac test
  examples/fips_validation: add parsing for cmac

Gowrishankar Muthukrishnan (2):
  examples/fips_validation: add parsing for aes_cbc
  doc: add notes about acvp validation support

 doc/guides/sample_app_ug/fips_validation.rst  |  30 +-
 examples/fips_validation/fips_validation.c    | 117 ++++++-
 examples/fips_validation/fips_validation.h    |  64 +++-
 .../fips_validation/fips_validation_aes.c     | 223 +++++++++++++
 .../fips_validation/fips_validation_cmac.c    |  80 +++++
 .../fips_validation/fips_validation_gcm.c     | 152 ++++++++-
 .../fips_validation/fips_validation_hmac.c    |  93 ++++++
 examples/fips_validation/main.c               | 295 ++++++++++++++++--
 examples/fips_validation/meson.build          |   4 +
 9 files changed, 1015 insertions(+), 43 deletions(-)
  

Hey everyone, 

FIPS-140-2 tested and passed. 

Tested-by: Jakub Poczatek <Jakub.poczatek@intel.com>

-----Original Message-----
From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> 
Sent: Monday 30 May 2022 16:53
To: dev@dpdk.org
Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Dooley, Brian <brian.dooley@intel.com>; lylavoie@iol.unh.edu; Anoob Joseph <anoobj@marvell.com>; Archana Muniganti <marchana@marvell.com>; Jerin Jacob <jerinj@marvell.com>; Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Subject: [v9, 00/10] Add JSON vector set support to fips validation

Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format.

v9:
* doc update.

v8:
* Fixed overlapped places for FIPS 140-2 test vectors.

v7:
* Fixed individual patches to build correctly.

v6:
* CI centos platform fix.

v5:
* AES_CBC support appended in series.

Brandon Lo (8):
  examples/fips_validation: add jansson dependency
  examples/fips_validation: add json info to header
  examples/fips_validation: add json parsing
  examples/fips_validation: allow json file as input
  examples/fips_validation: add json to gcm test
  examples/fips_validation: add json to hmac
  examples/fips_validation: implement json cmac test
  examples/fips_validation: add parsing for cmac

Gowrishankar Muthukrishnan (2):
  examples/fips_validation: add parsing for aes_cbc
  doc: add notes about acvp validation support

 doc/guides/sample_app_ug/fips_validation.rst  |  30 +-
 examples/fips_validation/fips_validation.c    | 117 ++++++-
 examples/fips_validation/fips_validation.h    |  64 +++-
 .../fips_validation/fips_validation_aes.c     | 223 +++++++++++++
 .../fips_validation/fips_validation_cmac.c    |  80 +++++
 .../fips_validation/fips_validation_gcm.c     | 152 ++++++++-
 .../fips_validation/fips_validation_hmac.c    |  93 ++++++
 examples/fips_validation/main.c               | 295 ++++++++++++++++--
 examples/fips_validation/meson.build          |   4 +
 9 files changed, 1015 insertions(+), 43 deletions(-)

--
2.25.1
  

> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Monday, May 30, 2022 4:53 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Dooley, Brian
> <brian.dooley@intel.com>; lylavoie@iol.unh.edu; Anoob Joseph
> <anoobj@marvell.com>; Archana Muniganti <marchana@marvell.com>;
> Jerin Jacob <jerinj@marvell.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>
> Subject: [v9, 00/10] Add JSON vector set support to fips validation
> 
> Adds a very basic introduction to JSON vector sets in
> the fips validation example application. This patch set
> will only introduce the AES-GCM test using a JSON request
> file because the other algorithms need more information
> than what is given in the new JSON format.
> 
Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>
  

> > Subject: [v9, 00/10] Add JSON vector set support to fips validation
> >
> > Adds a very basic introduction to JSON vector sets in
> > the fips validation example application. This patch set
> > will only introduce the AES-GCM test using a JSON request
> > file because the other algorithms need more information
> > than what is given in the new JSON format.
> >
> Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Series Applied to dpdk-next-crypto

Thanks.
  

On Tue, May 31, 2022 at 5:23 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
> > > Subject: [v9, 00/10] Add JSON vector set support to fips validation
> > >
> > > Adds a very basic introduction to JSON vector sets in
> > > the fips validation example application. This patch set
> > > will only introduce the AES-GCM test using a JSON request
> > > file because the other algorithms need more information
> > > than what is given in the new JSON format.
> > >
> > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>
>
> Series Applied to dpdk-next-crypto

This series breaks compiling the fips example out of DPDK.

## Building fips_validation
/usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_init':
fips_validation.c:(.text+0x7ab): undefined reference to `json_loadf'
/usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_parse_one_json_vector_set':
fips_validation.c:(.text+0xc2e): undefined reference to `json_object_get'
/usr/bin/ld: fips_validation.c:(.text+0xc36): undefined reference to
`json_string_value'
/usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_parse_one_json_group':
fips_validation.c:(.text+0xd00): undefined reference to `json_object_get'
/usr/bin/ld: fips_validation.c:(.text+0xd14): undefined reference to
`json_integer_value'
etc...

I'll send a fix.
  

On Tue, Jun 7, 2022 at 11:48 AM David Marchand
<david.marchand@redhat.com> wrote:
> On Tue, May 31, 2022 at 5:23 PM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > > Subject: [v9, 00/10] Add JSON vector set support to fips validation
> > > >
> > > > Adds a very basic introduction to JSON vector sets in
> > > > the fips validation example application. This patch set
> > > > will only introduce the AES-GCM test using a JSON request
> > > > file because the other algorithms need more information
> > > > than what is given in the new JSON format.
> > > >
> > > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> >
> > Series Applied to dpdk-next-crypto
>
> This series breaks compiling the fips example out of DPDK.

Gowri, Fan, Akhil,

I disabled compilation checks for this example on my side.
Can you look into this?

Thanks.
  

Hi David,
Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/
I have acked this. @Akhil Goyal could this be merged ?.

Thanks,
Gowrishankar

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, June 13, 2022 5:29 PM
> To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>; Zhang, Roy
> Fan <roy.fan.zhang@intel.com>; Akhil Goyal <gakhil@marvell.com>
> Cc: dev@dpdk.org; Dooley, Brian <brian.dooley@intel.com>;
> lylavoie@iol.unh.edu; Anoob Joseph <anoobj@marvell.com>; Archana
> Muniganti <marchana@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: [EXT] Re: [v9, 00/10] Add JSON vector set support to fips validation
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Tue, Jun 7, 2022 at 11:48 AM David Marchand
> <david.marchand@redhat.com> wrote:
> > On Tue, May 31, 2022 at 5:23 PM Akhil Goyal <gakhil@marvell.com> wrote:
> > >
> > > > > Subject: [v9, 00/10] Add JSON vector set support to fips
> > > > > validation
> > > > >
> > > > > Adds a very basic introduction to JSON vector sets in the fips
> > > > > validation example application. This patch set will only
> > > > > introduce the AES-GCM test using a JSON request file because the
> > > > > other algorithms need more information than what is given in the
> > > > > new JSON format.
> > > > >
> > > > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > >
> > > Series Applied to dpdk-next-crypto
> >
> > This series breaks compiling the fips example out of DPDK.
> 
> Gowri, Fan, Akhil,
> 
> I disabled compilation checks for this example on my side.
> Can you look into this?
> 
> Thanks.
> 
> --
> David Marchand
  

Hello,

On Tue, Jun 21, 2022 at 9:29 AM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
> Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/
> I have acked this. @Akhil Goyal could this be merged ?.

Indeed, I had forgotten about it.
Akhil, please take it for rc2.
  

> Hello,
> 
> On Tue, Jun 21, 2022 at 9:29 AM Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com> wrote:
> > Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/
> > I have acked this. @Akhil Goyal could this be merged ?.
> 
> Indeed, I had forgotten about it.
> Akhil, please take it for rc2.
Sure, this patch was not delegated to me, so I did not notice this.
I will take it for RC2
  

On Tue, Jun 21, 2022 at 9:40 AM Akhil Goyal <gakhil@marvell.com> wrote:
> > > Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/
> > > I have acked this. @Akhil Goyal could this be merged ?.
> >
> > Indeed, I had forgotten about it.
> > Akhil, please take it for rc2.
> Sure, this patch was not delegated to me, so I did not notice this.
> I will take it for RC2

Thanks Akhil.