[dpdk-dev] mk: pass MODULE_CFLAGS to BSD module build system

Message ID 1414688334-16545-1-git-send-email-sergio.gonzalez.monroy@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Sergio Gonzalez Monroy Oct. 30, 2014, 4:58 p.m. UTC
When building shared libs (for both GCC and CLANG targets), -fPIC flag
has been added to CFLAGS and leaks to BSD module build system causing
the following error:

fatal error: error in backend: Cannot select: 0x802ad8010: i64 = X86ISD::WrapperRIP 0x802ade110
      [ID=13]
  0x802ade110: i64 = TargetGlobalAddress<i8** @__stack_chk_guard> 0 [TF=5] [ID=10]

Reset CFLAGS to MODULE_CFLAGS before building BSD module.

Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
 mk/rte.bsdmodule.mk | 1 +
 1 file changed, 1 insertion(+)
  

Comments

De Lara Guarch, Pablo Nov. 5, 2014, 2:32 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Thursday, October 30, 2014 4:59 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: pass MODULE_CFLAGS to BSD module
> build system
> 
> When building shared libs (for both GCC and CLANG targets), -fPIC flag
> has been added to CFLAGS and leaks to BSD module build system causing
> the following error:
> 
> fatal error: error in backend: Cannot select: 0x802ad8010: i64 =
> X86ISD::WrapperRIP 0x802ade110
>       [ID=13]
>   0x802ade110: i64 = TargetGlobalAddress<i8** @__stack_chk_guard> 0
> [TF=5] [ID=10]
> 
> Reset CFLAGS to MODULE_CFLAGS before building BSD module.
> 
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
  
Thomas Monjalon Nov. 5, 2014, 9:49 p.m. UTC | #2
> > When building shared libs (for both GCC and CLANG targets), -fPIC flag
> > has been added to CFLAGS and leaks to BSD module build system causing
> > the following error:
> > 
> > fatal error: error in backend: Cannot select: 0x802ad8010: i64 =
> > X86ISD::WrapperRIP 0x802ade110
> >       [ID=13]
> >   0x802ade110: i64 = TargetGlobalAddress<i8** @__stack_chk_guard> 0
> > [TF=5] [ID=10]
> > 
> > Reset CFLAGS to MODULE_CFLAGS before building BSD module.
> > 
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied

Thanks
  

Patch

diff --git a/mk/rte.bsdmodule.mk b/mk/rte.bsdmodule.mk
index 247ea2c..86b92ff 100644
--- a/mk/rte.bsdmodule.mk
+++ b/mk/rte.bsdmodule.mk
@@ -47,6 +47,7 @@  include $(RTE_SDK)/mk/internal/rte.depdirs-pre.mk
 
 # DPDK uses a more up-to-date gcc, so clear the override here.
 unexport CC
+override CFLAGS = $(MODULE_CFLAGS)
 
 # VPATH contains at least SRCDIR
 VPATH += $(SRCDIR)