[dpdk-dev,01/10] i40e: spellin fixes
Commit Message
From: Stephen Hemminger <shemming@brocade.com>
Spelling errors found with code spell.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_pmd_i40e/i40e_ethdev.c | 8 ++++----
lib/librte_pmd_i40e/i40e_ethdev.h | 2 +-
lib/librte_pmd_i40e/i40e_rxtx.c | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
Comments
On Sat, Jan 31, 2015 at 08:51:53PM +0000, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> Spelling errors found with code spell.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/librte_pmd_i40e/i40e_ethdev.c | 8 ++++----
> lib/librte_pmd_i40e/i40e_ethdev.h | 2 +-
> lib/librte_pmd_i40e/i40e_rxtx.c | 6 +++---
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
> index b47a3d2..07efca5 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -3810,16 +3810,16 @@ i40e_dev_handle_vfr_event(struct rte_eth_dev *dev)
> index = abs_vf_id / I40E_UINT32_BIT_SIZE;
> offset = abs_vf_id % I40E_UINT32_BIT_SIZE;
> val = I40E_READ_REG(hw, I40E_GLGEN_VFLRSTAT(index));
> - /* VFR event occured */
> + /* VFR event occurred */
> if (val & (0x1 << offset)) {
> int ret;
>
> /* Clear the event first */
> I40E_WRITE_REG(hw, I40E_GLGEN_VFLRSTAT(index),
> (0x1 << offset));
> - PMD_DRV_LOG(INFO, "VF %u reset occured", abs_vf_id);
> + PMD_DRV_LOG(INFO, "VF %u reset occurred", abs_vf_id);
> /**
> - * Only notify a VF reset event occured,
> + * Only notify a VF reset event occurred,
> * don't trigger another SW reset
> */
> ret = i40e_pf_host_vf_reset(&pf->vfs[i], 0);
> @@ -5007,7 +5007,7 @@ i40e_pf_config_rss(struct i40e_pf *pf)
>
> /*
> * If both VMDQ and RSS enabled, not all of PF queues are configured.
> - * It's necessary to calulate the actual PF queues that are configured.
> + * It's necessary to calculate the actual PF queues that are configured.
> */
> if (pf->dev_data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG) {
> num = i40e_pf_calc_configured_queues_num(pf);
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.h b/lib/librte_pmd_i40e/i40e_ethdev.h
> index f913ea9..dc870d2 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.h
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.h
> @@ -273,7 +273,7 @@ enum I40E_VF_STATE {
> struct i40e_pf_vf {
> struct i40e_pf *pf;
> struct i40e_vsi *vsi;
> - enum I40E_VF_STATE state; /* The number of queue pairs availiable */
> + enum I40E_VF_STATE state; /* The number of queue pairs available */
> uint16_t vf_idx; /* VF index in pf->vfs */
> uint16_t lan_nb_qps; /* Actual queues allocated */
> uint16_t reset_cnt; /* Total vf reset times */
> diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c
> index 2beae3c..56125cf 100644
> --- a/lib/librte_pmd_i40e/i40e_rxtx.c
> +++ b/lib/librte_pmd_i40e/i40e_rxtx.c
> @@ -1637,7 +1637,7 @@ i40e_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
> rxq = dev->data->rx_queues[rx_queue_id];
>
> /*
> - * rx_queue_id is queue id aplication refers to, while
> + * rx_queue_id is queue id application refers to, while
> * rxq->reg_idx is the real queue index.
> */
> err = i40e_switch_rx_queue(hw, rxq->reg_idx, FALSE);
> @@ -1667,7 +1667,7 @@ i40e_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
> txq = dev->data->tx_queues[tx_queue_id];
>
> /*
> - * tx_queue_id is queue id aplication refers to, while
> + * tx_queue_id is queue id application refers to, while
> * rxq->reg_idx is the real queue index.
> */
> err = i40e_switch_tx_queue(hw, txq->reg_idx, TRUE);
> @@ -1690,7 +1690,7 @@ i40e_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
> txq = dev->data->tx_queues[tx_queue_id];
>
> /*
> - * tx_queue_id is queue id aplication refers to, while
> + * tx_queue_id is queue id application refers to, while
> * txq->reg_idx is the real queue index.
> */
> err = i40e_switch_tx_queue(hw, txq->reg_idx, FALSE);
> --
> 2.1.4
>
>
For the series
Acked-by: Neil Horman <nhorman@tuxdriver.com>
2015-01-31 16:56, Neil Horman:
> On Sat, Jan 31, 2015 at 08:51:53PM +0000, Stephen Hemminger wrote:
> > From: Stephen Hemminger <shemming@brocade.com>
> >
> > Spelling errors found with code spell.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> For the series
No need of a serie for typo fixes. A single patch would be OK.
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
I was applying this acked patchset.
But having a quick look, it seems that the automatic fixes were not checked:
http://dpdk.org/ml/archives/dev/2015-February/012227.html
NACK
@@ -3810,16 +3810,16 @@ i40e_dev_handle_vfr_event(struct rte_eth_dev *dev)
index = abs_vf_id / I40E_UINT32_BIT_SIZE;
offset = abs_vf_id % I40E_UINT32_BIT_SIZE;
val = I40E_READ_REG(hw, I40E_GLGEN_VFLRSTAT(index));
- /* VFR event occured */
+ /* VFR event occurred */
if (val & (0x1 << offset)) {
int ret;
/* Clear the event first */
I40E_WRITE_REG(hw, I40E_GLGEN_VFLRSTAT(index),
(0x1 << offset));
- PMD_DRV_LOG(INFO, "VF %u reset occured", abs_vf_id);
+ PMD_DRV_LOG(INFO, "VF %u reset occurred", abs_vf_id);
/**
- * Only notify a VF reset event occured,
+ * Only notify a VF reset event occurred,
* don't trigger another SW reset
*/
ret = i40e_pf_host_vf_reset(&pf->vfs[i], 0);
@@ -5007,7 +5007,7 @@ i40e_pf_config_rss(struct i40e_pf *pf)
/*
* If both VMDQ and RSS enabled, not all of PF queues are configured.
- * It's necessary to calulate the actual PF queues that are configured.
+ * It's necessary to calculate the actual PF queues that are configured.
*/
if (pf->dev_data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG) {
num = i40e_pf_calc_configured_queues_num(pf);
@@ -273,7 +273,7 @@ enum I40E_VF_STATE {
struct i40e_pf_vf {
struct i40e_pf *pf;
struct i40e_vsi *vsi;
- enum I40E_VF_STATE state; /* The number of queue pairs availiable */
+ enum I40E_VF_STATE state; /* The number of queue pairs available */
uint16_t vf_idx; /* VF index in pf->vfs */
uint16_t lan_nb_qps; /* Actual queues allocated */
uint16_t reset_cnt; /* Total vf reset times */
@@ -1637,7 +1637,7 @@ i40e_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
rxq = dev->data->rx_queues[rx_queue_id];
/*
- * rx_queue_id is queue id aplication refers to, while
+ * rx_queue_id is queue id application refers to, while
* rxq->reg_idx is the real queue index.
*/
err = i40e_switch_rx_queue(hw, rxq->reg_idx, FALSE);
@@ -1667,7 +1667,7 @@ i40e_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
txq = dev->data->tx_queues[tx_queue_id];
/*
- * tx_queue_id is queue id aplication refers to, while
+ * tx_queue_id is queue id application refers to, while
* rxq->reg_idx is the real queue index.
*/
err = i40e_switch_tx_queue(hw, txq->reg_idx, TRUE);
@@ -1690,7 +1690,7 @@ i40e_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
txq = dev->data->tx_queues[tx_queue_id];
/*
- * tx_queue_id is queue id aplication refers to, while
+ * tx_queue_id is queue id application refers to, while
* txq->reg_idx is the real queue index.
*/
err = i40e_switch_tx_queue(hw, txq->reg_idx, FALSE);