[dpdk-dev] mk: fix for "make doc-guides-pdf" with make 3.81

Message ID	1427887965-19651-1-git-send-email-john.mcnamara@intel.com (mailing list archive)
State	Superseded, archived
Headers	From: John McNamara <john.mcnamara@intel.com> To: dev@dpdk.org Date: Wed, 1 Apr 2015 12:32:45 +0100 Message-Id: <1427887965-19651-1-git-send-email-john.mcnamara@intel.com> In-Reply-To: <551BB7C0.1020004@igel.co.jp> References: <551BB7C0.1020004@igel.co.jp> Subject: [dpdk-dev] [PATCH] mk: fix for "make doc-guides-pdf" with make 3.81 Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>

Message ID

1427887965-19651-1-git-send-email-john.mcnamara@intel.com (mailing list archive)

State

Superseded, archived

Headers

From: John McNamara <john.mcnamara@intel.com>
To: dev@dpdk.org
Date: Wed,  1 Apr 2015 12:32:45 +0100
Message-Id: <1427887965-19651-1-git-send-email-john.mcnamara@intel.com>
In-Reply-To: <551BB7C0.1020004@igel.co.jp>
References: <551BB7C0.1020004@igel.co.jp>
Subject: [dpdk-dev] [PATCH] mk: fix for "make doc-guides-pdf" with make 3.81
Precedence: list
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Commit Message

Mcnamara, John April 1, 2015, 11:32 a.m. UTC

Re-ordered the guide-pdf-% and guide-% rules to allow
the doc-guides-pdf target to build with make 3.81. It
builds unmodified with all later versions of make.

Reported-by: Tetsuya Mukawa <mukawa@igel.co.jp>
Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
 mk/rte.sdkdoc.mk | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comments

De Lara Guarch, Pablo April 1, 2015, 12:07 p.m. UTC | #1

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John McNamara
> Sent: Wednesday, April 01, 2015 12:33 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix for "make doc-guides-pdf" with make
> 3.81
> 
> Re-ordered the guide-pdf-% and guide-% rules to allow
> the doc-guides-pdf target to build with make 3.81. It
> builds unmodified with all later versions of make.
> 
> Reported-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Signed-off-by: John McNamara <john.mcnamara@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

diff mbox

Patch

diff --git a/mk/rte.sdkdoc.mk b/mk/rte.sdkdoc.mk
index 5b44083..0b69d99 100644
--- a/mk/rte.sdkdoc.mk
+++ b/mk/rte.sdkdoc.mk
@@ -94,11 +94,6 @@  guides-pdf-img-clean:
 	$(Q)rm -f $(RTE_SDK)/doc/guides/*/img/*.pdf
 
 guides-pdf: $(addprefix guides-pdf-, $(notdir $(RTE_GUIDES:/=))) ;
-guides-%:
-	@echo 'sphinx processing $@...'
-	$(Q)$(RTE_SPHINX_BUILD) -b $* $(RTE_SPHINX_VERBOSE) \
-		-c $(RTE_SDK)/doc/guides $(RTE_SDK)/doc/guides \
-		$(RTE_OUTPUT)/doc/$*/guides
 
 guides-pdf-%:
 	@echo 'sphinx processing $@...'
@@ -112,6 +107,12 @@  guides-pdf-%:
 	$(Q)mv $(RTE_OUTPUT)/doc/pdf/guides/$*/doc.pdf \
 		$(RTE_OUTPUT)/doc/pdf/guides/$*.pdf
 
+guides-%:
+	@echo 'sphinx processing $@...'
+	$(Q)$(RTE_SPHINX_BUILD) -b $* $(RTE_SPHINX_VERBOSE) \
+		-c $(RTE_SDK)/doc/guides $(RTE_SDK)/doc/guides \
+		$(RTE_OUTPUT)/doc/$*/guides
+
 # Each PDF depends on generated images *.pdf from *.svg
 $(foreach guide, $(RTE_GUIDES), $(foreach img, $(wildcard $(guide)img/*.svg), \
 	$(eval guides-pdf-$(notdir $(guide:/=)): $(img:svg=pdf))))