diff mbox

[dpdk-dev,2/2] tools: fix comment in bind script

Message ID 1428514670-7982-3-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger April 8, 2015, 5:37 p.m. UTC 
From: Stephen Hemminger <shemming@brocade.com>

The function documentation was obviously copied and not updated.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 tools/dpdk_nic_bind.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson April 15, 2015, 9:43 a.m. UTC | #1 
On Wed, Apr 08, 2015 at 10:37:50AM -0700, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
> 
> The function documentation was obviously copied and not updated.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  tools/dpdk_nic_bind.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
> index 8523f82..b7bd877 100755
> --- a/tools/dpdk_nic_bind.py
> +++ b/tools/dpdk_nic_bind.py
> @@ -391,7 +391,7 @@ def unbind_all(dev_list, force=False):
>          unbind_one(d, force)
>  
>  def bind_all(dev_list, driver, force=False):
> -    """Unbind method, takes a list of device locations"""
> +    """Bind method, takes a list of device locations"""
>      global devices
>  
>      dev_list = map(dev_id_from_dev_name, dev_list)
> -- 
> 2.1.4
>
Thomas Monjalon Aug. 3, 2015, 4:38 p.m. UTC | #2 
> > The function documentation was obviously copied and not updated.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Patch 1/2 has been rejected.
diff mbox

Patch

diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index 8523f82..b7bd877 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -391,7 +391,7 @@  def unbind_all(dev_list, force=False):
         unbind_one(d, force)
 
 def bind_all(dev_list, driver, force=False):
-    """Unbind method, takes a list of device locations"""
+    """Bind method, takes a list of device locations"""
     global devices
 
     dev_list = map(dev_id_from_dev_name, dev_list)