diff mbox

[dpdk-dev] fm10k: add missing newline to debug log

Message ID 1437067585-579-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Headers

Commit Message

Stephen Hemminger July 16, 2015, 5:26 p.m. UTC 
If FM10K_DEBUG_DRIVER is enabled, then the log messages about
function entry are missing newline causing extremely long lines.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Duyck July 16, 2015, 6:24 p.m. UTC | #1 
On 07/16/2015 10:26 AM, Stephen Hemminger wrote:
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
> index 04f8fe9..33d9120 100644
> --- a/drivers/net/fm10k/base/fm10k_osdep.h
> +++ b/drivers/net/fm10k/base/fm10k_osdep.h
> @@ -46,7 +46,7 @@ POSSIBILITY OF SUCH DAMAGE.
>   
>   #define STATIC                  static
>   #define DEBUGFUNC(F)            DEBUGOUT(F);
> -#define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> +#define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args)
>   #define DEBUGOUT1(S, args...)   DEBUGOUT(S, ##args)
>   #define DEBUGOUT2(S, args...)   DEBUGOUT(S, ##args)
>   #define DEBUGOUT3(S, args...)   DEBUGOUT(S, ##args)

I think this ends up adding a redundant "\n" to several other DEBUGOUT 
statements then.  Maybe you should update it so that DEBUGFUNC adds the 
"\n" instead of DEBUGOUT.

- Alex
diff mbox

Patch

diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
index 04f8fe9..33d9120 100644
--- a/drivers/net/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/fm10k/base/fm10k_osdep.h
@@ -46,7 +46,7 @@  POSSIBILITY OF SUCH DAMAGE.
 
 #define STATIC                  static
 #define DEBUGFUNC(F)            DEBUGOUT(F);
-#define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
+#define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args)
 #define DEBUGOUT1(S, args...)   DEBUGOUT(S, ##args)
 #define DEBUGOUT2(S, args...)   DEBUGOUT(S, ##args)
 #define DEBUGOUT3(S, args...)   DEBUGOUT(S, ##args)