diff mbox

[dpdk-dev,v2] fm10k: add missing newline to debug log

Message ID 1437080800-1549-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger July 16, 2015, 9:06 p.m. UTC 
If FM10K_DEBUG_DRIVER is enabled, then the log messages about
function entry are missing newline causing extremely long lines.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chen, Jing D July 21, 2015, 7:43 a.m. UTC | #1 
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, July 17, 2015 5:07 AM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH v2] fm10k: add missing newline to debug log
> 
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by : Jing Chen <jing.d.chen@intel.com>
Thomas Monjalon July 22, 2015, 10:43 a.m. UTC | #2 
> > If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> > function entry are missing newline causing extremely long lines.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Acked-by : Jing Chen <jing.d.chen@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
index 04f8fe9..53c433c 100644
--- a/drivers/net/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/fm10k/base/fm10k_osdep.h
@@ -45,7 +45,7 @@  POSSIBILITY OF SUCH DAMAGE.
 #define ERROR_REPORT2(v1, v2, v3)   do { } while (0)
 
 #define STATIC                  static
-#define DEBUGFUNC(F)            DEBUGOUT(F);
+#define DEBUGFUNC(F)            DEBUGOUT(F "\n");
 #define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
 #define DEBUGOUT1(S, args...)   DEBUGOUT(S, ##args)
 #define DEBUGOUT2(S, args...)   DEBUGOUT(S, ##args)