[dpdk-dev] eal: fix compilation for x86_x32-native-linuxapp-gcc

Message ID 1438288008-4294-1-git-send-email-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Olivier Matz July 30, 2015, 8:26 p.m. UTC
  Compiling for dpdk x86_x32 gives the following error:

  CC eal_common_timer.o
In file included from /usr/include/sys/sysctl.h:63:0,
                 from dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
/usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is unsupported in x32 kernel"
 # error "sysctl system call is unsupported in x32 kernel"
   ^
dpdk.org/mk/internal/rte.compile-pre.mk:126: recipe for target 'eal_common_timer.o' failed
make[6]: *** [eal_common_timer.o] Error 1

Including sysctl.h was added by mistake when merging bsd and linux EAL
timer code. It can be safely removed in this file, fixing the
compilation.

Fixes: 040cf8a411 ("eal: deduplicate timer functions")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/librte_eal/common/eal_common_timer.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Thomas Monjalon Aug. 2, 2015, 10:25 p.m. UTC | #1
2015-07-30 22:26, Olivier Matz:
> Compiling for dpdk x86_x32 gives the following error:
> 
>   CC eal_common_timer.o
> In file included from /usr/include/sys/sysctl.h:63:0,
>                  from dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
> /usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is unsupported in x32 kernel"
>  # error "sysctl system call is unsupported in x32 kernel"
>    ^
> dpdk.org/mk/internal/rte.compile-pre.mk:126: recipe for target 'eal_common_timer.o' failed
> make[6]: *** [eal_common_timer.o] Error 1
> 
> Including sysctl.h was added by mistake when merging bsd and linux EAL
> timer code. It can be safely removed in this file, fixing the
> compilation.
> 
> Fixes: 040cf8a411 ("eal: deduplicate timer functions")
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
index 255f995..72371b8 100644
--- a/lib/librte_eal/common/eal_common_timer.c
+++ b/lib/librte_eal/common/eal_common_timer.c
@@ -36,7 +36,6 @@ 
 #include <unistd.h>
 #include <inttypes.h>
 #include <sys/types.h>
-#include <sys/sysctl.h>
 #include <errno.h>
 
 #include <rte_common.h>