[dpdk-dev,v3,1/2] version: switch to year/month version numbers

  From: "Richardson, Bruce" <bruce.richardson@intel.com>

As discussed on list, switch numbering scheme to be based on year/month.
Release 2.3 then becomes 16.04.

    Ref: http://dpdk.org/ml/archives/dev/2015-December/030336.html

Also, added zero padding to the month so that it appear as 16.04 and
not 16.4 in "make showversion" and rte_version().

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
 drivers/net/nfp/nfp_net.c                   |  2 --
 lib/librte_eal/common/include/rte_version.h | 42 ++++++++++++++---------------
 mk/rte.sdkconfig.mk                         |  2 +-
 3 files changed, 22 insertions(+), 24 deletions(-)
  

> -----Original Message-----
> From: Mcnamara, John
> Sent: Wednesday, February 10, 2016 5:02 PM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> Subject: [PATCH v3 1/2] version: switch to year/month version numbers


> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index
> ffa5730..fd4dd39 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -1070,9 +1070,7 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  	};
> 
>  	dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; 
>-#if RTE_VER_MAJOR == 2 && RTE_VER_MINOR >= 1
>  	dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>-#endif  }
> 

Hi Alejandro,

Please note the above change to the nfp_net.c code due to the name change
in the version macro names.


I was originally going to change it to this:

    #if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1
        dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
    #endif

Or better:

    #if RTE_VERSION >= 0x02010000
        dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
    #endif

However, since the code was added in DPDK 2.2 the version check doesn't seem
necessary, so I removed it. If you need it back in for some reason let me know.

John
  

2016-02-10 17:11, Mcnamara, John:
> Hi Alejandro,
> 
> Please note the above change to the nfp_net.c code due to the name change
> in the version macro names.
> 
> 
> I was originally going to change it to this:
> 
>     #if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1
>         dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>     #endif
> 
> Or better:
> 
>     #if RTE_VERSION >= 0x02010000
>         dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>     #endif

Or better:
	#if RTE_VERSION >= RTE_VERSION_NUM(2,1,0,0)

> However, since the code was added in DPDK 2.2 the version check doesn't seem
> necessary, so I removed it. If you need it back in for some reason let me know.

A version check is needed for external applications or external drivers.
It should not exist in the git tree.
  

2016-02-10 17:02, John McNamara:
> From: "Richardson, Bruce" <bruce.richardson@intel.com>
> 
> As discussed on list, switch numbering scheme to be based on year/month.
> Release 2.3 then becomes 16.04.
> 
>     Ref: http://dpdk.org/ml/archives/dev/2015-December/030336.html
> 
> Also, added zero padding to the month so that it appear as 16.04 and
> not 16.4 in "make showversion" and rte_version().
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: John McNamara <john.mcnamara@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Series applied, thanks