From patchwork Fri Jul 8 22:22:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 14707 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 85C759AC8; Sat, 9 Jul 2016 00:22:06 +0200 (CEST) Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id D74CB9AC7 for ; Sat, 9 Jul 2016 00:22:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=731; q=dns/txt; s=iport; t=1468016525; x=1469226125; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=WOsysV342YUR18U0XtUlBntRp+WddKiX6xF0pqlYPW0=; b=I0mQ5yIIiu7WpfnpbjHpfuZC/ypIeeTVTDNRmNNDy6zg8xL5r0lfpgYm LDTsX0pPMBySR4hwhLc0pg+igzCn+q9cNqDawM7ccTyTm7BxQEmocAT5l YVUTmb+VuWObPW88laspDw9tE10hE22SxAEQBGhp0Mg3tONjwPqhUXq7I 4=; X-IronPort-AV: E=Sophos;i="5.28,332,1464652800"; d="scan'208";a="124017590" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2016 22:22:04 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id u68MM3FO007653; Fri, 8 Jul 2016 22:22:03 GMT Received: by cisco.com (Postfix, from userid 392789) id AD6A33FAAE40; Fri, 8 Jul 2016 15:22:03 -0700 (PDT) From: John Daley To: dev@dpdk.org Cc: bruce.richardson@intel.com, John Daley Date: Fri, 8 Jul 2016 15:22:01 -0700 Message-Id: <1468016521-20280-2-git-send-email-johndale@cisco.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1468016521-20280-1-git-send-email-johndale@cisco.com> References: <1468016521-20280-1-git-send-email-johndale@cisco.com> Subject: [dpdk-dev] [PATCH] net/enic: increment filter failure counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" One instance of a filter add failure was not incrementing the the fail counter. Fixes: 4c2c7bf41f5a ("net/enic: fix negative array index write") Signed-off-by: John Daley --- drivers/net/enic/enic_clsf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index 3365176..e6f57be 100644 --- a/drivers/net/enic/enic_clsf.c +++ b/drivers/net/enic/enic_clsf.c @@ -218,6 +218,7 @@ int enic_fdir_add_fltr(struct enic *enic, struct rte_eth_fdir_filter *params) pos = rte_hash_add_key(enic->fdir.hash, params); if (pos < 0) { + enic->fdir.stats.f_add++; dev_err(enic, "Add hash key failed\n"); return pos; }