diff mbox

[dpdk-dev] vhost: change log levels in client mode

Message ID 1488447574-6266-1-git-send-email-i.maximets@samsung.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Ilya Maximets March 2, 2017, 9:39 a.m. UTC 
  Inability to connect to socket is a normal situation
in client mode because, in common case, server isn't
started yet. RTE_LOG_WARNING should be suitable for
the case of some unusual errors.
Message about reconnection is not an error at all.

CC: stable@dpdk.org
Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 lib/librte_vhost/socket.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Maxime Coquelin March 2, 2017, 1:33 p.m. UTC | #1 
On 03/02/2017 10:39 AM, Ilya Maximets wrote:
> Inability to connect to socket is a normal situation
> in client mode because, in common case, server isn't
> started yet. RTE_LOG_WARNING should be suitable for
> the case of some unusual errors.
> Message about reconnection is not an error at all.
>
> CC: stable@dpdk.org
> Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
>
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>  lib/librte_vhost/socket.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index aaa9c27..6a30a31 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
>  		return 0;
>  	}
>
> -	RTE_LOG(ERR, VHOST_CONFIG,
> +	RTE_LOG(WARNING, VHOST_CONFIG,
>  		"failed to connect to %s: %s\n",
>  		path, strerror(errno));
>
> @@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
>  		return -1;
>  	}
>
> -	RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
> +	RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
>  	reconn = malloc(sizeof(*reconn));
>  	if (reconn == NULL) {
>  		RTE_LOG(ERR, VHOST_CONFIG,
>

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks!
Maxime
Yuanhan Liu March 3, 2017, 2:07 a.m. UTC | #2 
On Thu, Mar 02, 2017 at 02:33:27PM +0100, Maxime Coquelin wrote:
> 
> 
> On 03/02/2017 10:39 AM, Ilya Maximets wrote:
> >Inability to connect to socket is a normal situation
> >in client mode because, in common case, server isn't
> >started yet. RTE_LOG_WARNING should be suitable for
> >the case of some unusual errors.
> >Message about reconnection is not an error at all.
> >
> >CC: stable@dpdk.org
> >Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
> >
> >Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
...
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu
diff mbox

Patch

diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index aaa9c27..6a30a31 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -448,7 +448,7 @@  vhost_user_create_client(struct vhost_user_socket *vsocket)
 		return 0;
 	}
 
-	RTE_LOG(ERR, VHOST_CONFIG,
+	RTE_LOG(WARNING, VHOST_CONFIG,
 		"failed to connect to %s: %s\n",
 		path, strerror(errno));
 
@@ -457,7 +457,7 @@  vhost_user_create_client(struct vhost_user_socket *vsocket)
 		return -1;
 	}
 
-	RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
+	RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
 	reconn = malloc(sizeof(*reconn));
 	if (reconn == NULL) {
 		RTE_LOG(ERR, VHOST_CONFIG,