From patchwork Fri Jul 7 06:02:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanhan Liu X-Patchwork-Id: 26627 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id F2CA9376C; Fri, 7 Jul 2017 08:02:59 +0200 (CEST) Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id CB9F52C8 for ; Fri, 7 Jul 2017 08:02:56 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id e199so3216704pfh.0 for ; Thu, 06 Jul 2017 23:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OlvbukGsCc0d/k6xAH69LEzJ1U5iX2CRqAoeBqyiH20=; b=EXtS2PGJ/qoA7YZrutSS6yhWCDUJisguWBoxjWbjbnBksOjQOvF1t035P6BiUoQGNz 8ZuyBRRFkXfIOnce3wOIeCvaPPfhoKyyUaWx2sdQdo4HtLEBMnK5vsMC5VbUWEyh+Hjn DNyO+FNC80u4zBJuA3itkldFlFu0QE1U6PVXQWxDlXW0UWLanxd0uiXYhgiaMk7qXuDs SFoiMPIaMU2jn3D7I5tbsl1TKNbM3X5AkMjB6cavC0W1vvxG3FNfI2RdsILDLSIBni6T TwFDmeqUPGnMOWOyx/2VxwVYD99YHiZybrN/j0U3QFhVyqmZ32Enzm+CQrvQxV0wlxV2 a5jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OlvbukGsCc0d/k6xAH69LEzJ1U5iX2CRqAoeBqyiH20=; b=MEMiGmjrb/YBESM5w/+SfjOek84fV67x6xno+kaeJsNp6AaggMBeAW/AcrHUwgFytU Wq41kwsWOmOaYLK1fDPtJY/EYwLyNtxlrgfhvE4BS6U531sbUb0yeP5DAV+1xkXbZRmO fLfHTHOro9hEvb7YdxWdObyc3VFIdcYVDChTcNBIgzn6MRaEr9G68ssoq9DOtZ7E1D0r d3Z6UDZcWGP5nQq7ROF+rgEnHTfswZpH1IZhOrj+wY4hBUm03+vHVaAWDM18WnPnS/3L 8svwIo0gS26CrShMoQs/vXQVj8XIKp7fdtbua7jmODN/mlzsR6noa9Fmx65JZtCgUeUq fwQg== X-Gm-Message-State: AIVw1110StKpxr2O/f+NUAMYOWqZQ/fp4cG4bslDifZOqEdJp27189E2 BGWJIXUshWJuGoEtQwgsEg== X-Received: by 10.84.232.3 with SMTP id h3mr1138371plk.42.1499407375633; Thu, 06 Jul 2017 23:02:55 -0700 (PDT) Received: from localhost.localdomain ([124.79.170.245]) by smtp.gmail.com with ESMTPSA id t78sm4437783pfa.48.2017.07.06.23.02.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Jul 2017 23:02:54 -0700 (PDT) From: Yuanhan Liu To: dev@dpdk.org Cc: Jingjing Wu , Yuanhan Liu Date: Fri, 7 Jul 2017 14:02:13 +0800 Message-Id: <1499407333-1682-2-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499407333-1682-1-git-send-email-yliu@fridaylinux.org> References: <1499407333-1682-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-dev] [PATCH 2/2] testpmd: give more hint on invalid RETA size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Print the valid RTE size range so that user knows what goes wrong. Signed-off-by: Yuanhan Liu --- app/test-pmd/cmdline.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c8faef9..d32a1df 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2140,12 +2140,14 @@ cmd_showport_reta_parsed(void *parsed_result, struct cmd_showport_reta *res = parsed_result; struct rte_eth_rss_reta_entry64 reta_conf[8]; struct rte_eth_dev_info dev_info; + uint16_t max_reta_size; memset(&dev_info, 0, sizeof(dev_info)); rte_eth_dev_info_get(res->port_id, &dev_info); - if (dev_info.reta_size == 0 || res->size > dev_info.reta_size || - res->size > ETH_RSS_RETA_SIZE_512) { - printf("Invalid redirection table size: %u\n", res->size); + max_reta_size = RTE_MIN(dev_info.reta_size, ETH_RSS_RETA_SIZE_512); + if (res->size == 0 || res->size > max_reta_size) { + printf("Invalid redirection table size: %u (1-%u)\n", + res->size, max_reta_size); return; }