diff mbox

[dpdk-dev,v3] doc: add new targets to "make help" output

Message ID 1499447399-9467-1-git-send-email-erik.g.carrillo@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Carrillo, Erik G July 7, 2017, 5:09 p.m. UTC 
  Commit aafaea3d3b70 ("devtools: add tags
and cscope index generation") introduced
new make targets. This change updates the
help target output to reflect the additions.

Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
---
v3:
* Updated formatting.

 doc/build-sdk-quick.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Aug. 3, 2017, 10:50 p.m. UTC | #1 
Hi,

Sorry for the very very late review.

07/07/2017 19:09, Gabriel Carrillo:
> Commit aafaea3d3b70 ("devtools: add tags
> and cscope index generation") introduced
> new make targets. This change updates the
> help target output to reflect the additions.
> 
> Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> +	tags|gtags T=    generate tags/gtags for given targets (T=)
> +	cscope T=        generate cscope database for given targets (T=)

No need of T= in the first column.
It is specified only for install which has two different meanings
with and without T=.

You should also add etags I think.
Thomas Monjalon Aug. 5, 2017, 9:08 a.m. UTC | #2 
04/08/2017 00:50, Thomas Monjalon:
> Hi,
> 
> Sorry for the very very late review.
> 
> 07/07/2017 19:09, Gabriel Carrillo:
> > Commit aafaea3d3b70 ("devtools: add tags
> > and cscope index generation") introduced
> > new make targets. This change updates the
> > help target output to reflect the additions.
> > 
> > Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> > ---
> > +	tags|gtags T=    generate tags/gtags for given targets (T=)
> > +	cscope T=        generate cscope database for given targets (T=)
> 
> No need of T= in the first column.
> It is specified only for install which has two different meanings
> with and without T=.
> 
> You should also add etags I think.

Updated myself and applied, thanks
diff mbox

Patch

diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt
index 8d41052..3507220 100644
--- a/doc/build-sdk-quick.txt
+++ b/doc/build-sdk-quick.txt
@@ -11,6 +11,8 @@  Build commands
 	examples_clean   clean examples for given targets (T=)
 	test             compile tests and run basic unit tests
 	test-*           run specific subset of unit tests
+	tags|gtags T=    generate tags/gtags for given targets (T=)
+	cscope T=        generate cscope database for given targets (T=)
 Build variables
 	EXTRA_CPPFLAGS   preprocessor options
 	EXTRA_CFLAGS     compiler options