diff mbox

[dpdk-dev] bus/fslmc: fixes missing brace

Message ID 1499763019-1271-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Hemant Agrawal July 11, 2017, 8:50 a.m. UTC 
  Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/fslmc/fslmc_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon July 11, 2017, 9:18 a.m. UTC | #1 
11/07/2017 10:50, Hemant Agrawal:
> Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

That's why review is important :)
I should add dpaa2 target in my compilation tests.

Applied, thanks
Hemant Agrawal July 11, 2017, 11:30 a.m. UTC | #2 
On 7/11/2017 2:48 PM, Thomas Monjalon wrote:
> 11/07/2017 10:50, Hemant Agrawal:
>> Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> That's why review is important :)

It is generally expected that the submitter will check the compilation 
or he will at the least tag the respective maintainer for the same.

> I should add dpaa2 target in my compilation tests.
>
yes please. Thanks!

> Applied, thanks
>
diff mbox

Patch

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 60eb8d2..f71598d 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -113,7 +113,7 @@  rte_fslmc_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
 	struct rte_dpaa2_device *dev;
 
 	TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
-		if (start && &dev->device == start)
+		if (start && &dev->device == start) {
 			start = NULL;  /* starting point found */
 			continue;
 		}