From patchwork Fri Sep 8 10:47:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 28509 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D5C1C7CC8; Fri, 8 Sep 2017 12:48:28 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0082.outbound.protection.outlook.com [104.47.2.82]) by dpdk.org (Postfix) with ESMTP id 273172C2E for ; Fri, 8 Sep 2017 12:48:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VLSEhjnjr/kUVlV6D0pAKPo0+ck2rHRRLc7V5tuzPhM=; b=qNhqknEcCY5PfOoK/9crMjMpyLlbzR/i/yjOF/t/N28lZ7BdD/J0sClm1SGSqXKalsNtRTX0fyH/yd408UdaRCBgTWNf4bGQvuThj1jou/JNmjElnFgjrCdZ7R5tp6syT58E3FQeaqHeGD2tSf+w4RI9fb2n19/TUKlfsxZ4VT0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0502MB3047.eurprd05.prod.outlook.com (2603:10a6:4:9f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Fri, 8 Sep 2017 10:48:24 +0000 From: Matan Azrad To: Nelio Laranjeiro , Adrien Mazarguil Cc: dev@dpdk.org, Ferruh Yigit Date: Fri, 8 Sep 2017 13:47:45 +0300 Message-Id: <1504867665-42908-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504710238-25726-2-git-send-email-matan@mellanox.com> References: <1504710238-25726-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR1001CA0009.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::19) To DB6PR0502MB3047.eurprd05.prod.outlook.com (2603:10a6:4:9f::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 926ffb20-1aa0-4f3d-f2e2-08d4f6a72193 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0502MB3047; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3047; 3:eq2Mak5XYGiwCJ3km/VcHRCe2G1K6IyNhCENsdiaaPJvMgkHgvY0l0nCXzk7zKIDhO0w971zuFN8Rd3OhyIBJvpbljffKT1BnLxGautAyx67zQ0VdMWwC1vKJWZpP5N9Dujr7E23c1JtQgvsFVQim2keiivlgix6DH75uw59LUGvnWs4+hN89o24/F+7WOx7fZw6Py1NaXP9S4fizQwOc6kiPag99PGTB86bT++CiGLu5pyv8yDR6WbfI5JDkK/f; 25:eQoKSwfetLbsYDO5xXqgAeBO627qZIlxDB9MJ1XIIekqwitzDp8c2r1s3+MrkuVTuw86Ch94HIWnroxZrGr9ktwoLvbEIEAeQEi9YDz1jtF+FIZL+GGsBcBjhjNni6cKFW2+inVUjTwZVSsV7adtlclh2TUNl02CUJv7Ept1VKH+o4yYDh04y/6l8JfGLNy4GvdwEO7yxxPwpK9zLB6Ojpz0KO3CUAQJV4jysx1qwm2dB3D+6wdZmLOAcAq8e3TwCl1zCozE+spdwX9SM9O7agxLcf2ZxPSa6f2kowYeAi+fP6opihrW9dMVmWd3hKorz+fBx2ifsiU68MURzCXEvg==; 31:q3Io2W3gyIty6Wj7xcdgku17Te93pPuGVF3CPtIgB50DJQpkBOD2xfxs4LMPnq1QJI8HNUSQdVobg5urCF8z7dlNxbjWoNK3g5euu8tm2pkifYpE+hsIQE9aE+iFLqrz02BRaqSqGaApgOTB4X50C/npZCRcZPETrxq//+Ov4B6k+CabeUx72VGZDvXik40Bu6kAyuQuv5GxWY+hLe5nDeMGMYRC6M7ie5Jlgx5xt4A= X-MS-TrafficTypeDiagnostic: DB6PR0502MB3047: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3047; 20:bdXjp6ofwYvKKZv8U4ORbFlFlciWeHMxh0TsJVCN3h3g2ibgYnnd+YsQ01VSnHsqlV38Zs1tf5CYMk72GOGecOPa28860xWl1z0OChpBW3jJKzPrLD7DbROoxXAM/FmW845/Ga85yI/lXKJmjYR578TVNwH7Pnr37pSZ3+5iEF0ZWIw9eNWYgwm1Su2vlIhXPqr4sHFcwl/7otHgRZcGEAWnSSAFg39jjH0jZBnNPqEQxdbhcomhDALkE1DBHQ8pJMbqken38hfCpREBqWiItuoHZ9Z+l+IwKYO7RwP3e1NbsifNDmj/5N1FKDGaJDvuAj/Z0MpaRYybSX7nJ+Dqm9Lbgl8pd86EzO2njrrMGE37ROoaORM5QPBrDN6dWyjL081Rg8s13r9psT7EMYu5o7LGKthhqUauF1lg+xLiB2g6HrQgVK5QLpenVv4kzauLeDqSRDbrEOWNmGyan8A9Hc3jsF34cHhLmh0TB9GtqQRrL9O/J2oHLwFyvBkqzGzu; 4:ykVXjdn77ACUcP5tJE5EmuHLq0fhlkPuAb7tmBrLHN50rYa3Qs2r9tMO93gDU5WMCr6qY/TynUKkiluh6hoVxA5x2yqt5bu21Ma1W4u7pbTHd1RUBlIDejBsik9VVaAl/J+S2uctQbderk8dbXKBBGCou/PvaqugeDdUNoHPNni1wld8B8e60sgKJQk++CIXb1yFOy5HZInyaAX/MhIWXDvQ2Ef7I8Fs2r0HWALtRYjlcv6ZNwpVZmOGLhFSInjn X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB3047; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB3047; X-Forefront-PRVS: 04244E0DC5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(199003)(189002)(86362001)(106356001)(478600001)(6666003)(68736007)(7736002)(25786009)(33026002)(105586002)(42186005)(5003940100001)(69596002)(5660300001)(8676002)(305945005)(6116002)(2950100002)(101416001)(81156014)(50226002)(81166006)(7350300001)(189998001)(97736004)(66066001)(47776003)(2906002)(4326008)(3846002)(36756003)(48376002)(50466002)(50986999)(76176999)(33646002)(55016002)(21086003)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB3047; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0502MB3047; 23:Kd10QmZJHLWrfZDAVPEt0z8sv4+2gevXKaZZ3MZ?= ed8iefi2myti7goA8BKYMKFseE4q0bxleR0atIn9RrkMRLcY6qcuDMiWBX9Zq6ohzhtG3tyNfZDKQWcLCzIq53bYpFyfjgkAPfUUiaTXtuZ88Hj/NYNTp12GdD/ZmBbxw6/EhBaAoy6XUTKs/dA7T+xHCry+HBgbid9Ao2UaPosGHbL7fyN8Wf0+eO9XNrDuPqshO9R9GEIMgsQlj7yTPsEi9iw9vtvoVcZSXIHuQpIL5cEY/USoXP3tlGDpAWIw/aSMtnT1YjJ9JFAcQDVeyMbf8aOKxwLqlszpaGu6b27OWFeK8Y2VPHH1qrFHhAdTLa9qGXre1RbBayRZvNTcmvvmjizQQHXWAYkVB/Nh3QrR9lJwzqgn7Rv1+gXNqDvHBkrqBXE5LdW4HUHvy5Fmm0NkRvSQLT8kp6iJTWrJ2XtKe9iZ9fM4GWsKZKyNKlO6KMeBAeeOwpVllHHb5mKXeHFda8J91+EgF4lFZpqCSEKcHHrlFxsZTQjFE4GeNC1R27lxgW4FiE2NEqD4oaloAOcfV1n/aqW9wvD8/cWiy6YOnN2hnuZERKNicHbg2J/jJhmFpaIzVCR/95i6pzZlJ1anYYABXn8+DYBBeO9nu0Eq1tqutn6csOmn757DVNl7YXdaCJIlR3Sq/YaHDHg1BDsNCcSOOpwJJDi3/OlPAp0jp07mz6R8yc+GdGuRcBgJKnXiplyEyzrY3V37Ar6X17xOyi6E8sS2JDi3+U8P0In+k+cLnqjMYGLGrnuyzfK3iwOfzitNcH3lic0/40gNK/7QIApGG9oypZmmQkZWJnW1xh58oRIM1uh8d0VXnTEglqMdb116lVuRKj+z5UaAWyl+uwEqwUXtjQFfeHoXK5kosCqjydVGvP7ybpjQW1aW1IhOKI2pb4qk9jU2NfiDdoju4ASpNN12LepqX8deibmhZ6SsQgrlKfM/1EPmyH5juIFSoo9XMTth+lCYNi1w/J8CDyc5XdXnxWD4YpujwQ+1XBS7iIarh3tByZaDsKoqB8SF6Lac/+k9XernzgHCn0HtJUaKDj1po8IxxepPDZlrVJw== X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3047; 6:5cfeDiTexKjFwpjPawA8jgMRXw3A9ljnCDnzPxkaHLa990p1yyxpTXkDL5jD1D0liCaqjT+fxaYgwDUoMguU6HPhj2o4i5UZNC2z7nrqYbYKmCEUqb1Ks3Pyu07pM14BzJpXemawaRkPTXxbmImbaKfO5QmPfccCtHE1Kr4Oz+E3TS4u+GU4cGj9zvYL65EeRJ6As/6jC5gJrWYtyGo5/OvHUwMi1FQZgMQUjvPHKwaraLm4//0SOLh1gJQfWlRUXmU2h6NtHZr4mP+XIisBciHQCjR9jK7d/yfr78yduY12sEJR/RgS1JTOUJ98GMFOd4iPk+bbxI9+qR932g6PDA==; 5:2a+hrSaIGO18PhrJAIZ7PTt16dEBLJmCcR0fP+H62wU5Y2EXuMpIa1cSPJva9pIAdDKN3kXXes+tZfN1rtXNS9hpSngwJ0UdbindXzeb1KqZDtcimDG9JFC3uAqXuxFGaP4A/GkVc8gLMarnNPiWe98EP7cUt19EDKbKNEPTUz0=; 24:FBz5rJ6miibOayUzIwDq52ZPptVz3RabufQ08FHHtFLkv+Hl/tDSxHJhsKVfMFHP4TWwTEbDtg1/8I3YnXZh9k4irkvv6HbZA3t6PIeuVTo=; 7:4NX261Du4pelz2Z683raTO7dR0rkxbhCiooXhiVhf9rTSMuaXpxNayHd31RYuhPxY6BbMPa4dGuvUjV73m/I/D/BB/Y1Bz63/036/LoAioibp+VOi8oIUqA3h4GS0Q3C/5476scl+m/gtOzJjEirFqOQQyu/RC0eSaCbc1x9AC1WHosevOlqzVLdanh0Dc/c46TwovahQCIksrtUb52+W2fx1xHsLkx8+dFfyQnE9ZU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2017 10:48:24.1585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB3047 Subject: [dpdk-dev] [PATCH v5] net/mlx5: support device removal event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Extend the LSC event handling to support the device removal as well. The mlx5 event handling has been made capable of receiving and signaling several event types at once. This support includes next: 1. Removal event detection according to the user configuration. 2. Calling to all registered mlx5 removal callbacks. 3. Capabilities extension to include removal interrupt handling. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- doc/guides/nics/features/mlx5.ini | 1 + drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_ethdev.c | 13 +++++++++++-- 3 files changed, 13 insertions(+), 3 deletions(-) V5 for adding support in mlx5 feature doc. diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini index 2913591..20a1461 100644 --- a/doc/guides/nics/features/mlx5.ini +++ b/doc/guides/nics/features/mlx5.ini @@ -7,6 +7,7 @@ Speed capabilities = Y Link status = Y Link status event = Y +Removal event = Y Rx interrupt = Y Queue start/stop = Y MTU update = Y diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 32081a4..99a2fb3 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -870,7 +870,7 @@ static struct rte_pci_driver mlx5_driver = { }, .id_table = mlx5_pci_id_map, .probe = mlx5_pci_probe, - .drv_flags = RTE_PCI_DRV_INTR_LSC, + .drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV, }; /** diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 64a8db8..b57de4b 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -1172,6 +1172,9 @@ priv_dev_status_handler(struct priv *priv) event.event_type == IBV_EVENT_PORT_ERR) && (priv->dev->data->dev_conf.intr_conf.lsc == 1)) ret |= (1 << RTE_ETH_EVENT_INTR_LSC); + else if (event.event_type == IBV_EVENT_DEVICE_FATAL && + priv->dev->data->dev_conf.intr_conf.rmv == 1) + ret |= (1 << RTE_ETH_EVENT_INTR_RMV); else DEBUG("event type %d on port %d not handled", event.event_type, event.element.port_num); @@ -1227,6 +1230,9 @@ mlx5_dev_interrupt_handler(void *cb_arg) if (events & (1 << RTE_ETH_EVENT_INTR_LSC)) _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL, NULL); + if (events & (1 << RTE_ETH_EVENT_INTR_RMV)) + _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RMV, NULL, + NULL); } /** @@ -1240,7 +1246,8 @@ mlx5_dev_interrupt_handler(void *cb_arg) void priv_dev_interrupt_handler_uninstall(struct priv *priv, struct rte_eth_dev *dev) { - if (!dev->data->dev_conf.intr_conf.lsc) + if (!dev->data->dev_conf.intr_conf.lsc && + !dev->data->dev_conf.intr_conf.rmv) return; rte_intr_callback_unregister(&priv->intr_handle, mlx5_dev_interrupt_handler, @@ -1265,7 +1272,8 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev) { int rc, flags; - if (!dev->data->dev_conf.intr_conf.lsc) + if (!dev->data->dev_conf.intr_conf.lsc && + !dev->data->dev_conf.intr_conf.rmv) return; assert(priv->ctx->async_fd > 0); flags = fcntl(priv->ctx->async_fd, F_GETFL); @@ -1273,6 +1281,7 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev) if (rc < 0) { INFO("failed to change file descriptor async event queue"); dev->data->dev_conf.intr_conf.lsc = 0; + dev->data->dev_conf.intr_conf.rmv = 0; } else { priv->intr_handle.fd = priv->ctx->async_fd; priv->intr_handle.type = RTE_INTR_HANDLE_EXT;