From patchwork Tue Sep 19 01:51:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28919 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF9371B1EE; Tue, 19 Sep 2017 03:52:29 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0076.outbound.protection.outlook.com [104.47.36.76]) by dpdk.org (Postfix) with ESMTP id 478661B19D for ; Tue, 19 Sep 2017 03:52:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=npJYg5yKQ7518KPgc77nBIP4D6T83P+K9GVTLLYDS6Y=; b=TwtkCoAJKjXBL2OP+4R0u12kTkH54+JGhz1YdXtt5rJ+yCW6w4JtixEZkAV6mdc8ecCnY8uuEfBSyzE5Afztp1/KnkNmd7V/Go9pRUxDTxDZo/I6ymat/T6ODClcIrVhWZh/Qf7m6uZiQ5FtxY+hxYuZkEGLzqo2mG96wvAKdSs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:10 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:51:34 -0700 Message-Id: <1505785903-1741-15-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f64389db-038a-4f87-bb80-08d4ff010ac4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:C/s5m8kVKdLjHixwxVuhJ4lluAETIwX3eSfiLJos09Z6xwJJWd9f8RIZOErytwbncghNEjKGEcVN1uXk8Hp2jelPi7I02p4WiQGyKwl1gcgicnxn+IoHX229laH//hFkdVf/3lzb8OEhu5PM/YoqDjC7KThwI8Lp3CdpCdxGX5DGtAThSNQeWg+HtNKldNW2aqsipiDlf73Eacg6m3+lT+I8/A33rLMz57iLGio+M6iRFGWUuh2eJq0PJil+7bTs; 25:1S8oeVCAHbmFQ5IYyIalcHkuVfzv/u25ukmSWJRWMTbm70twMck1UUsupKAGrZjv55hR8R6SssGyx5wevKsH9rhRfhheu2NsfxTWFlAa+SMcEsy0WpadtvAnr7wbW609zW0EPM1KpjFUtv1V6Q+WsdC61O/kYDzYdiIEVA6dDabaHivxhDM/HPN5thpwIbTFS38kjvE9pR9+vNe9p1BMHi1kgB7nb++DIl+a2PFkwhrS+qgMzRhTun9khoFDnucsgD62w/dzKSX/siFRXj81/cYv2GjLatKRQQCVOg7urhHdRtKcQs4EZZuX3B9tqHuudrzju6RPFKJYx866nxPtfg==; 31:cBwbdpXX2Ll2qlCYBd/d32YznHZDHHYXfN5Vnd61+mgJ6+8+MDUbJ+Bbffb0nWl+hymcTbSBZTh2/l8diKceL47DSHeEKWvK3iL1Et/sdKp9bi4M0R1HH6PK4jjGyXcKkwT7B/ZQSVwW1Mz7K0fCH82nfmEoBppKbAD4ljhtCfnfg8nZ8CpYYXabh9E0YflCUYdSV/msERyzMVXolp3ag9crZ9KKTCLWLWZ4oRkazPU= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:dKW1aJvX7w+m2Jhmg8XMRyFjQR4QSJbBlpQMog9NEYkmpk7KgJ1XzbS0Zxjmtp60/ki0Ggg7jpaBVUwRQpp2mBbqxxMi/Z8XW2CqxuxwK1eP4j7+jLpU3Smq6729tSLxllboOA6G3MC46RCWbTrJiIDm5Pj3m621ALNnw9sqa+ShM661Q6ZJIxb/7BvmN4OWLivx1a+QXGN2pWdbFwImek3BgPSQSLlPTLsDjfbhvjcKEcjcI8jIxzYRZI8rpC46dETUXQez2SmUykMSWDf2iecV3WNzmdQyNvURo4GNrMxhkayvmN3RcUxn5eqEdpTDdR3mDjbH3Z5z4X4zWGtumZb8QSU7SQMAeJmr+br5MT1q9uDGQEgNqN3ngZgkanzUB9uVLbiHL0rA0c3u+gbhIaeGsZHP/AkZqeCZlBI8Ja6IBJH8hKZBOACThN4a9A2UfJh6FcifpiQhTvhiXVYXIXqEbt2O3kUoOP7vVPD07LA1wkUrp7QaQJCULBD9khjQ; 4:vyIOCd/biX//BZ/pI7/SCQx5BpNZmxx10+0y7rKWlp1JBdC5srfrpHTSTwL9NeYJ/hxA3ZeQnz5zi4o8JqSIW6HBMvJkJAZE7StCEfJagJh8DtBZD/CuknyCuzLAeXsUU38L56chErHEY8Lu9y2M0Tr/0VqJpUXct0T8HDCVvzVsj2vBIT6GrOOzJpjc4q9UUdJOJ041ersnxqRKG6cJkFzOE/lRVu55PZrpmfekDkW+0X5ZaHcyiGzvX6GS0VJe X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(107886003)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(575784001)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:6VG8z5T3UwkUtuYlGn1EkOYtnPD6RWTHOj/N0mm?= H92M1I4nuGdnY/F/L71LDg7E/QT12jhO10Z8jfO+slCst7uZgOUBr1Cvda55OqnmQa/oHxrmhU0Hv6/4UHR4bpM28SoNXxzG2viYMHWv2XrcO4o8i3+aS33THPnXLNa2MLAKUIpEeAEOav3XyXJijGj4uqosM7ALsgvkopWOXBYnvS4l7ia2TZVKEPAC9lG/vAjkT+XANohrkRS1rLL+PQWGzSgoMoOJqF6MTl92YHfUdAI0SO5oqzW7eiY6E6iiSECP79ywQE5G6dxdVja46lZROm3gwUBYzFlfikFd4Oci9z4zm33VEa00e58Vvlmyvuk9Ljlh4rbRX6k6auhlqP8RVAxutxx4j/7WN2SU0fo1/gYY6PoLmeU3AOncEGWYh0qV8ycK17DjJdwxP/gYqwU+0hUwLb9tzWaIMV8YRaSoo0kJ0MVPMh5El3giOHGbqZ5qv4okkuJjpTJg6DNzp44njCKw9EPeNLRGfzj0p8/EK2jSLlnviVYohgYIvLs6moPIr9vYovYCiBPNvDH/WNsPO+a4tulztrBRpekuAKzN+rNogEfhShDD7DWElkFdYK/8JqW5dg6U061drIV0bMAJ8k2JH9fOHfIoXpKXitz7CM7/RQWfgXNlpZW2WkiBqg+QNNQk8saVgl+KXLfFYsN5sFadKMmeHY8i+Fn1478E6jHDaD3jB8r6aX5C6LeU6sGCxZPsIkVtzyWY8IYze5Z4tnbAiMwlLeTdGNQazhqTQjOW/076Fdx5o+vQH3lnJultVjxJEtf5ivzml+IEqU6E1YOZYTxiMLZuIMouX3dLsPPYE9hP/7Tg3Sqqp1ZqBAO0GnEXjNVgQW59bxMCIFE3jIkWOTJZkicUjtd/5dFgRMDiDaViKorS9YSE9kgZsR9ozFGR6o+UeQJHG1EBQOl6lA3vYOA3POtb5qc7/nkpg6xUT2Kh1DQSA/o/n+ZTub2UL3UCzPFmyiURQuhX3hHrtP0z3kf63x5mrkTGuB1Z8xb1qZtqGJG10QMkvXQXLh35GgBBpCrXvJjVS6SzPZ7HGLK1+s15r1DNyumnjgwXm6b3dgQMhzX6yO8veM9iroXqWfS5nqjK2O/n37FSeRRTe X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:6hUIAkbI15LzTxtkKqukuhj2dDSezTfVO+uxhwl2o3W6IvWo0cIUCx6fBsRLUeKyV3olIFbnbJiFHCoynnrpAf9iiEV0qN7a9uqbfHL6vVu91sP28YWXZTwDFgaYUZsHXspk2EB+WEBVBIpLhO9+YrmEYn/0AW5tdb2C+qZ9giTd0B28qmGLOWkMjUmlBi9kNU4hr0t4fmbFAzG2gpAGCsYRAByPLof091JoQmaDXo5oc49SrxAlM3KNI9V6Wm7JWprKrHf5oAXJOZWETI7NFNVt4n2juMXuC0a4NPpdjwohxf7gbiO6gub1299FzjxUJaac6jzT8WOvb2vnzcTwhg==; 5:faR+tO31fvrllDgugd/MFr58C7xtg8uAdegRXIHZrw967C/ZPXkSkd3FwCFso4Yuek1kfYRm1AuWma+rTklA+GYmes9nwC6aqxRc+vsgZMYS8fjYiIsKF2derP308UTh+EsL/oeY/lHUqNf9QpwAyw==; 24:kV/1lM1SbtB6ZBZ5xfHzpX5ZZK46lq6CimEBeVE/wproIgVL/ETzVOwzlp3sC9JH5hX06TPY9hdGpakpQnE7AexYYlKmg/8hi1Y49zosec8=; 7:A4GKbJ19Dkb6lLJsSPTY0Pn9PQMTtqRtvsw/W86MOFnJgAs3qkoP9X/BmWnZFJou3IBOrFV/o4hwuYi3a/tA7lOGPBk8p2BWvQPVHPz97SQve6I96ug5bUV9KwrkiibId16A/RolfJ4EOd6cZF+8AQ3o/PKsyyRdMsRHoGuzYOo4RgYUdzwys0SsqK0NiyijHhSP0o3kPmbT/32yVQHz2yLBuVtlHljf43LnpRA8h1w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:10.2735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 44/53] net/qede/base: add support for driver attribute repository X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add support for driver attributes repository in MFW and base driver. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_mcp.c | 73 ++++++++++++++++++++++++++++++++++++ drivers/net/qede/base/ecore_mcp.h | 35 +++++++++++++++++ drivers/net/qede/base/mcp_public.h | 28 ++++++++++++++ 3 files changed, 136 insertions(+) diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c index 6b5d755..89c9864 100644 --- a/drivers/net/qede/base/ecore_mcp.c +++ b/drivers/net/qede/base/ecore_mcp.c @@ -3674,3 +3674,76 @@ enum _ecore_status_t ecore_mcp_set_capabilities(struct ecore_hwfn *p_hwfn, return ecore_mcp_cmd(p_hwfn, p_ptt, DRV_MSG_CODE_FEATURE_SUPPORT, features, &mcp_resp, &mcp_param); } + +enum _ecore_status_t +ecore_mcp_drv_attribute(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, + struct ecore_mcp_drv_attr *p_drv_attr) +{ + struct attribute_cmd_write_stc attr_cmd_write; + enum _attribute_commands_e mfw_attr_cmd; + struct ecore_mcp_mb_params mb_params; + enum _ecore_status_t rc; + + switch (p_drv_attr->attr_cmd) { + case ECORE_MCP_DRV_ATTR_CMD_READ: + mfw_attr_cmd = ATTRIBUTE_CMD_READ; + break; + case ECORE_MCP_DRV_ATTR_CMD_WRITE: + mfw_attr_cmd = ATTRIBUTE_CMD_WRITE; + break; + case ECORE_MCP_DRV_ATTR_CMD_READ_CLEAR: + mfw_attr_cmd = ATTRIBUTE_CMD_READ_CLEAR; + break; + case ECORE_MCP_DRV_ATTR_CMD_CLEAR: + mfw_attr_cmd = ATTRIBUTE_CMD_CLEAR; + break; + default: + DP_NOTICE(p_hwfn, false, "Unknown attribute command %d\n", + p_drv_attr->attr_cmd); + return ECORE_INVAL; + } + + OSAL_MEM_ZERO(&mb_params, sizeof(mb_params)); + mb_params.cmd = DRV_MSG_CODE_ATTRIBUTE; + SET_MFW_FIELD(mb_params.param, DRV_MB_PARAM_ATTRIBUTE_KEY, + p_drv_attr->attr_num); + SET_MFW_FIELD(mb_params.param, DRV_MB_PARAM_ATTRIBUTE_CMD, + mfw_attr_cmd); + if (p_drv_attr->attr_cmd == ECORE_MCP_DRV_ATTR_CMD_WRITE) { + OSAL_MEM_ZERO(&attr_cmd_write, sizeof(attr_cmd_write)); + attr_cmd_write.val = p_drv_attr->val; + attr_cmd_write.mask = p_drv_attr->mask; + attr_cmd_write.offset = p_drv_attr->offset; + + mb_params.p_data_src = &attr_cmd_write; + mb_params.data_src_size = sizeof(attr_cmd_write); + } + + rc = ecore_mcp_cmd_and_union(p_hwfn, p_ptt, &mb_params); + if (rc != ECORE_SUCCESS) + return rc; + + if (mb_params.mcp_resp == FW_MSG_CODE_UNSUPPORTED) { + DP_INFO(p_hwfn, + "The attribute command is not supported by the MFW\n"); + return ECORE_NOTIMPL; + } else if (mb_params.mcp_resp != FW_MSG_CODE_OK) { + DP_INFO(p_hwfn, + "Failed to send an attribute command [mcp_resp 0x%x, attr_cmd %d, attr_num %d]\n", + mb_params.mcp_resp, p_drv_attr->attr_cmd, + p_drv_attr->attr_num); + return ECORE_INVAL; + } + + DP_VERBOSE(p_hwfn, ECORE_MSG_SP, + "Attribute Command: cmd %d [mfw_cmd %d], num %d, in={val 0x%08x, mask 0x%08x, offset 0x%08x}, out={val 0x%08x}\n", + p_drv_attr->attr_cmd, mfw_attr_cmd, p_drv_attr->attr_num, + p_drv_attr->val, p_drv_attr->mask, p_drv_attr->offset, + mb_params.mcp_param); + + if (p_drv_attr->attr_cmd == ECORE_MCP_DRV_ATTR_CMD_READ || + p_drv_attr->attr_cmd == ECORE_MCP_DRV_ATTR_CMD_READ_CLEAR) + p_drv_attr->val = mb_params.mcp_param; + + return ECORE_SUCCESS; +} diff --git a/drivers/net/qede/base/ecore_mcp.h b/drivers/net/qede/base/ecore_mcp.h index 7f12a0a..875b205 100644 --- a/drivers/net/qede/base/ecore_mcp.h +++ b/drivers/net/qede/base/ecore_mcp.h @@ -521,6 +521,41 @@ enum _ecore_status_t ecore_mcp_get_capabilities(struct ecore_hwfn *p_hwfn, enum _ecore_status_t ecore_mcp_set_capabilities(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt); +enum ecore_mcp_drv_attr_cmd { + ECORE_MCP_DRV_ATTR_CMD_READ, + ECORE_MCP_DRV_ATTR_CMD_WRITE, + ECORE_MCP_DRV_ATTR_CMD_READ_CLEAR, + ECORE_MCP_DRV_ATTR_CMD_CLEAR, +}; + +struct ecore_mcp_drv_attr { + enum ecore_mcp_drv_attr_cmd attr_cmd; + u32 attr_num; + + /* R/RC - will be set with the read value + * W - should hold the required value to be written + * C - DC + */ + u32 val; + + /* W - mask/offset to be applied on the given value + * R/RC/C - DC + */ + u32 mask; + u32 offset; +}; + +/** + * @brief Handle the drivers' attributes that are kept by the MFW. + * + * @param p_hwfn + * @param p_ptt + * @param p_drv_attr + */ +enum _ecore_status_t +ecore_mcp_drv_attribute(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, + struct ecore_mcp_drv_attr *p_drv_attr); + /** * @brief Read ufp config from the shared memory. * diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h index 5153f25..e2145ab 100644 --- a/drivers/net/qede/base/mcp_public.h +++ b/drivers/net/qede/base/mcp_public.h @@ -475,6 +475,18 @@ struct dcb_dscp_map { u32 dscp_pri_map[8]; }; +/************************************** + * Attributes commands + **************************************/ + +enum _attribute_commands_e { + ATTRIBUTE_CMD_READ = 0, + ATTRIBUTE_CMD_WRITE, + ATTRIBUTE_CMD_READ_CLEAR, + ATTRIBUTE_CMD_CLEAR, + ATTRIBUTE_NUM_OF_COMMANDS +}; + /**************************************/ /* */ /* P U B L I C G L O B A L */ @@ -1149,6 +1161,12 @@ struct mdump_retain_data_stc { u32 status; }; +struct attribute_cmd_write_stc { + u32 val; + u32 mask; + u32 offset; +}; + union drv_union_data { struct mcp_mac wol_mac; /* UNLOAD_DONE */ @@ -1180,6 +1198,7 @@ struct mdump_retain_data_stc { struct load_req_stc load_req; struct load_rsp_stc load_rsp; struct mdump_retain_data_stc mdump_retain; + struct attribute_cmd_write_stc attribute_cmd_write; /* ... */ }; @@ -1414,6 +1433,8 @@ struct public_drv_mb { #define DRV_MSG_CODE_FEATURE_SUPPORT 0x00300000 /* return FW_MB_PARAM_FEATURE_SUPPORT_* */ #define DRV_MSG_CODE_GET_MFW_FEATURE_SUPPORT 0x00310000 +/* Param: [0:23] Attribute key, [24:31] Attribute sub command */ +#define DRV_MSG_CODE_ATTRIBUTE 0x00350000 #define DRV_MSG_SEQ_NUMBER_MASK 0x0000ffff @@ -1573,6 +1594,11 @@ struct public_drv_mb { #define DRV_MB_PARAM_FEATURE_SUPPORT_PORT_EEE 0x00000002 #define DRV_MB_PARAM_FEATURE_SUPPORT_FUNC_MASK 0xFFFF0000 #define DRV_MB_PARAM_FEATURE_SUPPORT_FUNC_OFFSET 16 + /* Driver attributes params */ +#define DRV_MB_PARAM_ATTRIBUTE_KEY_OFFSET 0 +#define DRV_MB_PARAM_ATTRIBUTE_KEY_MASK 0x00FFFFFF +#define DRV_MB_PARAM_ATTRIBUTE_CMD_OFFSET 24 +#define DRV_MB_PARAM_ATTRIBUTE_CMD_MASK 0xFF000000 u32 fw_mb_header; #define FW_MSG_CODE_MASK 0xffff0000 @@ -1686,6 +1712,8 @@ struct public_drv_mb { #define FW_MSG_SEQ_NUMBER_MASK 0x0000ffff +#define FW_MSG_CODE_ATTRIBUTE_INVALID_KEY 0x00020000 +#define FW_MSG_CODE_ATTRIBUTE_INVALID_CMD 0x00030000 u32 fw_mb_param; /* Resource Allocation params - MFW version support */