From patchwork Tue Sep 19 01:51:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28923 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A808D1B205; Tue, 19 Sep 2017 03:52:34 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0076.outbound.protection.outlook.com [104.47.36.76]) by dpdk.org (Postfix) with ESMTP id 1949C1B1A6 for ; Tue, 19 Sep 2017 03:52:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2FvQ7iofN0ycDEoq+W/KdPfFXand1O7PihwvqjjGK8A=; b=LxQnbioU+gyFrJz5OFCo8S6FtwN0NyMMbTaw3HTcM/l5hGKNuSnQ7Q/8K70EOGfahhY14wzRKWq684LRop45M8n5rz2rP/Ka4lvMnWhvl7pmU1v3XlkGyiYs3R6CrlYwlv9o1WWqpt0UjX35psVZ/gv6WXRo/0haEZWwVw3W/FE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:13 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:51:38 -0700 Message-Id: <1505785903-1741-19-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbed0d19-17b5-4c5a-329b-08d4ff010c80 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:tMm6Y2BNnyb+0skJpqOGpa728nPa8SBhfZ4jhIT+i8/DHtACatVOZ0iDRtryypSiKTTrmPXMBx+2C2pqX1mBwE81GmnJSTCmZOXW0lPd3oyfKqB/uvoceizcvL4jiokY+ze8omYVwEzInaU61pV/UTS30PezzdCIWWhA/+ExBuUBxlpzsj9PZZJxEphuM6HrF58O3+3pzfPS1HVvzHLTVOZxNGEcvT6sw8bgvXvr6qRxaxBC4K28r8EHzhJn5WvB; 25:nUrZlAeKYO9anu1KnEkhjoAXApRPoDfdiR0H3Q9LmlVFxE2Dniw7dIelFd8T7esfhjVbtXLe4QdJQvdz1a3Jb3A0o07jDs+C3297t+TVRhjk4AAvPXfqAJ0jBjuyGonFA8v6bKSamJeHgShKS6rcM3b6OtG20xsN1O9SnaQfMKMaiScJGuT1vPQHpK7dweTFd94oukyCt52OYe5A6/mQ64DU/edlAOJtg7W7occxjBEp2oTzRHU0TKhhlURQ99JDH1mqRlXGJOMZkaK9UIqPexZU3rRkcX0o9y8+aOS+3C7YjY3Qy5bvgCbgW2G1uP+21OvfOOvajbqJRMCI6uDXZw==; 31:JqlQ42SIwDceKzp4//Cucey+rgY4sydtx2rBfQZQe86j6JGsvyQOBewps7qg8wKjCSNPpLBhOsNbC+CjP36nADG3GBOfpD89HEgAVJd3bhl/Vq3fempzgbr7cStfXYOujvPne+Ehafvh59sp0D9/3wrSvTx103UpM2FMes0usLrNl0Fgyvv+j20707FHaiRShy/GwxPvBhJLTLv0NTSKegdbGPOKZr4CmqYnO2+63V8= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:fk1bTJ92WWwWkZB+roeItkf0Jptkhfm5eSn3sGIex7TR46Phfy4bmW9WFC40ZZa+xJMZf28HV02raR5GLESYwZTD23NR2Et5Zqwda2g6jbOtIXcWwavjpc2leauzwxD0r+ajQ+IjLgRQ+A86gEgQosuJS2yUuEFnyqR17WqjawyvIXfOGl1bIIDBLIF4tr0ARB73E5jxG68zZBeTURXZg8OyS84vry9EH1JpbC3ybisEG8V7Sm7D6aQCvslRR45WAWsJIRzbjXYlrF0CCEJq9LB01NBS5grkw7ePGbKpD2/nYHAsvWpxOJd7n9eVC3znmhx5jdCSP6II7mgyATHUDqjxFbo1BGK4dMArSDBh6G/fidMxW0JU4N3itxqpgi3Lv8XVZ1NNStpWCzehI0CyoxPnXAgqqDntkALA692xy06a3TIerHAVAxlx3L4MBDmaJIVan4xx3K5hqztixOgonccEXDw0YEDHxbLITVCqP9cM5yUZYYzTTM4zZoKzc30R; 4:vh2i67+FK5bXK40MjbwJrNem2DIqGr8MHjT4YEFawMGFrBJqjqIj0BvhAmTy3X2HWIw+8M2zbw/m+aqP3lO3IUWqMNpVQMUSsE3B+mnUe7Cl3ZzeJMn6vhV5CuhGiTQT/0CHazqZlweJXsg3AaZqrYG7TFYl8yHIZCC1qJS0aWpYmVxQ/+Nw/NLGW3+56+eDmmOYKdbGEEDxRNgcxXvHBFon29jPQARLqT83wCfPZxzkWyoRPcp2bNkNubJ9fYlK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(107886003)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:skTDmV9b22nA0Qkp92F8BEYRPjHwDROtJ0GzlbH?= 8599IdzovQ3wF5n3uTD+FRNJ92BLOg8zuXY1qdJjIRLyEZtaTlCnRkP26G6WMubSfTiCLY+uDnjSdHVKvQdcSABIbj9/Cs4jQckyt4aZsAGBi0KLzeN7t88FiJBTXYdrSNlw351e8n/ocGOFH2ydiOn291iR1kkZRTMFq1f0C1UQw455E0FI14l0smonhl08kDiuGzI5TuGQTUz5ys2+WcWVFSWSRgpYXAlX5Q855aAOvRQtH3xwVPKAS4ATZ4Ab5uvSsFLzo5zl9XxgziNbhGrzYMgwNld2p/w21ayPSCruTyGDGGYZ7aVJEKLXkmfuAf2AZXGtoXaP8dEt5SO1J6+oZvzU2vZbJyjDu3np1G2nb94vhxShot/TugbTOJPqVHduf1UhmudtzCjHjhFEGuFtuakvNpyUF9v6esDDgCMoDsMmza3cJTdGK8M7acKeofW8RZDVP1Gbbg9urlxnU6UNdfwQNVJa+OYZizIb7tuWv69sd8YAxW76qS5hyUXg2BzKlHs4mZct9F+O2ssPKJvrtT+2zs8TNrrrkI8+7nGroNbpt+d9kbQF8RwGxIhUe1KJ/HoKJhzlSIFmQOb8SpZyghjOrzRm0dNGS92Q/0C4pJecv42DPN35g1T1RKetLqDL/JEt1DkKpSqiZMpjyMiQogtQhZ3ifJm8uktTv9bgT1BwmuOlW+P/Y/VK46DCMwBuQAEaNqzcrAvzGxTMsH15RwcxtH0xVOLmJYdGMfv5jZ+Oo/Jk5e6XPkdNq8L2EGPMiu/ImKstsbzHaEnlcKo+m6ojEiudzNwzSFEuUYswmQueDWMbaCI6OKs2+rVNUzrEVCpzosvtqfBvyUbveGShMiwp62o9LvkUe+WL29PQyB1qJGTOqq52/C3IZon6BFTd4kzEvvq2lbud+pBhBaiQcSTlHGemRwSGesSLIekpKiZ3T5Y0vZMCK4JexxEQNFAhZOcxdWRMOG+CF6P5Quq5LPwH3V0iUPuDqCQghomfV1EKyuG54/YHmntlh1JxQlxVNqymIaXgRScrI7g/5Xeb4gmo+e9aTba0RFXVWY+qBeNcd22+uL9Cx7X29ACiLgAo= X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:qWy7gBaCKhdNmDmNMB0iJbIsU8kwIbqT7CR3SLYrg06GZx1Y4csHOuqq0wA32b0UuglK3m0AyIn9FNBaTgLCRUFQrPM+MMslNsHWNwIUL+dmSQZffmOF5wb6J+ttxMszSdWH6qjVsvhh5OqHSFfnc29CgZW/3DUsBYH8Hg3CLTIuCqWgmFWhzfRCPFp7lgB4yoORKM/RR10607s/UgGaFfugM+iYDhSudq+hIJGML8JVNEbnNAN/9SmX4TZCD/mttCXGau/+Xtqh7BXWPPhAhkQcfpP6gjtdopYX9vroiq1AXCpxwBkzFUWcJ+Mk1qIx8oq7Xc+k20f4h2W82L3vKw==; 5:4JqUo1OV79PDDxKqnvsIY/DbBaj1ytAj+tHoUSuQlNakwCCp2RMRUgC8EJbLPPJtQ/rmSug/s2JzzrRGZD62iXnASmBO4ymnbWbdKGJzoXDiMYPBW2JK+XI/lHXniaRDQcTaRDsU5S4B7hyINcmUxQ==; 24:UErx2GKAvRxjarDWbVu7PrR0kAH9TV5xX+Pf821m4O4zDlEGBP77OFceYDYhuxRtTHY9XkAGLaT/YBVbHwg/oHZFBfuuwLHlHd9FUvM5NIA=; 7:vgVXlCEjhn0+UvawvPRsRDoaLNmykcdSj1N0jIgg5HWBHu7wZFMqh/xS+Bw2xxlw0GpRTiD6Smy6jZMfVO5DYZmQqU0COu/FFRoQ0X/r+DySat1xJSClhigQQjNKbqxhqK6lP69pvHIrVUWQHpFXZhumx8RMpTMkoEOzDDIZi20yONcKLT144bD07IiG4fwj719/D8SMCH8m4LCABTRxHglopXDDb4f9gA+fyvqQ5CQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:13.1642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 48/53] net/qede/base: catch an init command write failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case ecore_init_rt() fails for some reason, catch the failure and fail the initialization. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_init_ops.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_init_ops.c b/drivers/net/qede/base/ecore_init_ops.c index 4491a14..91633c1 100644 --- a/drivers/net/qede/base/ecore_init_ops.c +++ b/drivers/net/qede/base/ecore_init_ops.c @@ -317,10 +317,10 @@ static enum _ecore_status_t ecore_init_cmd_wr(struct ecore_hwfn *p_hwfn, b_must_dmae, b_can_dmae); break; case INIT_SRC_RUNTIME: - ecore_init_rt(p_hwfn, p_ptt, addr, - OSAL_LE16_TO_CPU(p_cmd->args.runtime.offset), - OSAL_LE16_TO_CPU(p_cmd->args.runtime.size), - b_must_dmae); + rc = ecore_init_rt(p_hwfn, p_ptt, addr, + OSAL_LE16_TO_CPU(p_cmd->args.runtime.offset), + OSAL_LE16_TO_CPU(p_cmd->args.runtime.size), + b_must_dmae); break; }