From patchwork Tue Sep 19 01:51:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28924 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF68D1B20B; Tue, 19 Sep 2017 03:52:35 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0059.outbound.protection.outlook.com [104.47.33.59]) by dpdk.org (Postfix) with ESMTP id EE2BB1B1A6 for ; Tue, 19 Sep 2017 03:52:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Dt+7gFfCGwuSpAyqEMWjFT+zepoMlb1a7PT9jwBOJQ8=; b=PBXW/QXE9IQxAwOySNSPSFfE2bH+K2RUBTSbsljSqURq/NraL6IoBVhXgoxbp+eUAnj3FVMGshHw6A1FVDHLAnFiyny4SWYxGfFHaiSrWaAfjzes0JPhxdph9KRKgba3XqoCmEuinxRbzqSUTMmIXrT7fIkcxCBPtj1kLq3gSyo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:13 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:51:39 -0700 Message-Id: <1505785903-1741-20-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c14fa7ff-1ab8-424c-7ce0-08d4ff010ceb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:2/8jnZau3NbbyMjoSDvyFD32vTaDmyRpiUkB3yJ56evDSCN9brPdEqOGUViLiES2eao3ZW++UUSiAWU2tHWAPX56PTcBgDBCMJijHuQgNgMGsC+Mif0LZ/AYs5Yo+UBQhvTa8yMENKrkon2yTCbWpKTFhBmCPClOih/kTDlmblOCMZ68l6xJKicfK8cb5vY/bu9ovKsqKt6FZW8B5xDmDsmkYNMQcKH1XGvH/llQbm4nL2Rl2ghs+9CKDv2vme/c; 25:VIvDGoErHEdyVpi9REhfzkqZ/Hjz2xaWi0Oxj2oRarWa0yPFrgT/jJVo2QyAqG/z/q9dmMd9zWOw6pxtCpZ0Pc75+1Dbnou/oVg/xGP4CmvWGSE0CND+rO3WbZ0SBCci1q3NKBYIpsrtywe0jT+3X3tjybznPf/Tbvt+swS4f2OJzGEQytoVXH/TkHVeghZQlkGA1vZelCBK5GG0rvROVbQglq9o0rHbUA+ENTXsMqtNafJslv48KrjYxX8PFXmikJJ2Pv+qhQvS/y539V8TJFGxaDquDMPFw9EhrEDJ5HeC5xJgARIQKKhEmfzypETlCfbzBJOuPba9M2nHE3nx2A==; 31:ik5yH3NX7cXFm7YZ05oF0TxyWq5nuS6uria62y2i/Z5YsMSWTObUNgGZR8F1WqcyY94GsGVuucTRxJPf6t80nB3B3iOS7zlBPKUo+YuaD58A3r45E18vIR+uIY7W9EhQUbDuqV6DZOt+ISVXEFaMSQRatv7T0EmU1dPvOmpTRExcjz8GTBJHLrDDh3QUk+Q3yIGxTcDdMLwmEtj83DoJpBr/NaiiQsyIIGcM8wC+UTU= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:rKD08q4+UX/3OxA9vgslJuUH+ccYbKPIW9dPEch5Gf1GjS6m4AHBuQCfaHhr+6bI0xHA+1GqrEWsY4RsQOGydVNR4+pXuI40MWqYyey8xPOmwcmUFiu5VZn/m4tsKK5mkQ1zx5sHujFgQtgKYLuoVtt0jHsEHDoP5+ZGxZxRqzopGBK+SX2mHuhyB5vUqsKHvc5Tdjkh2qHhEAqISpAhLQcNZMYXSq6SpKc4oAnwled7C1QRJAfuFA75i2aO1LZq3STIPDGRcfGnd1VhQN3pIsUd+HWEFrH2/sXE6DbDkGfGv1fULL7wzxH2h/VVPDOTG56mPd02i217iYf/mkiwQsbVdGMSqKx3pACycXc0uj/opXSH8UOsEqsI3c7rQlDbUc6h6X8hcb3aff7UGbqS97hmDzk/0vmggZbWM+tC2d9ybG+yJY1QNvp1N6z2S8RAUkgWU03Tib41IJOYRCGyk0E3bq5H7bNpJvAKO7mLaqfeTaVS8W3KhRaWWZ4+VE/j; 4:IGaTh8hS8DWtEZp2pL4WSrTYAfgipaHCM0utUQxHFHUyHI208YCd5a6toN/OlPBGs3A9pKKHXhSPtOdftkHuRlOCZxoNhpN6TD5zDqApIufkmIe2ATd+Jc7CM8V2UCEG+zC68beg7+1FTGD6L9c91TVH7HgBGNaITjM0MwhlRHgLVyWr64nqDWSGFFNQPn8lT5y5OXe1EoAFDvDYmQlxhpHOxC/aivBBvMDetDdLk0prZZanCTVe1NzsCxRrcAJB X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(107886003)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:MhzausgfXZP15q62NlUd/zGDEFff8qq2tyesJGH?= eBQAEhtAVz9BcYK9XpbENargNvtiqoceAPisFH7LTudtXbTV7rktRzkOJp3Mh6XW2gVDBqb+8mnXN8KStMwx4U1ttsZVSUNgwumasOoBvOfZ6SST2clkIc+GKRkg4VmovjnPUcgsv+JIGt+fwAJSUSId78XU1IRx1E32LZCdTKrwpktisIe7Xl2bBXnfN70EqrGp4FaIVpxIkElpl8U0Qn+9ZgMK7tGzNqLBQYSidKdpllBNcC/u38TD4XVGnpP4+5Q5WhGOK3L165pldZ6SWQMfZ42R/+nhRR1ppAd+bZhPvogXZQL9pTPy8q1swUHxMkoXvHfu4ZtmA9LAxYLWiHnImldjNCs706KVsUyyEYuRogU6jLPY/kzVjW7eUby684YLQFKtp6ei8BHV20YA8Qvnq3onbiGq2laGmYitFma/YtSaGikPzP3U3zFmfLWwpzC6My+TIbQ81cBDpzF128go03aF8KapCeHRltXfreqJVQXCzqry8M4WQxIoxR4uDiq8Us5f/pgA2wWTwkKno7xllX7b4db+RF1sFpC+IUpK529EEGAZa8lyiwARgOfJMsSLNW5lZlBVG9XN3Q0I2KwDboiPFjreHhu6CFEuxNOuLLIhjuMM2ZECimgDhW6NFskzlv899DluKFcfhPXOI0jvKiyUuOFrsE339BFVKHRFU3qigQv2qyC0lJewKaKCqWUDDtfvSAz8yDtdURwprn22aiTuVisgYPmrIqvc0bCAFdm7cymsSr+oTW7KA9KNbPA7XeNFqW50L4HsuA4tUSgLZ2BpwzjSC5sXK5MwhnF5dGSJLYKGm+FaAvHm4/eFW11YGW2FkyORWky0ScF/9eIfY6nLcRDbZafqdjGu922bh4apRni3WlUs63UG+KnoHiNc3TDsAcfy+KytEh8iLZ2swVscHKbYosHcgELdruFzFCIGITii32WNeLZFBVJeuPq9zZTmwfvORMLspNTqBFKeagxnWdPgWg/H3kd+GEmAv2KJKvZU5LpL9IvuQWg4NAiXMyHb3955CGdrzhhqMmAxPZLH+OThxEyTjpRkxaZhCH1jQ0nFf8a2YFfXq7JebQJQ= X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:LEv8P77wpTHLNyW4Gw507PhtMbCrzsfSFRWf5VnWBIyPUVwOvrg4qAiPFDEQTBB6Z95Gd4gTFDf99TnYNaC6IyArPYHUYaxYWUdxE9AIUooY4SRG09OKZfaqQSVVyMUfNP1cjxh1Pi4npapx9ExSz9QUcbhnZE7vosFZuaES2vPct622jXpwrtKSWhTlMfwuQekAaOwZxGnxaCDFJqFhnUjfC7bGoYSDUwyt1MvKWP82XsWglixA65cAR3sMVpPhRrPocKhykPsZciuRd8DRpUwg2z6xYVNx9zqMvmelJJkK31cfQvFjixCpvnFk74TLOXCMY6HCS25evzmjSptDJA==; 5:YsTA6pw9+mgH+3m7tRkmENdErU6enrLA+NHQz1ZfWI6/gPXxKhdzo1XLTSqP0xdleGBmOxvs7KJMgoC8MPIXxJ9ZFlSUofFG6fGpkxTsP2+ce8yvuML2646LVOjDR+uFZF3DCguorlid5Fqk9Ya96A==; 24:mv4cexYFaFI+aa7dYmlxBIXIdnEwVMkSRCr/VKA0+TxkqTbLI9MXA87FZUR4haABaoXU7JAAfIeAqDJlg2wyAl0Au4aHd02wGzKk6xB92no=; 7:x4qQjVS4Ch8BsnWyilEEr4Inuh8zvIAu175P8rcQAeQqlZrj5XUCQTfabLfWnuJsPdFebLpybEqK0I+FlS0NufQ1K4qIGrhF22Fo3FE/4oeQeD4flLjoPwS98YhAfpkR5b9JUN5mxIkYI4woJE8aL4kUMu0WMGWIhD/HUZlJ+/l17hX/rKi6RUtfF0WdpNOSHNArNGYpGK4LFQtXPWwx5JAKixJ+tHSjOciaQ3KW5UI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:13.8829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 49/53] net/qede/base: retain dcbx config till actually applied X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Retain user dcbx configurations till the config is applied to the adapter i.e. till the negotiation completes. If base driver receives a config update before negotiation completes, then base driver merges the new config with the cached config and sends it to management FW. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 11 +++-------- drivers/net/qede/base/ecore_mcp.c | 3 +++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 54c61bf..c6274bd 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -1220,15 +1220,10 @@ enum _ecore_status_t ecore_dcbx_config_params(struct ecore_hwfn *p_hwfn, u32 resp = 0, param = 0; enum _ecore_status_t rc = ECORE_SUCCESS; - if (!hw_commit) { - OSAL_MEMCPY(&p_hwfn->p_dcbx_info->set, params, - sizeof(p_hwfn->p_dcbx_info->set)); + OSAL_MEMCPY(&p_hwfn->p_dcbx_info->set, params, + sizeof(p_hwfn->p_dcbx_info->set)); + if (!hw_commit) return ECORE_SUCCESS; - } - - /* clear set-parmas cache */ - OSAL_MEMSET(&p_hwfn->p_dcbx_info->set, 0, - sizeof(struct ecore_dcbx_set)); OSAL_MEMSET(&local_admin, 0, sizeof(local_admin)); ecore_dcbx_set_local_params(p_hwfn, &local_admin, params); diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c index 8a8670d..06e426a 100644 --- a/drivers/net/qede/base/ecore_mcp.c +++ b/drivers/net/qede/base/ecore_mcp.c @@ -1984,6 +1984,9 @@ enum _ecore_status_t ecore_mcp_handle_events(struct ecore_hwfn *p_hwfn, case MFW_DRV_MSG_DCBX_OPERATIONAL_MIB_UPDATED: ecore_dcbx_mib_update_event(p_hwfn, p_ptt, ECORE_DCBX_OPERATIONAL_MIB); + /* clear the user-config cache */ + OSAL_MEMSET(&p_hwfn->p_dcbx_info->set, 0, + sizeof(struct ecore_dcbx_set)); break; case MFW_DRV_MSG_OEM_CFG_UPDATE: ecore_mcp_handle_ufp_event(p_hwfn, p_ptt);