From patchwork Tue Sep 19 01:51:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28910 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C3481B1A0; Tue, 19 Sep 2017 03:52:12 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0070.outbound.protection.outlook.com [104.47.36.70]) by dpdk.org (Postfix) with ESMTP id AE6D61AEEB; Tue, 19 Sep 2017 03:52:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8NpEjtdKWkYQPDhm+8CvpDhj90RNh2LY3l9vfLEgvc8=; b=hBLH828U81KD0dVcf7N9/wO7Qj9otA+I+E0VvDMbaVLtEQnPgIBf/Uf371UsDeFO4gCMAqwFA5O6/eDN908QLvjzDjBnkhlHbzr0PMLqQZQ9JHUMRathyCezonxCLAtAqtouqrU7CPNlOhfoTx+CQtf+2qmlAkCbHC0jkjqEDCI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:03 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Mon, 18 Sep 2017 18:51:25 -0700 Message-Id: <1505785903-1741-6-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 82b776f9-e5a2-4699-d27e-08d4ff0106d1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:RJQZYpE6MNMyvbGEOq+EBqwwh5NksoGxHXdIrIwPZ14iaDRocLS+mPwdex7PGX8tNfEhwET7PfC/8zVlgkCKOHNWRNeaETbHPr1jTle8FK0g42qh3xqRUfO2LPIItjHYvyHLAK61V6xLPEku++ZdNpLXah5z58yzjnEFbINw50S509tv0HZZ2KRnBnVDqN6/VNLKvE+20lN82LxezfauC3fe30/DP/gw5gusNU2Y563zOo9OxrkeDKucNspna9X7; 25:nTpW9LW5iGq2JRmBCuNbkdwW8FJc9gA34UNymf38IPWcoeKMCzRx/2SZlWYQ0blcqUUG5RwugFkVa112dN1QztV6y3hC23tONUsgxl0RtAt2xO1vqSmdL3dwhEFNWseSM6CL5f4/LNOgPUQUWaqZpdjggu9iODnRqRvs/7CMnwI6tsd1Oew5IahLJ+k0nUygdQHfXPeATOrJVDw2yaYTU5gY6xIcJygoxw0tjvcIlckc0JK4x40Mc59mWoMTEOlqAoEJldHbZDx/mDgHSHjAhgwCvyNJgNsJ2atal62XC2I3ajY1sbFlMVOhVRn8EiM9LXA2R9OeTpVmvMRZQBtZCA==; 31:l2BwpVPVNlUSOX95t0dVXAj9d11vVsqVuvH/D+2/olhr7ocfeXRY0onQj7epO7f9SrKWSEPfggleGHZej2beQiMuDD+uBLt07TIA1hkJS49ofzgMJCqLR1QF2J7mnjLvbfdaSEwRHsiPiKbqfsGrMABD4aAu08Fasxttp9u250ntfi+pO8sdkzABLu3mvhoEzM1SXaYFQ76F8WgzrVp0xXECaLbkiJXjYKNMsIkioVk= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:rRmU1bjdbpLwB3ip16bVnZeZx7vOpZFX41eR5QaeUWKPkq3fMyzzQizlrtvBQNa2ctj9PR6iZbjDQnu7Lf8I0CmTqJZwffCClND1gyJo/3yEBjXDdnu3PJjrROLAfmevBOZLxaGLHCjxE3Kp5FrlHO1MfaL2C3TdTi+lSUAvjco2/MWMeHJ4t3QdWJfuOgSCEiLDx7WbqmvGMfvS4Sm8iKRyOkTB+1fETFABEJhXwuDSUokpjkYLlXkCqxbuPZ7SzHe0ceAxxp4YagGI48vJ5XBozaqolnkqm/pD/D1Zk5WTpsG3IKcIz46FYVLavnI5zOvpsxYs/bF7Y7uz2UPxTYgTlQ5LUfzjV25mtlOoU5aYRA9M3fBzZsiD1foA+usB0ZeolC4uz7pOXI8qKBzRPFZMyMkcSsNQtJ4xZNP6PETPoyvTTAxIIDmOWUsqcI8IIkQTlXd8zqhzIlAFAEN2+KmrMnDCRSXj32kL1+97ssn4eLOyxxluvU3/PZuqEXap; 4:zebOTFuGliktIO++/RMhnznGVha0pCts0b5QWAN7UyCy988fAVF9Lfy8vky5ZmeOYmtOKhE6VhFvXJHiaT9AlS+okhd/V0arethKIjlzwjHVkXOHuzY2XDUSWH+swnfs1sUGSdfTrbI85nWy8M30GsKe5ZAgo0VbCFwEBOHG6PQ+dwF3Vr4prjQoLEuVMAqG+SdwTioT63pFQdzZbRQocc51ovmptob+vi5TkQtbYXee7Q4f05AJbXAGG7J18Esp X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:z+o4Nt3yPSudyfdUzhvVddVOcwQx0Iqd8j3R1Hs?= 3FCIbfBHUlb37v+WARfzAy6s6Pf82m+yXsh3n6edggcTK41dY2Psiv9eI5giBhti0lQZDXW8dhiIDvuQ25P2Xrzc6BoCEh0d/prY2SyW74/fiqyZE/7Kp6MZxhQYtCBDMFUaz8bZ6VUNBi2Yib1tw7Pd2x4S7rFpJ9ByfH5ktuYcZEgstWi7ZrrhrtrP7EexT5rUBlfknS/uIf/5+kZek0bwlJb4WbRlq66EUKMKQzIDMQkuhTmLQfS05rEaXL+oarvU9BTx9UUeb3o+yXSmK5KNfddWynBQDyOosLhC/MEk7k4g5Fud5vms7lfYoSES2wd4D1YBJAEQ2UimKxzPBYfxdBHSIctAzoGZOMiFC5VOVxjh5Npux3+Rns6+XkczesgZClZnCJQ0sv6CYXesnh2FCF3FFEtmebb6561YZRuGytziUiz3OEfvGtch3L2iFd3o2U7rguFjRg2D58N8uOfbtn4bLj98/X+AcUzDZLL5C0Yip+ln4esaEfQ/AMQAgbtzwjjrJERVT7Mmm7Rl60SptiNUOmvTbPd6RMjyfeoLSPnF21N0X2PLRUDhrYAyrmlRcBMP1NRrpN3FetyKyQXPltyiy/rCRdLlNPcUdWgpJWwZuNxhzJyPuLC69fPZNnbfqFJsS+BRVnMGT7rs7egxjZ5AHl9gURxMh7nSoCYRhMRtWcc//6uwSiUoFEewqI/darpJurgTLjUJ1t3nX9EfaQlEGF/X/GrJsiZSdWmzc2eGBlxsPsyL3cKsVPV1H2eS5jaloZteMBB/aMexYlvhx0NPVCbrrmeZjyaFxZ6d9ZO7iQC1n85NXn0YDOmpI+OA/2WLXmo+u97lxnvzqi5nef6Y4cia8WvhSFlD1OZdjRepVoghwi02w4tSF05MJA8UBB7RI5DsftICrFsPOibsJKQwaOIKIukbmWfSE2R8AItZTIM5ir92niMecxQub+F4beUgYiN+vElGrTbOMhZVONp2yanckJIfdQPwCBAS16Isk2sV9TPMJusmqp5wpdW1MmT7jL54Sto7QKM9TDsyi0YQjNjN5C0B6TOMTl4ljCA== X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:+9t170GlSyVIsOsZizENBYF/wUyBPG69IK8dYybzifphfcPsPG/6szPnoH8ORqHwQ6gfoEekZ85lqcpIqldO27+5UVq+7+IsdAva3R5pxzBj4NRqbjdTTs41khdHce2AwxOBr/ydGjFNNOtE2zZp1s/ZnUUoJHtN7LFNSMvalWYbppU6RHSZjjsc1+2cQRZCqbcBBl2ZVRoUaOm7JZRfJhu4f+yuh863VHMuabwNEBi9Y81WIEMm8Nhwjs0tGcu3smvDl04yiQb/JLlNXmtknJ5nQG2CTgLPEEKooPGqfW4CvqsBnk+bd/xJuqfMv8wZwKtjkAm7EUAVbxe9rrE11Q==; 5:z2yhjDX3xaB+LEVSqM1dCXGPj1i/dkYyuEpJ2mHOQPh8AGoxXb1JuDKfgjV6kD5heFXpe3k5z+vkY7fqGk/NFzkaHIi8h2qdvUI4eXoziuR/SF04QnHVTGCUgatk2LvCwhLMReY7WaDDtO1Ado24ug==; 24:kVTLTnC4c9EQhy8AK7JYdPHtK/W0snxDAXajkzCGSeE1ZHnSRGW2rpbjM0LQTtdxLbkiqGB45wuZX3SrTUP9qI9dE0h3BkPGM2qkg79Pqts=; 7:DEdS1FqiDi3Q1UTZ784ttfOLIRQCyQsVXcthMgfwTvFu6j4g7WB2GPHvQU66bNsp3echHDQDyFM1TUs5kpaJNUNm53ZaBGypZ0SItfYOHPDYolV/jacj13SusFLsbsi+uzqgDJIOs+JYHm/J8/NXDQZUnmrzzFV7ultVjyNooWr/2IZp12h2PkEqn4VAGHcUX9u2b0iAB/UNLoBml9zK+eYKiya9F6PNYju2juJ6GHI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:03.5703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 35/53] net/qede/base: fix API return types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" - Turn ecore_ptt_get_hw_addr() into static - Convert ecore_dcbx_get_operational_params() to void since we don't care about the return value Fixes: 26ae839d06e9 ("qede: add DCBX support") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 6 ++---- drivers/net/qede/base/ecore_hw.c | 2 +- drivers/net/qede/base/ecore_hw.h | 9 --------- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 25ae21c..212b733 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -570,7 +570,7 @@ static bool ecore_dcbx_iwarp_tlv(struct ecore_hwfn *p_hwfn, u32 app_info_bitmap, params->remote.valid = true; } -static enum _ecore_status_t +static void ecore_dcbx_get_operational_params(struct ecore_hwfn *p_hwfn, struct ecore_dcbx_get *params) { @@ -593,7 +593,7 @@ static bool ecore_dcbx_iwarp_tlv(struct ecore_hwfn *p_hwfn, u32 app_info_bitmap, p_operational->enabled = enabled; p_operational->valid = false; DP_VERBOSE(p_hwfn, ECORE_MSG_DCB, "Dcbx is disabled\n"); - return ECORE_INVAL; + return; } p_feat = &p_hwfn->p_dcbx_info->operational.features; @@ -626,8 +626,6 @@ static bool ecore_dcbx_iwarp_tlv(struct ecore_hwfn *p_hwfn, u32 app_info_bitmap, p_operational->err = err; p_operational->enabled = enabled; p_operational->valid = true; - - return ECORE_SUCCESS; } static void ecore_dcbx_get_dscp_params(struct ecore_hwfn *p_hwfn, diff --git a/drivers/net/qede/base/ecore_hw.c b/drivers/net/qede/base/ecore_hw.c index 36457ac..d6217d8 100644 --- a/drivers/net/qede/base/ecore_hw.c +++ b/drivers/net/qede/base/ecore_hw.c @@ -136,7 +136,7 @@ void ecore_ptt_release(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) OSAL_SPIN_UNLOCK(&p_hwfn->p_ptt_pool->lock); } -u32 ecore_ptt_get_hw_addr(struct ecore_ptt *p_ptt) +static u32 ecore_ptt_get_hw_addr(struct ecore_ptt *p_ptt) { /* The HW is using DWORDS and we need to translate it to Bytes */ return OSAL_LE32_TO_CPU(p_ptt->pxp.offset) << 2; diff --git a/drivers/net/qede/base/ecore_hw.h b/drivers/net/qede/base/ecore_hw.h index 0f3e88b..392351a 100644 --- a/drivers/net/qede/base/ecore_hw.h +++ b/drivers/net/qede/base/ecore_hw.h @@ -100,15 +100,6 @@ void ecore_gtt_init(struct ecore_hwfn *p_hwfn, void ecore_ptt_pool_free(struct ecore_hwfn *p_hwfn); /** - * @brief ecore_ptt_get_hw_addr - Get PTT's GRC/HW address - * - * @param p_ptt - * - * @return u32 - */ -u32 ecore_ptt_get_hw_addr(struct ecore_ptt *p_ptt); - -/** * @brief ecore_ptt_get_bar_addr - Get PPT's external BAR address * * @param p_hwfn