From patchwork Tue Sep 19 01:51:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28912 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0E8F1B1A6; Tue, 19 Sep 2017 03:52:15 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0058.outbound.protection.outlook.com [104.47.33.58]) by dpdk.org (Postfix) with ESMTP id 87ECF1AEF5 for ; Tue, 19 Sep 2017 03:52:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=klxvZzFIp6cs2IicOCiQtdjLypGi1Yu4xUrf0B1yVzs=; b=CRpVHPRgl6vD35nI22S4rS6PiYA/h6oWKihNsEdn6lfpRR42GYvQY4KyxF0j6kRVDvvpyF5XotmOuX1J12RpbqkOG6+eENdMZGtn4f/v/hbnVdt/SnHjAIy7aBuurHnMqpKlxudf1NjrCXGNy/coS3K+vy+RVxGV4hToKhyfhic= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:05 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com Date: Mon, 18 Sep 2017 18:51:27 -0700 Message-Id: <1505785903-1741-8-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 120597c7-4358-4df7-2bb2-08d4ff0107ad X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:qFwa16WU7ynk471IHR/p0VENzvaWTYjbpecJDq9AKx0Vt6JyHcpR4xeo3Lpjnsa8/a7cs62ohEOayl19OPdRQ6aUAxog2iPE5f29ppMGC+/zHJvVbYm66XLFU516SoiziHbbtCzJB//rz3uj0OuvVcexltwLA0+PCvXfKI4C+lttB9iv4D67AMbZQ8Ngsn79kfNf0GbXjBQjT0t702SpZCB66zAgnDg+fp3kY7iP5DfG+TldQc71YIZjQH0cecue; 25:BJvTKM8n/YKrFHABSdjZBveMqruPRRU26npXVuomHJgvROEXK5FF8O7SrcqV1/6DKksiYPqbyg9nVNSBeMJa0qVUr09jbVHAahNR0xP8HEi1yNebI/d3OwkIoDQUPnhlK/9qzPg98Q2bxKAI1xQxrdZ2HcKMoWvRHW6jXpVi2GUaKkMkenXGDf9Trmi5eRuEtjRTSBgPKXwPdkFT06Vk321kpjU8eYTZZjN99uTVkBet6aerNWO3ahgCIK6FkBoO+kkKsSUYdUoy8YH9W3FICkKF9R6ZjCu4BQUVYeQ1Eq0YelikKgQWsSk0E19qCmNIaStr8uv4B5i8q2SuREZVMg==; 31:ULY2fOEpvh3ToqYtYE3hpbP1SIOuGeabCWH0fmbWEy5EkZzw2VYSZvLg7bM+m+GgMFS9rQwMYIP3E07dfC9WBy38ar8spUc9rl0fHIFTb0NuEwrikn12RI/3qSde+Df+tuEtYhpVBBjna47kYoXHaCDEfpRMUWxrTa887qnw6ORS0QKz+iumOOEm1KGv8q/lICyPg1EoZNaruaV4iuebCi5sN9Jz+R8A6XokR69LWew= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:yh7/z/WzgAvo7RrCY02MmCBWi0qAGJfUOnOImHLdIwvy4AcA1uDm+D6MsaQpONi1zM0fUOHt8Yh71uFGOyUhIS+xfpImweJDiVQMnDFWvhgpJeLRnsKRCv9Ia/HJ0vpcVCe3uh652vKA3nOjmqCPSQ0Qh9CtToQ4cIQTfM1UpuNezw0QxAT2s+bjwb0Szxuu2PKZmjwIdjO6C175Ic5dUZWiqGPGl20HAvLXAvzn/hylpi96J9OPMu2Jcq/Ytozjf4pFMP9w06wWVhPJC8juPqLRzJfexIx8Fam9VuF4IF11pAWqQWc+uETwYtx9h6Xc0lSKGRpQkj/4PRZZ9B55ghOjOfoHlowRM4VN6wh+Dal4irDRRSa9H+78a3WBG2xyP/zAuQlKYFVXjTf7GVSDr3ZrQ/Fm4QXUjd2wrSrD0+8G+u1BqRkfL/Ip2xRpOgUwUXrPwTdXO8fwd+/G7PZMBhVJ7WDlEk2Euv81LcaKwkcaa/rbVsKkG8SBKw0ivcip; 4:2xOk7Zw2Y945PRscgJdVi5FCNadih/AeEE/Z2QbyfjS1WGSTbpBkglflVaMYOtTCvG4GWrUQZeYUm/Q+3l6riRXrBRwygv3cN6iQ37la4ZlnTCQIyRA7qSPfIGHrfKDKBegCOUjma4gZvEnGvPOhG1vOtZEhLjN0BwbFKOaz/ot5KGnLtvn5+421yGwDZhCb7IWi9j81x54f+PSxNEvOIia9xmPfBffrj+TgHBmlD5qOiyxP4wVMjjmHqefAT2+4 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(107886003)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(575784001)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:vxsSt3q9wOuhPCB0OmjDcIa8UTJCtgIePQAlcyW?= OduihpMKJHzC1MAVUBnLEFIpLtuo8YXZlVyMhyqAxRPvhi2kZGDdj8+mOMPEUOc1pzmUjVae5qGzKu7MihnD9JB1POUc+QuhQYYs+7LsHgmF1rlgp9gLKVgmTnbSTx1nbT7DDWTZ5T0SqmSIVgJaaWKjlRrBHdxHKZSDMAV/wApFBNA8IGDjFAkgtE+bn2mFv92OTpeBmXMVIMxxLTdC5nCU3KKnCx0AA54cXmqtOWrWprkk7BYUkj91wEOD+h0dBnzSA7PkW16+jYAk94T+2B0ONgq0UqujnssuOBRunOjhT0ku3isDri2DgwZUB/YCpP+imnzekyfc4KbesQwYVRT+qZ2Yliiu4DWOq+WqmDfFmW1ze1CNRm36VSqwsReFQVRIDPt7XLcvQdiboJPexUBn7BQtu2yQlYZ72gej3+k68EuIcqIZnFgOVQ9Oei0qLoi1nv08lldSm1qREhMWjOhRCHbCCE2WVVJ7MMIzNNO8C/mj/EtboSYYNrJ2nbJVUTa9oMsYgF8y6cHdwBiegbTK4HXhoxA+of9Fg90AwQZwNUpKv4RqO2pIHjUzPwcVCWbCL0zxBdvgZwYfGM5lFcGRVoG+hm347xrQxSneXl4AFIv+GhW1GVsz14FA3DEdsW+Nkt5Jh9wHmAxfDZkZY7um1jH2PAPlmcArlan+Ga/QoG9YtCCMnkCPgbMpj/bVPsd2gQQocy3/EBxlt9zLNfaL2U8uhvYrgSfivk2xXBTv+nm3xjr8GIy4WBVxX3zzTQjduHZNNkL8gysnACj+OLGomVt7HxPJRhfXbqB9Qvk2UZb2hwF6clyhWYwnBBKGz6zguQZdPrB3i+Qal2MLfd79GMKfg86kScNoC9TAmApYi4lPu+kfB0xotQmUARNy8aPasRFDQS2MmAU45XlqffSS5ekedHDm08qu2RpA+OLPtx4Zb57xFCSrg48917o5aKYJApnsgNyBGjxeqaPTJN00B7er/ocm9THIpUpqI6xEMuP82J94lcicAywJ+zPyWCrWrkRbtMNHi4RtaZXrYOrDJPP9fVNh6WjPdX6kGSPQTiP7UPDgsCYP4rHF6DLcNgyo6Vm6OSBOvxSw3LqYgXjJb X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:FbMKmfXU7Cg8JGhOUn+QEVIBx+Z3jEw6lmb2MFmvju2SXcb3aVEHmQP8Hmnh399M1oHh/ZRNy5EkyKwsjgOKf9mMtky1ivSpUx9a8ZFHVGiNeOw83m6k3SzPSIJ38vAaNQ7KSdltEl9mbmreNMgNPBOaMhPIdUWEqyRCu6fB3iXePP+FMZmYD+abSkl9q/we6C6JrzSpwqMZBemBsUZTA6OFqommuEGhp7bsPScZ6O61cs6sTOdtb5X3LxstxrfrZGkgvobou4p3AkEDPzzvCOsdd4XjYyD4PaMc2xaptsZY4DutfScsiE4n5KHurbaswJCa2U0RpjsCxvEw9RNMxw==; 5:ImrI9/40Meul202PtvuCJZU8NctdtCrb68M5ZrzwzYem38slqzoYMUmF4uc5I+NAMbVJvqYYI9HGIaNqCYB60AepcGeRUhAWfwcIIW9vEnxi85kvWlIXa2EgQLGFVr/xB+OKQG27Jm63q4u3XWT1xA==; 24:P0WBf92CRMDHyQ9KsIexjspYZ4NLmDotiRqIaDzgWPQgQF2vcERPFtJQIEeOcKl1p+dHZVQludET1MkutnQHKVur+iNo+7Gjp4CY1n9OTGQ=; 7:jbdJvdXFMFPJd/SsZGTa3rxHFYX0KMQgfuyD1LabCZ9uyah+IIzCl25Kb/Mb+SvFvvPP5LAGLKMHtFfGXVm6PCicZLEz+42uK+TGhuRI0VizbOJewLoHFlms0v0u6b2avXn6T95Xk/xJgS/6KfSyaqn8JOnE+7uB/riRXdJG6dGMB26nsHBSMbZZQG34aunIz4o/SMmVjzhcn/HkcP/3mwwsXn6SANRKMCDDHW1qHYs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:05.0703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 37/53] net/qede/base: handle the error condition properly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If for some reason the send message from VF to PF times out, don't bail out right away without taking proper cleanup action. The goto statement calls ecore_vf_pf_req_end() which will unlock the mutex previously held. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_vf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_vf.c b/drivers/net/qede/base/ecore_vf.c index 97ed0b7..e84f97a 100644 --- a/drivers/net/qede/base/ecore_vf.c +++ b/drivers/net/qede/base/ecore_vf.c @@ -237,10 +237,8 @@ static enum _ecore_status_t ecore_vf_pf_acquire(struct ecore_hwfn *p_hwfn) /* send acquire request */ rc = ecore_send_msg2pf(p_hwfn, &resp->hdr.status, sizeof(*resp)); - - /* PF timeout */ - if (rc) - return rc; + if (rc != ECORE_SUCCESS) + goto exit; /* copy acquire response from buffer to p_hwfn */ OSAL_MEMCPY(&p_iov->acquire_resp,