diff mbox

[dpdk-dev] eventdev: use new event enqueue in Rx adapter

Message ID 1507833953-4396-1-git-send-email-pbhagavatula@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Pavan Nikhilesh Oct. 12, 2017, 6:45 p.m. UTC 
  When event Rx adapter uses software based packet transfer, event op is
always RTE_EVENT_OP_NEW.
By using rte_event_enqueue_new_burst API the underlying event devices
driver can use it as a hint to optimize enqueue operation if possible.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rao, Nikhil Oct. 14, 2017, 2:48 a.m. UTC | #1 
On 10/13/2017 12:15 AM, Pavan Nikhilesh wrote:
> When event Rx adapter uses software based packet transfer, event op is
> always RTE_EVENT_OP_NEW.
> By using rte_event_enqueue_new_burst API the underlying event devices
> driver can use it as a hint to optimize enqueue operation if possible.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>   lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 1e42dde..fcba18d 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -392,7 +392,7 @@ flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
>   	    &rx_adapter->event_enqueue_buffer;
>   	struct rte_event_eth_rx_adapter_stats *stats = &rx_adapter->stats;
>   
> -	uint16_t n = rte_event_enqueue_burst(rx_adapter->eventdev_id,
> +	uint16_t n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
>   					rx_adapter->event_port_id,
>   					buf->events,
>   					buf->count);
> 

Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
Jerin Jacob Oct. 16, 2017, 11:35 a.m. UTC | #2 
-----Original Message-----
> Date: Sat, 14 Oct 2017 08:18:42 +0530
> From: "Rao, Nikhil" <nikhil.rao@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
>  jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: Re: [PATCH] eventdev: use new event enqueue in Rx adapter
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.3.0
> 
> On 10/13/2017 12:15 AM, Pavan Nikhilesh wrote:
> > When event Rx adapter uses software based packet transfer, event op is
> > always RTE_EVENT_OP_NEW.
> > By using rte_event_enqueue_new_burst API the underlying event devices
> > driver can use it as a hint to optimize enqueue operation if possible.
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >   lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> > index 1e42dde..fcba18d 100644
> > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> > @@ -392,7 +392,7 @@ flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
> >   	    &rx_adapter->event_enqueue_buffer;
> >   	struct rte_event_eth_rx_adapter_stats *stats = &rx_adapter->stats;
> > -	uint16_t n = rte_event_enqueue_burst(rx_adapter->eventdev_id,
> > +	uint16_t n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
> >   					rx_adapter->event_port_id,
> >   					buf->events,
> >   					buf->count);
> > 
> 
> Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.
diff mbox

Patch

diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 1e42dde..fcba18d 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -392,7 +392,7 @@  flush_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter)
 	    &rx_adapter->event_enqueue_buffer;
 	struct rte_event_eth_rx_adapter_stats *stats = &rx_adapter->stats;
 
-	uint16_t n = rte_event_enqueue_burst(rx_adapter->eventdev_id,
+	uint16_t n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
 					rx_adapter->event_port_id,
 					buf->events,
 					buf->count);