From patchwork Sat Oct 21 20:54:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 30659 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 213F91B31D; Sat, 21 Oct 2017 22:55:03 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0088.outbound.protection.outlook.com [104.47.1.88]) by dpdk.org (Postfix) with ESMTP id BCE861B300 for ; Sat, 21 Oct 2017 22:55:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NaRl+KaH2OlEcpTrVCebdHSwB2T4NFEZg0BvJL21noc=; b=hnHB5/EsRabX4m6DVjF/P2HX3Tgk8uN7ia0Vv3YbLs3tM7NcLQxhKlVNqu/E5/imF4XWVXB2xPgV9kiFtd0YyDZFMtxNpC1lCpx3sPeN6WOA86rxNR3me0Anji1jmv6tH++YwuWt4zDl2FS4HGR8/MUYXjE+XuKrrzJXNdJ3shI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0502MB3048.eurprd05.prod.outlook.com (10.172.250.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 21 Oct 2017 20:55:00 +0000 From: Matan Azrad To: Gaetan Rivet Cc: dev@dpdk.org Date: Sat, 21 Oct 2017 20:54:45 +0000 Message-Id: <1508619286-7096-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1508423514-28557-1-git-send-email-matan@mellanox.com> References: <1508423514-28557-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: AM5PR0502CA0021.eurprd05.prod.outlook.com (10.175.37.159) To DB6PR0502MB3048.eurprd05.prod.outlook.com (10.172.250.136) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 312ee3ac-743b-4ad0-1d77-08d518c5fed5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:DB6PR0502MB3048; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 3:tDwQy7qbEjAGPnwlPjH6cN9e4Icq+7mA+F4ZYgx97uXD0r2FQqvboMIdbA9tW0B3hPE+zZvBHgS4laTA5qd9L9Ifa4sJjo+WbaWDfi5leOqSe0P2IwKvpj9y0iSB99XS4dAq7855PYMfHJFQ4LCWsBZCdpcoiqWDThEk1RtIJ8jrWczfmmtiw0fh/9/mnVCTRXHu+xhUCn2K5Wom9UbcI6bQe32nN32vbyPJFi74poX+ioI7m47RwCtvVY0pwJpR; 25:5bcLL1Q2AmDE1QCBVM/vw1AZ+EnWrzYA76CfCJC9WKu1OzvTGgNbKKO/40lkEj48+OnNGrY8p4gwOsee2uJweOfWUtDKU4eNGNGSwD3/KvxaM9l8qY/n6MTjnovC/mPfzv5us1Xcf3EgkUMTg8Rc1vlZ8B+02yXVjYHbQoehM+syZ7XTtMdWj2RNruYFlQVXgrfKzgzCQzkX0CYQNy4aOBuKDWrduaWNT/SXlACs/S/Aw2Ofp0TpD8xsEUmRQb14TAl3RP8787lC6ii1LdAIpjSzHvVwYp+Kj0Gc/jMbgH7/UHq2ezJu5jZYwcjyocvRNSB8uI9aXUtUI4HPTbYDLw==; 31:KZTu5ZSk2oSHUVfuqVV65UbrBZUYRi17GfDQvXCoHP8yjHa7Hayrosy2iI5dOo14YCJCU3ilsmZKRvXlszwvb0T5BwJjqdNjWlkqB6N3IHwy/Z3i7LRc6nXweyFW4pKYNEjl9TkJDLr7n16v68Ea3OPOmODTXzWMieUrVDgJxLjsAkTPsCTjuSdIv9II8Z6KmBYUGjsM+PElfg91Npao1AzzHxtimYlBeLfKc7zr3ZE= X-MS-TrafficTypeDiagnostic: DB6PR0502MB3048: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 20:O0IQ/nT+JVYC54zEHkmRV6B+NPQkp8U3TiZA2CPoCI9+JEZwQxvJFrO1BnSn8D5v/QQ+CnQXzJrbdroaDx1Y0uJU0TRdHBwkrNTjIl5UTcg5xgh5z0G3oD5HIC1t1FRMfchorYNNLiHEbxJLeelpxq58y1472bYHM56Rzr5YQN+Y6VK3kbHwB+Jm+Nr1cVCRosRzilm9DCT89IBzru2FA08iyNloIsSzgec7llDT1HbTTx/bQDpDgJrx6/1X76+/VAHDShiHp04VPFW7YH7j3EkumrHFnoTa88VZ0dYrBb4tDeRF2LcPhrY85xg4ut+LwuqLYx+YV9xLGNEu8E6SiDlMTjUwqizGjz4Ikk763t394u32oFDeMwfwelq0JuLmJqUvMjSa8mF0VXIeW0qO7HHQT3N8qSzl9tf0GNizaXSpCSLIQC2b2b0wqf3oqaOxjbjqlZzjIgWm0hInwxiJF9z5M8YSBq/9CctTaONKLh3tPu8BDx63/X9GP8BNFGyK; 4:YVaz8luXbKJWVLT8qAur5ynJPm7aTKlzv/z+Xcxy3+yxzlQHpt5TMYaO+HybYiIenWQE5Z28Lc+8P5mO7eDRS8T4cbhLtFcgeR6yYQEAHUpiQaWNyx1MkbhFZZMrPcK4SV/PSULCiNgQlvrQPDhiTW1CHVvVyXrb1+d9mkEw33kqTX2AaSgFFcncLhIrEViLO7cFTdEcbLuLkUZnveJ73Dvu5GjhUuxkhNNIxBR6rMdhzHredMGKby6jwQVrKxnGA+8yGzbf5jJZ7TL+0MPnk76FK7H2M9omM+XWfV9Qr8A= X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231020)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB3048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB3048; X-Forefront-PRVS: 046753C63C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(346002)(376002)(199003)(189002)(4326008)(21086003)(7736002)(305945005)(68736007)(105586002)(478600001)(97736004)(33646002)(69596002)(55016002)(50986999)(36756003)(6116002)(3846002)(76176999)(81156014)(81166006)(8676002)(33026002)(5003940100001)(53936002)(101416001)(2906002)(8936002)(106356001)(25786009)(47776003)(50466002)(6916009)(2950100002)(16526018)(50226002)(48376002)(16586007)(6666003)(189998001)(5660300001)(316002)(66066001)(4720700003)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB3048; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0502MB3048; 23:36LLQdR7pCBsbdImJrqz7q+oCFYEj/rPU8AC4Nl?= UPvxHm+thwxKtADLBixGhuLvzXYCDx9E8QQTpWXtp+jDU6cD+MeLCUWfCrT03+1KcdRDithOJbJWsYZzIONTsmcREr2izVMARvJt8C1NxrCiUic8YANNBxvTsHZxhyYX62981ovuIHmNC/IjJ1qMXqUUWUaEt3zwW69XOJskgbZdnDlyV+drt2j2yh65RLktG4PLVMCMsQLUntGWUjr+4LA627MmJufBcvPZCjEjyPpXguiz4wIIQ2lajaXe1428hP0GROMHZPszu6gZSMvDk/Q2RhvjNHyX/gQN8cCody2NiIkHh+Rk9N5MiUkpBx0H4+UEwlhDzsesBymXpOgSTQT+c/urSpOwKJdgSSfaRGYzkmLaNx8TVUC3u9BawSTIL2B05nofgFLeDwO27gntcfDBTn6iwyGmjI/L60xj804pnqkACESQXKu7503USoO8Sc8dsJrpguMHB2/88Irr6lXmyGQiuvuBTF2nyIPbk+rzemELSymEFYHnGgXd1Jd7bKc/oPV/8bfUFgrMdb5YNi2NOihvCLnitCNzB9DDb4GrPrnk5ZEN9GbRTavBMlPq9wpbhTILBaBxqS6PuzqOkNu2l5+pWvkLQSfnN8Kg0PZPISdooyGoLipit0GfK7PX8El0fLq579y7KvCbjGO4eKkh9q+HbKlVwk5BekTxh9IMX/TLJVh5YV/LhZ4Uh/E9tu5uNsvehRBifm0n0zscHizOrrgn9Btdv0Se4/plYMH39U+PIUy83gLjl4tXLqaNU48ltJzhh/N+TgbV5kP+N33Dt75mEXT4QuZxjgJ2/OeHv7KXeOKXCvwW43qkKEAlb1UaI+hgyWP/040K59cP/EPcM1gfI6U2S6bOInxYDXvpGLhPybNFoo3VR8zPutj89hl1emI1vOtfA8EV064gYSCgOuDHUgEKXMQNEyo6g6Ny2mJGC36RGzQjxdBcVNFklanWfVRgXmSI+aWGy1qLougbRXmMzhxY60DwurPfqzAYupIuZqro9QUlYuaJCpH2FHp8LH8SPngMlOozCxFyx01S2+MVcTKkwoijoYEhmiWEaEdDnyMuwBU4Nh+dCTK/ZJN5n50KiIyRwOpfovXk+27uL X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 6:gv0jV0oNWpslAloo6wo3/XXYq040xNuflMcYqTZGOvTNK3sqelQ5aPc+qBbgqIW/lqKP/ESQWupB7BbFnwACbhzfUozok1E8z+XC2TGj0joHDsnRGGqbxinnuiaySjj+0fZBn8zB8Jh6djcy3SMAKJ7O089vRlUaQUpgS7ZwnkoPZ0cSDv16f6haZ8PqCIJYl+fXh2TB6eQTAOUzyDbQHn7KgsPFLfeN9L1wRASxcueRRar7LLxkLBrpilytZrlTN9uFWYxLBthlCBPBqH8XowJYAhDxdvXmDZrEK8zge2j7s+4NMKkfjvddxoZK6pihhCj8g8dej6tZsASViiJuag==; 5:EN/MvI/FlkTa3tbOkhuOG3EuBLRycxjVlltX8SWOGEaiZ0iJ/mJ+49bBpcEzHqvF2gJc1rkDjnvCib0bWXvJLymZA65aa2d1vnOYaHvOjFRGmhiXDMFf+qK/UmIp/Sy2Vlb6R95EBQd4FzCO7rHzjQ==; 24:ewpgru6DClrAL/1nFt77k6lSOkp5xrj8cOG03NStmdoeeLqU1O/39yjDrb1lwLNV1ZoZtuAsOloORuuAoW9X8Uv6j2forRVijHnwNozmwWU=; 7:OLoURtr8m/Hi4MPqq6csmLw+P1Y4Uw3hVQqj3Q80NIXJZptPSHJAA22Tu7MJVS9TwrWjgPNOyc9nV05tGiQAbXCIH/aMP8y9oGSEKe1CBKObL8IhaXw4F+QehALVi3JKno95S1S1sgN/sufp9ScNq9Y9NuEnKwwMdX5iaJH0EhDCfYYiDcFhM+e1gDG/tvBx8wPJvjKS7YBp5dBgQwxqNGDWKl1tonBJgy9PrPIuNdg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2017 20:55:00.0640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB3048 Subject: [dpdk-dev] [PATCH v3 1/2] net/failsafe: improve stats accuracy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The stats_get API was changed to signal a potential failure to read stats. Furthermore, some PMDs are able to provide statistics even after a removal event occurred. Considering this, the fail-safe can try to access the latest statistics of a PMD to improve statistics accuracy. Attempt an ultimate statistics read on removal time; if that fails, use the latest recorded snapshot. Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) V2: Improve commit message. Add warning massage when using stats snapshot. Add time report from last snapshot. V3: Separate patch. Replace "cycles" by "timestamp". diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c index f4db423..0282891 100644 --- a/drivers/net/failsafe/failsafe_ether.c +++ b/drivers/net/failsafe/failsafe_ether.c @@ -312,8 +312,16 @@ static void fs_dev_stats_save(struct sub_device *sdev) { + struct rte_eth_stats stats; + int err; + + /* Attempt to read current stats. */ + err = rte_eth_stats_get(PORT_ID(sdev), &stats); + if (err) + WARN("Could not access latest statistics from sub-device %d," + " using latest snapshot.\n", SUB_ID(sdev)); failsafe_stats_increment(&PRIV(sdev->fs_dev)->stats_accumulator, - &sdev->stats_snapshot); + err ? &sdev->stats_snapshot : &stats); memset(&sdev->stats_snapshot, 0, sizeof(struct rte_eth_stats)); }