From patchwork Sun Oct 22 17:15:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moti Haimovsky X-Patchwork-Id: 30678 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 994551B37E; Sun, 22 Oct 2017 19:16:31 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00046.outbound.protection.outlook.com [40.107.0.46]) by dpdk.org (Postfix) with ESMTP id 1C7F91B37D for ; Sun, 22 Oct 2017 19:16:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EJYYKyfnHnxq1JTTpFFAdW7OTKYVtmtsAWRckGAGK70=; b=c9kcAaWCsPLskNDUZQiBuMwKW7+218lD5I817mmZd0v8119B1zXSiMqDHJXDDj38TB2KahXE6DwtNuD1ckPGmC+et/zh/mBEFupYVHSyxrvvAv9zJ0B/n1nZ1ctGf1oS6ZZtJHS+71d63kXcXnotelLWlxxo+YA+9NBTW+pNoUo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM4PR05MB1905.eurprd05.prod.outlook.com (2603:10a6:200:15::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sun, 22 Oct 2017 17:16:27 +0000 From: Moti Haimovsky To: adrien.mazarguil@6wind.com Cc: dev@dpdk.org, Moti Haimovsky Date: Sun, 22 Oct 2017 20:15:20 +0300 Message-Id: <1508692520-104960-2-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0116.eurprd08.prod.outlook.com (2603:10a6:800:d4::18) To AM4PR05MB1905.eurprd05.prod.outlook.com (2603:10a6:200:15::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 449ef3e6-ea0d-4bfe-99b8-08d51970a1cd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(48565401081)(2017052603199); SRVR:AM4PR05MB1905; X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB1905; 3:K3A28RaJ1+/pq/lqi9AkejNxuR6dRTS6IrfgxMcTUjNFtwacZAy6036z1E/pXnGbWSHw8F17N7FKWPDjCkJe7gZpceD2RfvvM+NXtxUKU76cZCAhpxDAVHUHW3YaCR2NJXfCY3BGBOatbBlu9jX6J2wfFyXNY2a+JITsoHqDJLPUX5KyywqF04ZmxeRngc0NrbwVg3ZJdZkwIQog4LJhTZw7CoYgQFjmDYN0zVjfoBVUdD6K+LEfBKlDiHXD6Dsg; 25:lwuiziF5UMyOIwpee6NbKvIL/uY+TjfOj/pF+rKJxMfzhCX2LvYeNz7E9QsU3W32JncxFTV1zld5VJX/wGo8qnzuZwJLGWiHPh+JAtd2NN2O3yWk5zBhyCh3qA8iqTFwT08kIOEVhkRGpwX232DiFygFC4UPk5JW9VQAUjnz7ZPAcHqrUMjoGsSDiocVQNtOp35EkZ+5Hfg/X9Gs3lh6EI7jtafKpNHeJJCiUEaBs77WiDUbXhUIKK57rDm9rT3NuqOBpvs/ImZwYPXV6Vi2ak8YmkUw1z2v3N3hlvcKOoP8kr0NlA43YhdnUbAwf/3ZPqXHAhxUe3Z3HG8PPv1vVA==; 31:h6UHQ8B2gqyEvr2/JpWypjGkh5dEHKMByoAQNLOdbSJI2Zj0Gs1+4RJoUyXh9IizFSuxSprgKDmbD2C41507Ux2R/CSOsPacLMCCo07ShManVijH8Rqo8ja1RQd3phVbFwdEbaN7vUxpFLY8zWE4jgi9Gch9p3QE9+vH13dWFLRxAWg4rKiqnQGOSWZV/0XRhq1roljL/D3wfrVIqL4kacMH7CokzTd+dpCVMaiXwMA= X-MS-TrafficTypeDiagnostic: AM4PR05MB1905: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB1905; 20:4QAsBg2bAUsQiKH/5ehGuMKe47RmbDmPwvJLAZLJD+rRt0F4bUu3luGf5h6Bp9BWGoLjlsw+/zPEocrr1o3smYcpKcGfD33eppg7li/39Ir4vo90ZGpuHSO4Oa/j6TA3JKQFZKnf4PgIKcK1c4UxZsTLEovyO8iYhH2IcHEeddl73e49JdKUWSOK36KlrVzpmnBYGs7oTM+lpTfzf4fWxsXR2cIGQbcCHP2QCFv01UB8OTY9aGkh919Er6ZaVTQEb1ucYs0V4e76F7GYB3MSIqKTGVIQsRuOuxAHunNeIXg2uqNJE+Iigs7+mQMdQ0Ln/nHw14A1Gu+qId6cFjQ2OM+eTOrNiAVuI34VWQYjBZ/ONKuXZlSu/Aj0aAavYyZcnNKbiYMwqIWPGYDcZREnrTow2d/UECsgU5lYHZ/cyP9YsHwVBIFdLKf49I9fB2BiFX4DpoyxZ0MVgg/DbBYFbs51UNGa2ugckLAYa5zpMYTI+6KmMKRimxt7k4WSs6GM; 4:K1e7kFy+GPpjIqYORX82cJq6zkWyOzhfdAki97KBX9Gu2GmhMNwr5ciJ3V8UzZuKqIH//6yU2w9t3pyKoRJus7xK95tqMgLn7bHOt65buwp4PoYYiVQyeMbeuPlTID8dtOzvREtomHiPabqsor3exYuFVHpSGSgmddyq4RZ95jhKiixpE7+Hi+2JRQcz19wT/yIZmDsn7XbOhHPhUcxFMLtTGsAuMZxfSPoPcWUG1XRsGLeveTi7JGfjpHzYrwBY X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231020)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR05MB1905; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR05MB1905; X-Forefront-PRVS: 0468FE4A2B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(199003)(189002)(8676002)(55016002)(33646002)(33026002)(97736004)(81166006)(81156014)(16526018)(16586007)(6666003)(68736007)(316002)(305945005)(25786009)(7736002)(50466002)(53936002)(2351001)(5003940100001)(48376002)(8936002)(50226002)(2361001)(6916009)(50986999)(106356001)(21086003)(4326008)(2906002)(101416001)(105586002)(5660300001)(86362001)(69596002)(107886003)(36756003)(47776003)(66066001)(3846002)(478600001)(6116002)(4720700003)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1905; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR05MB1905; 23:CdiOG2RqyJBOqeJOySEq7Jj7bZUI5F0i+6zYVfOmQ?= UFLQ4LJtEUZHbSpIjhCedvM92LoI8FZJ5WIkZe6NPQRnE1LiixZqjFpy5pMCFz/z3pqmYVwTQWSo+Rs+Mnar5oiB3ZwNTbEJLUl6ttXqp5zKWboaNnmq5EIeBGWjXIOBQ1sFYEIjnbgxCHqFHfvOUMu+2J4czE1MCUcG/Pexn3yh8D2GuDUIV+GgPtWCiUP2HlByNQKQqtTbC4I8fYgs3HBaIRZRNov6GkqZfdKBY5c60hOmhyJL6FIq47Qk21M26ccAxQVnvu+16UecyLQIs7HlezXJjhocxMdSuLzJviiWVB2p88rwvFk9ASWraU8dpuXHpxvKlhRCBIAGwSXMqZK/3y+XGB3pNMPi1VL6b6wtnnv8MYJekQwUwbFIcVG2WRzcIz0djIHansv2oWXUUxaIhC30o2gDj+KzZ4OhOepo/ta44t8npNl2E9AsBDUNcbFYtT6au9GmkiQT37v8MUM54TA5J/EhjkU4K4qPOVC2EU+A/FuiNJsSu/yNt0FmHMHGA9rs5LsApgMZDCUOD6fB0N6k0NuiqrAeVml6vzl3OAMVzX9pLz/zyzIzDruWSFa+wYYhgG90foXV8Afz0gpAgXrE2HnLHSIR9bY4lyBBo8RDmXrHVmq5dXnXeOdO+UNat4YMT4aEd6g7ql8UP7IbhQ6CqmgNbOmKPu3AMQsRpaQFq3yfXpB+Bt07jCuHxDNXSUeGPWFrpIIGVbbS92GRONhe4KZRXrlYvXaKJBuqA2MNnfgX3980aoA6HZtiip0FfpwQY00yyU0NQdoGZoTOWkmC/wmVSImoX2p0ClmnANghBB9wnjSJDL87RtbGdOuFHGp9zbqatsOcDmAfkYTJSicKxoe+0g1nNuWjBtDNWO2R2ThAAuBipxPHFS2QG/lkMT9UhJ7PWRhvUjqWLnblCWTL2LQYu3yvWZkkQBXFVYkbYR6SM3RZGHwffq7c0HDLFT0L32IUJNlG0olYqdyobu7ZwU/o+OpUWHfWnt5O1ryOZaCsr2kMvzP5n/wL2dnisNNjb+4cXFLNARmkRz3RBQrEAnCcfCMIWcd73OqA9brHWLwyJijdkAU8vKt8LF4VxQKxe7BbPJtcnKUL43HplzomaCpvITnoi78k8fFRA== X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB1905; 6:WwBaS1CWFJZ3cawSiXlqK5lgTQPt6vY9nnoNVX8j3uKuaRk+XXvCVLREo+Ma8WhOC9DhJFjPPVqM45ohJ1rqP8HzxXNDsYmhyVmvVIEGRlwul0dyFq0BFPECxiOckSJR11Kx4ylHgMdsUnPMXhWlpZ8ZVPCfLe4zl+3jqYh0HKuWhxihXf6Y8p5qqb63mMPm5+ssbrov2zQZsJgRendgM+DIpR6u/84UBET9Za0vIzeErcxsXe95WpnHxeGlrrl7T4qFPEE8Sd5+KIyUtAaWQrHpdW+7UksFjIDKw9SkmsHNVhLeotHH6YswTaRuFnGCK2bvJl8oZl1eS2a1Jw5sPg==; 5:0PVEkp0eQYAaW4y66Tw33yo0bpuXLjvRfhihx/9upOwegICylvSGKKRaX4D1/vCKahA24DfA8TCJxaSxx6KwdUiN9t8+egPDd5+ns6/SCaKqSkNMOFOSUsGiDMko0MROpQb792voPw/fJoRyAYs6zQ==; 24:lpWIUSZBP7XF3S33MKQ5JuOJiVHAoOENtYBwEHn/h0lmiFLy48cpUzpl+l0POzt4exmgC23c7iCWaO+nxLB2VV2wGzeXEr/XnLC9U4evkJo=; 7:4wnSYoEEaM0Ir3J0yW5ucF88iOL4dvYijtRtNeB3Vrj686r01mMX2M7n6o8iuuYvB/gcLdup6/02WEj6OOearA5M06wYbeBzivnxMl2GMuhNHexMn3L64iAyABAlmHc0PSq52EMJATbo+uo6y/V6IApn+9zbVsL7NJF/bfIoOVTxHmSSaOMVWTtucWhouESS39nBobwv0Pyne6tQ0dA0C8lIvosF5mFJdkND7JD00uo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2017 17:16:27.7711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1905 Subject: [dpdk-dev] [PATCH v1] net/mlx4: fix no Rx interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit addresses the issue of rx interrupts support with the new Rx datapath introduced in DPDK version 17.11. In order to generate an Rx interrupt an event queue is armed with the consumer index of the Rx completion queue. Since version 17.11 this index is handled by the PMD so it is now the responsibility of the PMD to write this value when enabling Rx interrupts. Fixes: 6681b845034c ("net/mlx4: add Rx bypassing Verbs") Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_intr.c | 38 +++++++++++++++++++++++++++++++++++++- drivers/net/mlx4/mlx4_prm.h | 9 +++++++++ drivers/net/mlx4/mlx4_rxq.c | 6 +++++- 3 files changed, 51 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_intr.c b/drivers/net/mlx4/mlx4_intr.c index 3806322..217c591 100644 --- a/drivers/net/mlx4/mlx4_intr.c +++ b/drivers/net/mlx4/mlx4_intr.c @@ -53,6 +53,7 @@ #include #include #include +#include #include #include "mlx4.h" @@ -239,6 +240,40 @@ } /** + * MLX4 CQ notification . + * + * @param rxq + * Pointer to receive queue structure. + * @param solicited + * Is request solicited or not. + * + * @return + * Always 0. + */ +static int +mlx4_arm_cq(struct rxq *rxq, int solicited) +{ + struct mlx4_cq *cq = &rxq->mcq; + uint64_t doorbell; + uint32_t sn = cq->arm_sn & MLX4_CQ_DB_GEQ_N_MASK; + uint32_t ci = cq->cons_index & MLX4_CQ_DB_CI_MASK; + uint32_t cmd = solicited ? MLX4_CQ_DB_REQ_NOT_SOL : MLX4_CQ_DB_REQ_NOT; + void *cq_db_reg = (char *)cq->cq_uar + MLX4_CQ_DOORBELL; + + *cq->arm_db = rte_cpu_to_be_32(sn << 28 | cmd | ci); + /* + * Make sure that the doorbell record in host memory is + * written before ringing the doorbell via PCI MMIO. + */ + rte_wmb(); + doorbell = sn << 28 | cmd | cq->cqn; + doorbell <<= 32; + doorbell |= ci; + rte_write64(rte_cpu_to_be_64(doorbell), cq_db_reg); + return 0; +} + +/** * Uninstall interrupt handler. * * @param priv @@ -333,6 +368,7 @@ WARN("unable to disable interrupt on rx queue %d", idx); } else { + rxq->mcq.arm_sn++; ibv_ack_cq_events(rxq->cq, 1); } return -ret; @@ -358,7 +394,7 @@ if (!rxq || !rxq->channel) ret = EINVAL; else - ret = ibv_req_notify_cq(rxq->cq, 0); + ret = mlx4_arm_cq(rxq, 0); if (ret) { rte_errno = ret; WARN("unable to arm interrupt on rx queue %d", idx); diff --git a/drivers/net/mlx4/mlx4_prm.h b/drivers/net/mlx4/mlx4_prm.h index 3a77502..92f2fec 100644 --- a/drivers/net/mlx4/mlx4_prm.h +++ b/drivers/net/mlx4/mlx4_prm.h @@ -78,6 +78,11 @@ enum { MLX4_CQE_L2_TUNNEL_IPOK = (int)(1u << 31), }; +/* Completion queue events, numbers and masks. */ +#define MLX4_CQ_DB_GEQ_N_MASK 0x3 +#define MLX4_CQ_DB_CI_MASK 0xffffff +#define MLX4_CQ_DOORBELL 0x20 + /* Send queue information. */ struct mlx4_sq { uint8_t *buf; /**< SQ buffer. */ @@ -100,6 +105,10 @@ struct mlx4_cq { uint32_t cqe_64:1; /**< CQ entry size is 64 bytes. */ uint32_t cons_index; /**< Last queue entry that was handled. */ uint32_t *set_ci_db; /**< Pointer to the completion queue doorbell. */ + uint32_t *arm_db; /**< Pointer to doorbell for arming Rx events. */ + int arm_sn; /**< Rx event counter. */ + void *cq_uar; /**< CQ user access region. */ + uint32_t cqn; /**< CQ number. */ }; /** diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c index 6fa48bc..570cf32 100644 --- a/drivers/net/mlx4/mlx4_rxq.c +++ b/drivers/net/mlx4/mlx4_rxq.c @@ -404,7 +404,7 @@ void mlx4_rss_detach(struct mlx4_rss *rss) struct priv *priv = dev->data->dev_private; struct mlx4dv_obj mlxdv; struct mlx4dv_rwq dv_rwq; - struct mlx4dv_cq dv_cq; + struct mlx4dv_cq dv_cq = { .comp_mask = MLX4DV_CQ_MASK_UAR, }; uint32_t mb_len = rte_pktmbuf_data_room_size(mp); struct rte_mbuf *(*elts)[rte_align32pow2(desc)]; struct rte_flow_error error; @@ -601,6 +601,10 @@ void mlx4_rss_detach(struct mlx4_rss *rss) rxq->mcq.cqe_cnt = dv_cq.cqe_cnt; rxq->mcq.set_ci_db = dv_cq.set_ci_db; rxq->mcq.cqe_64 = (dv_cq.cqe_size & 64) ? 1 : 0; + rxq->mcq.arm_db = dv_cq.arm_db; + rxq->mcq.arm_sn = dv_cq.arm_sn; + rxq->mcq.cqn = dv_cq.cqn; + rxq->mcq.cq_uar = dv_cq.cq_uar; ret = mlx4_rxq_alloc_elts(rxq); if (ret) { ERROR("%p: RXQ allocation failed: %s",