[dpdk-dev,v5,5/8] net/mlx4: remove duplicate handling in Tx burst
Checks
Commit Message
Remove usage of variable which count the packets for completion and
doesn't add more information than packets counter.
Remove no space in elements ring check which is already covered by
regular Tx flow.
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx4/mlx4_rxtx.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
@@ -256,7 +256,6 @@ struct pv {
struct txq *txq = (struct txq *)dpdk_txq;
unsigned int elts_head = txq->elts_head;
const unsigned int elts_n = txq->elts_n;
- unsigned int elts_comp = 0;
unsigned int bytes_sent = 0;
unsigned int i;
unsigned int max;
@@ -272,8 +271,6 @@ struct pv {
assert(max <= elts_n);
/* Always leave one free entry in the ring. */
--max;
- if (max == 0)
- return 0;
if (max > pkts_n)
max = pkts_n;
for (i = 0; (i != max); ++i) {
@@ -472,7 +469,6 @@ struct pv {
sq->head += nr_txbbs;
elt->buf = buf;
bytes_sent += buf->pkt_len;
- ++elts_comp;
elts_head = elts_head_next;
}
/* Take a shortcut if nothing must be sent. */
@@ -486,7 +482,7 @@ struct pv {
/* Ring QP doorbell. */
rte_write32(txq->msq.doorbell_qpn, txq->msq.db);
txq->elts_head = elts_head;
- txq->elts_comp += elts_comp;
+ txq->elts_comp += i;
return i;
}