From patchwork Thu Nov 2 16:42:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 31128 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A171D1B685; Thu, 2 Nov 2017 17:43:27 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30053.outbound.protection.outlook.com [40.107.3.53]) by dpdk.org (Postfix) with ESMTP id D42811B66C for ; Thu, 2 Nov 2017 17:43:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vklbgpz+c/ODAsTtlO+cojLY8u19Yi3Uakgwu90RKEc=; b=tLAADj51Af2EGN0OdndmxutUXSaGbhOXbrZfjqhhIRdJi5KBLghiYnq15gNO8qgP/Vy+WvxZ8MzVGlfYNBH/M6/9uxaVZkz0MoLANonKCZ8QuYHOG65f3siPjMgdPegqbQj1qynuep6HjImXSZAHYED+/wInAnC2ouxzUDiRQ24= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Thu, 2 Nov 2017 16:43:22 +0000 From: Matan Azrad To: Adrien Mazarguil Cc: dev@dpdk.org, Ophir Munk Date: Thu, 2 Nov 2017 16:42:51 +0000 Message-Id: <1509640971-8637-9-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1509640971-8637-1-git-send-email-matan@mellanox.com> References: <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509640971-8637-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0801CA0068.eurprd08.prod.outlook.com (2603:10a6:800:7d::12) To HE1PR0502MB3659.eurprd05.prod.outlook.com (2603:10a6:7:85::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16e76704-417a-408e-67e5-08d52210d531 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199); SRVR:HE1PR0502MB3659; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 3:ZoAA20G9X4iK8aDlMvqxDTvxQL+d9tEV3ThUn3OVVo3NBw4w1OnPk4LQEADRQypfvvKtB5MEEB9zPdngrvoq2l5cSAvCVVgHF4eEdlzuG3E2mICBLbWusDUQpyAfvGaBaCrT/HLJjKLGHtNrvRDQgZXHzoaqOJmcBuzG7+byp8gvKzH8OVoiSINr5JMgOdqduABgNcFlYQKfcR4CijcEYDZt7RY40jzjwdnT8keO7Z2Y9AhhxFRt+U0iNeMOXHUw; 25:5js6mCLgw+WttpH9ZnEjzkS/V1KpmVwTLKYPwmJCCupQ/LyvuhzUnwVv/E3MJF44FZOTTYAW4OaPd7TTgaTC3hHDqboB4tRdJqHxkCIPHQQTtz6hokOam9xqMOEwC3YcttchZEOYQy/RmRuxcJ27r87wD3nPoY14hUsq1BAdq1wXL0UHJ91OpClezbJAOepPCmVM0BvmvX4uO9VoTm7blSZeLIHvdZKws/2d2u4Ug/UwO3l3t/pPdIz4A+jkGkZ0x8ScPwSt3g9DCwiSBUu8IBkOIkeFcPjBWDGjbRSG6s+e/8FQqkfX03D4dW70tNWpnZS4iDAAbPw63GNL6bTS9w==; 31:c6GDG7EkdKCdAunvMpNuZYR2QxR505rxFkdJzm7pvZYc0v7wCQIRxZH6M9XYHhJi+v6FwcCheRMqv+ky1PunEmsaso5drUR+6AVEtIAzE/Q5gL3XmzLk4TEIgfWHMgVEhChhQM+qohxuXPy4f9rvWsyJlm3VKoJVaT2OOwpDfQkHusLdpnxOO7CvE3dbESw3fjSksIzAkqOOe07aXe5spC/gz+FupCzZdvvPN+JxPyU= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3659: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 20:0Kj71Ey5Bq3pToYaDJU8sCY2NlWE/h1bzCLFZG2gjgeJ+sa9h6cwNDeU3//Z7K074TfkyZ60uPsUVVGl1aSVh7/cbHxviWauDHtV+bYO2b5qSbibL7Vi7NIIU78me1x+ZypjwWPmB8tlWu6xRDRZ1wIvIXNE/NiXt160Lw4mPGYsDNZjehInTUFPKrBQGJ0jwN2aK9JWjAtmsyTuA9nnocglw3Z6gKIsqukuOClS0G/MSgGu0JiGdOgxNZv45huP2ISa5ghU0o1Lqi6pAe4oD1445RHi5W8xJ/QyIsrTyb0LD/lsCKM1n/2Z3JkViCPUD7GECaOxzdInJoswiE4kgkCbnkumUwYL0Wu0aMJZPpDmvFF+tlJvHxotAHo0J1D6DfSOg/TnWnsHTtly/PEMOB0HfqxhnnvXAi62POK8QgrJqXJcjIwBwk+1woFJBalwGI+n/a7LcE/mQduJ/sxMmizklKnyB+dtITfIBZ6KAj/hkqkEC6s/K8E/cgZ0qCYi; 4:akpEAfy9YuRJK7wOonDglsGQgqnQczawc4QEVdMDnl7IimQEBGeuo3oXfSL08SLbJWt8T00tZ7d6sNsSTZ61eC5cdEKCJdmFVz9TGSlncejvpUxp5Bx6gcgDr69vAgJ5Bmw+Yib96YHwwYHs8hHvGPfq1F1RNNnqEO7mndJH9iMMvILzn6+05OEieW3x9R6V+oKzr2sDQ64K+s8/OYzgh/hBFlKd5ExPY9OB2uN12TxOL69N1fDzsA5enyHjGcfxT9XAFj6UTOjAr3p/QwKWSdo8b3pRGW2c7f4nQxndQSlc9BsTS/eSCtAJCL39bSfb7mC2eIwwG7SDLHCDrKyTGw== X-Exchange-Antispam-Report-Test: UriScan:(60795455431006)(788757137089); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3231020)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0502MB3659; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0502MB3659; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(199003)(16586007)(50226002)(316002)(106356001)(105586002)(101416001)(21086003)(25786009)(8936002)(478600001)(4720700003)(8676002)(81156014)(189998001)(36756003)(33026002)(81166006)(97736004)(4326008)(5003940100001)(2906002)(55016002)(68736007)(33646002)(5660300001)(305945005)(107886003)(7736002)(50466002)(53936002)(48376002)(66066001)(16526018)(2950100002)(6916009)(6666003)(50986999)(47776003)(76176999)(3846002)(86362001)(69596002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3659; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3659; 23:b+l6sWstriaAC7A09pwgbSWuDbTlLipHkb66D0q?= wAztZ/Aiz8qntARGM/HTvliSQAd6vpsWU5E+VBzIqFXStG44rCsboeglV7RGoG76o1DJMyZkcbi6RmEaZ6v8m9tPdQ5466anXmBPofsjP4KaybUP/XHzOSmYaJxPNfI2oiHbPF/DfTckUC3d5FCRF4NjNtzW6aTj9/QwflbWOZhDYJ0uFFyzW8br4DJNwFPaFH0YYtCo5HRYVEVbHzh1YMs/MHjwUYo2FDKE14xAtcDFjuNnFTxGCCmj8w4N1gH+jyxteY5VuMFj3/6tCkUQH9PE874O+MlznVU7uawnqnd5Y2kPbHSBT2ablgF10N5LH+VolTCpZnOwJFrKder0DjFRNHLNvpQKKdCIpWQf3GJnJzig2QpfTATO7mR96Q/uWyaF00dtz/0HLwS4MblIe9iCXfie4VXp5leTZbXJP0OfeE6mMj4YLN7BsJvKbFucGgKe0hRc+qUoUAnI/N1jD2mEmSRcPY9rXf32EDDg+s93HzPlvSTp9kyFdjzPkRn6j2w/RxVpocQ3AllcCBSEBJHbyn48WCgFVlVVbeo5gA4vm6tr18VNES/ugiyktuZD8GPN0p2e33oI+BFp7SHfP1+RvDf+4JpBWbWBLW1c43uPqxWQASRLtzNaY2LNKac0PFG+5FsiskvHQRdOqLEGuUjLq35giqbY59ZZ49Coh/79SXrYtjtKWY+NIuaHlxJc9tmi3yBHERXP+Mk6BYh3wG1XpGzNYLhr7Re3R37gClruXF4VIwocthA98J+pD/swDdQtC8H9rNZsNnBfPxJrCx9mphMJXaFYnJ3gok+uZwJZxncFJkkfcvoFqXm+oaaxWDH1Ddx1SoCU3wh8Ea4svdz6Z/lB5Ux7+QWwH06ZZhm7TMMfnhP8Tvwx9I4XvX9vdYiuvxuFu6rgMoScnOiyjkSUUwePccj4g4k1jghCp0jVa8qPQUM2Xs9WNvTt6ef/9FWRorZMF1HsZT8/hsakfu9zcg/yJ9U1FybnG3naj5+c2PSvQsk7wcYIW2FTOKWNbwrNI2pKYg7ItSXKkkoLl8UFlItp54rTob/ds4urNj/5Qn85/nD6QLO3J8gTNw/cbt4BzPKNZKlvkLRD+iPOeMoFM4Z7TnZjGyn812fO3ZBC4Jg== X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3659; 6:CvgZ5dwH8W0JZPuGd8Sv1xybi12K63jsNJ6GwY4G9EZ11KJkl8Wwkljkvs9CfJtgyrUQPkxTVTnMUU7RjlkjONRxivqEAwHas6I4RtaR2D+k9uhObgxKax6ibYdq10gEaUk5u4tqWVjY9rtZ7E0bZNhAzUWlgs1U40Cp44qq+DrUCYzvyuvtbTadqBLB1cwnoX6LbI5kBDBEavLGitue8BbTOj7M1TtYOoPURH8XD3Y5blHPgYDy+DFW9CPymnSQZqvUt+Txf1+6PFJrOOlt2Fx8y8gNGnvy2R2dImstTRVCR6S9ZEh+JQNazZwN0Nj8Rf2Ath3kKjuvqdHgrpAzeaJOAYnuFAT6XvYKeAQUbPI=; 5:WhE3UUVt16bd+VdaYhrAZ7Mym+vKIVF1MM6aHJPPgEfGdWjZ59ZzEVTFzTrOq4DZOZ/Lyrj9UWOfmm+qpcYPr0xiST2s9I99OrdJYy2K3N6t1n3V3Ym8CbZs1IqgQye4/nq6Bk7FTbbY0ixhCD3E5TdRzLnHp8gHrz/Do1SuEkk=; 24:rDYCg5jcWkUeGEp/1X8YhdW+n7z0HgEMUXiXphAjatwlvGa68WL9LlYTMQIXaHgGAJ5z5Za2UQlEqhY2Ckm6oqI3mhSxEcakLfF37hGrgOY=; 7:Hb/yP8yD0OVoE3AeuDyQqU2e875+dTZR09Q4G7SkVXUEUlIEbmwOULW6XrokNfhFPb6mgU5zA6ZzUD7JKZ4YSoz6tHeO4PRYt1jF6M948qvdnlHV73D3EYaaXR336qz10J8jT7gxmItwNrFMvd1Z39i1v03aJEPMA+TT9tOIIpAlnBZGbPAYuK8kNL8aS1etjDzZyFO/lIBgI/xCWOjNBR1Pf1JAI4EDwSRBnu43om1dY1X9AjvrLu6j1andTk0n SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 16:43:22.6742 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16e76704-417a-408e-67e5-08d52210d531 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3659 Subject: [dpdk-dev] [PATCH v5 8/8] net/mlx4: mitigate Tx path memory barriers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Replace most of the memory barriers by IO memory barriers since they are all targeted to the DRAM; This improves code efficiency for systems which force store order between different addresses. Only the doorbell register store should be protected by memory barrier since it is targeted to the PCI memory domain. Limit pre byte count store IO memory barrier for systems with cache line size smaller than 64B (TXBB size). This patch improves Tx performance by 0.2MPPS for one segment 64B packets via 1 queue with 1 core test. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index 20060ce..5f8adec 100644 --- a/drivers/net/mlx4/mlx4_rxtx.c +++ b/drivers/net/mlx4/mlx4_rxtx.c @@ -168,7 +168,7 @@ struct pv { /* * Make sure we read the CQE after we read the ownership bit. */ - rte_rmb(); + rte_io_rmb(); #ifndef NDEBUG if (unlikely((cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) == MLX4_CQE_OPCODE_ERROR)) { @@ -196,14 +196,9 @@ struct pv { } while (1); if (unlikely(pkts == 0)) return 0; - /* - * Update CQ. - * To prevent CQ overflow we first update CQ consumer and only then - * the ring consumer. - */ + /* Update CQ. */ cq->cons_index = cons_index; *cq->set_ci_db = rte_cpu_to_be_32(cq->cons_index & MLX4_CQ_DB_CI_MASK); - rte_wmb(); sq->tail = sq->tail + nr_txbbs; /* Update the list of packets posted for transmission. */ elts_comp -= pkts; @@ -320,6 +315,7 @@ struct pv { * control segment. */ if ((uintptr_t)dseg & (uintptr_t)(MLX4_TXBB_SIZE - 1)) { +#if RTE_CACHE_LINE_SIZE < 64 /* * Need a barrier here before writing the byte_count * fields to make sure that all the data is visible @@ -330,6 +326,7 @@ struct pv { * data, and end up sending the wrong data. */ rte_io_wmb(); +#endif /* RTE_CACHE_LINE_SIZE */ dseg->byte_count = byte_count; } else { /* @@ -471,8 +468,7 @@ struct pv { break; } #endif /* NDEBUG */ - /* Need a barrier here before byte count store. */ - rte_io_wmb(); + /* Never be TXBB aligned, no need compiler barrier. */ dseg->byte_count = rte_cpu_to_be_32(buf->data_len); /* Fill the control parameters for this packet. */ ctrl->fence_size = (WQE_ONE_DATA_SEG_SIZE >> 4) & 0x3f; @@ -534,7 +530,7 @@ struct pv { * setting ownership bit (because HW can start * executing as soon as we do). */ - rte_wmb(); + rte_io_wmb(); ctrl->owner_opcode = rte_cpu_to_be_32(owner_opcode | ((sq->head & sq->txbb_cnt) ? MLX4_BIT_WQE_OWN : 0));