[dpdk-dev] doc: add limitation of VF VLAN strip function

Message ID 1509680456-51822-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei Nov. 3, 2017, 3:40 a.m. UTC
  This patch adds limitation of VF VLAN strip function.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 doc/guides/nics/i40e.rst | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

John McNamara Nov. 3, 2017, 3:36 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Friday, November 3, 2017 3:41 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add limitation of VF VLAN strip function
> 
> This patch adds limitation of VF VLAN strip function.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  doc/guides/nics/i40e.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index
> 05c1875..214fada 100644
> --- a/doc/guides/nics/i40e.rst
> +++ b/doc/guides/nics/i40e.rst
> @@ -478,6 +478,11 @@ enabled using the steps below.
> 
>        setpci -s <XX:XX.X> a8.w=<value>
> 
> +Vlan strip of VF
> +~~~~~~~~~~~~~~~~
> +
> +VF vlan strip function is supported from i40e kernel driver 2.1.26.
> +
>  High Performance of Small Packets on 40G NIC
>  --------------------------------------------

Probably would be slightly better as:

The VF vlan strip function is only supported in the i40e kernel driver >= 2.1.26.

However, the existing text is probably okay so:

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Ferruh Yigit Nov. 3, 2017, 10:58 p.m. UTC | #2
On 11/3/2017 8:36 AM, Mcnamara, John wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
>> Sent: Friday, November 3, 2017 3:41 AM
>> To: Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] doc: add limitation of VF VLAN strip function
>>
>> This patch adds limitation of VF VLAN strip function.
>>
>> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied to dpdk-next-net/master, thanks.

(used suggested text, thanks.)
  

Patch

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 05c1875..214fada 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -478,6 +478,11 @@  enabled using the steps below.
 
       setpci -s <XX:XX.X> a8.w=<value>
 
+Vlan strip of VF
+~~~~~~~~~~~~~~~~
+
+VF vlan strip function is supported from i40e kernel driver 2.1.26.
+
 High Performance of Small Packets on 40G NIC
 --------------------------------------------