diff mbox

[dpdk-dev] net/kni: remove eth_kni_drv declaration

Message ID 1509797029-9618-1-git-send-email-rami.rosen@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rami Rosen Nov. 4, 2017, 12:03 p.m. UTC 
  This patch removes the forward declaration of eth_kni_drv
in rte_eth_kni.c; this forward declaration was made unnecessary
by commit 050fe6e9ff970ff92d842912136be8f9f52e171f 
("drivers/net: use ethdev allocation helper for vdev"), which 
removes the usage of eth_kni_drv in the eth_kni_create() method.

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 drivers/net/kni/rte_eth_kni.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ferruh Yigit Nov. 6, 2017, 7:02 p.m. UTC | #1 
On 11/4/2017 5:03 AM, Rami Rosen wrote:
> This patch removes the forward declaration of eth_kni_drv
> in rte_eth_kni.c; this forward declaration was made unnecessary
> by commit 050fe6e9ff970ff92d842912136be8f9f52e171f 
> ("drivers/net: use ethdev allocation helper for vdev"), which 
> removes the usage of eth_kni_drv in the eth_kni_create() method.
> 
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>

Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev")
Cc: stable@dpdk.org

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Nov. 7, 2017, 8:39 a.m. UTC | #2 
On 11/6/2017 11:02 AM, Ferruh Yigit wrote:
> On 11/4/2017 5:03 AM, Rami Rosen wrote:
>> This patch removes the forward declaration of eth_kni_drv
>> in rte_eth_kni.c; this forward declaration was made unnecessary
>> by commit 050fe6e9ff970ff92d842912136be8f9f52e171f 
>> ("drivers/net: use ethdev allocation helper for vdev"), which 
>> removes the usage of eth_kni_drv in the eth_kni_create() method.
>>
>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> 
> Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev")
> Cc: stable@dpdk.org
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index d68ff7a..e31b909 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -358,8 +358,6 @@  struct pmd_internals {
 	.stats_reset = eth_kni_stats_reset,
 };
 
-static struct rte_vdev_driver eth_kni_drv;
-
 static struct rte_eth_dev *
 eth_kni_create(struct rte_vdev_device *vdev,
 		struct eth_kni_args *args,