diff mbox

[dpdk-dev,v2] net/ixgbe: fix build on gcc 4.5.1

Message ID 1509968207-16465-1-git-send-email-radu.nicolau@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Radu Nicolau Nov. 6, 2017, 11:36 a.m. UTC 
  Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")

On SUSE11 with gcc 4.5.1 the following build error occurred,
most likely because of improper handling of annonymous unions:

DPDK/drivers/net/ixgbe/ixgbe_ipsec.c:579:4:
error: unknown field ‘ipsec’ specified in initializer
compilation terminated due to -Wfatal-errors.

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: additional info added in the commit message.


 drivers/net/ixgbe/ixgbe_ipsec.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Thomas Monjalon Nov. 7, 2017, 1:24 a.m. UTC | #1 
06/11/2017 12:36, Radu Nicolau:
> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")

This Fixes line must be at the end before you SoB.

> On SUSE11 with gcc 4.5.1 the following build error occurred,
> most likely because of improper handling of annonymous unions:
> 
> DPDK/drivers/net/ixgbe/ixgbe_ipsec.c:579:4:
> error: unknown field ‘ipsec’ specified in initializer
> compilation terminated due to -Wfatal-errors.
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index 99c0a73..105da11 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -576,48 +576,48 @@  ixgbe_crypto_capabilities_get(void *device __rte_unused)
 		{ /* IPsec Inline Crypto ESP Transport Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Transport Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Egress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 		},
 		{ /* IPsec Inline Crypto ESP Tunnel Ingress */
 			.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
 				.mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
 				.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
 				.options = { 0 }
-			},
+			} },
 			.crypto_capabilities = aes_gcm_gmac_crypto_capabilities,
 			.ol_flags = 0
 		},