diff mbox

[dpdk-dev] examples/ipsec-secgw: fix build with gcc 4.5.1

Message ID 1510221441-17680-1-git-send-email-radu.nicolau@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Radu Nicolau Nov. 9, 2017, 9:57 a.m. UTC 
  On SUSE11 with gcc 4.5.1 the following build error occurred,
most likely because of improper handling of annonymous unions:

examples/ipsec-secgw/ipsec.c:87:4 error:
	unknown field ‘ipsec’ specified in initializer

Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 examples/ipsec-secgw/ipsec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

De Lara Guarch, Pablo Nov. 9, 2017, 2:20 p.m. UTC | #1 
> -----Original Message-----

> From: Nicolau, Radu

> Sent: Thursday, November 9, 2017 9:57 AM

> To: dev@dpdk.org

> Cc: thomas@monjalon.net; Gonzalez Monroy, Sergio

> <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo

> <pablo.de.lara.guarch@intel.com>; Nicolau, Radu

> <radu.nicolau@intel.com>

> Subject: [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1

> 

> On SUSE11 with gcc 4.5.1 the following build error occurred, most likely

> because of improper handling of annonymous unions:

> 

> examples/ipsec-secgw/ipsec.c:87:4 error:

> 	unknown field ‘ipsec’ specified in initializer

> 

> Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")

> 

> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>


Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Thomas Monjalon Nov. 10, 2017, 1:48 a.m. UTC | #2 
> > On SUSE11 with gcc 4.5.1 the following build error occurred, most likely
> > because of improper handling of annonymous unions:
> > 
> > examples/ipsec-secgw/ipsec.c:87:4 error:
> > 	unknown field ‘ipsec’ specified in initializer
> > 
> > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")
> > 
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index c24284d..70ed227 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -84,7 +84,7 @@  create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
 		struct rte_security_session_conf sess_conf = {
 			.action_type = sa->type,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.spi = sa->spi,
 				.salt = sa->salt,
 				.options = { 0 },
@@ -94,7 +94,7 @@  create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
 						sa->flags == IP6_TUNNEL) ?
 					RTE_SECURITY_IPSEC_SA_MODE_TUNNEL :
 					RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
-			},
+			} },
 			.crypto_xform = sa->xforms
 
 		};